Firesphere\PartialUserforms\Models\PartialFormSubmission

Complexity

Total Complexity

14

Size/Duplication

Total Lines	114
Duplicated Lines	36.84 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes	2
Bugs	0	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getCMSFields()	0	13	1
A	canCreate()	0	17	4
A	canView()	14	14	3
A	canEdit()	14	14	3
A	canDelete()	14	14	3

<?php

namespace Firesphere\PartialUserforms\Models;

use SilverStripe\Forms\FieldList;
use SilverStripe\ORM\DataObject;
use SilverStripe\UserForms\Model\Submission\SubmittedForm;
use SilverStripe\Forms\GridField\GridFieldConfig;
use SilverStripe\Forms\GridField\GridFieldDataColumns;
use SilverStripe\Forms\GridField\GridFieldExportButton;
use SilverStripe\Forms\GridField\GridFieldPrintButton;
/**
 * Class \Firesphere\PartialUserforms\Models\PartialFormSubmission
 *
 * @property boolean $IsSend
 * @property int $UserDefinedFormID
 * @method \SilverStripe\ORM\DataObject UserDefinedForm()
 * @method \SilverStripe\ORM\DataList|\Firesphere\PartialUserforms\Models\PartialFieldSubmission[] PartialFields()
 */
class PartialFormSubmission extends SubmittedForm
{
    private static $table_name = 'PartialFormSubmission';

Consider using a different property name as you override a private property of the parent class.

The property $table_name is not used and could be removed.

    private static $db = [

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

        'IsSend' => 'Boolean(false)'
    ];

    private static $has_one = [

Consider using a different property name as you override a private property of the parent class.

The property $has_one is not used and could be removed.

        'UserDefinedForm' => DataObject::class
    ];

    private static $has_many = [

Consider using a different property name as you override a private property of the parent class.

The property $has_many is not used and could be removed.

        'PartialFields' => PartialFieldSubmission::class
    ];

    public function getCMSFields()
    {
        /** @var FieldList $fields */
        $fields = parent::getCMSFields();
        $fields->removeByName(['Values', 'IsSend']);
        $config = new GridFieldConfig();
        $config->addComponent(new GridFieldDataColumns());
        $config->addComponent(new GridFieldPrintButton());

        $fields->dataFieldByName('PartialFields')->setConfig($config);

The method setConfig() does not exist on SilverStripe\Forms\FormField. Did you maybe mean config()?

        return $fields;
    }

    /**
     * @param Member
     *
     * @return boolean
     */
    public function canCreate($member = null, $context = [])
    {
        $extended = $this->extendedCan(__FUNCTION__, $member);
        if ($extended !== null) {
            return $extended;
        }

        if ($this->UserDefinedForm()) {
            return $this->UserDefinedForm()->canCreate($member, $context);

The expression $this->UserDefinedForm()->canCreate($member, $context); of type boolean|string adds the type string to the return on line 63 which is incompatible with the return type of the parent method SilverStripe\UserForms\Model\Submission\SubmittedForm::canCreate of type boolean.

        }

        if (!$this->Parent()) {

The method Parent does not exist on object<Firesphere\PartialUserforms\Models\PartialFormSubmission>? Since you implemented __call, maybe consider adding a @method annotation.

            $this->ParentID = $this->UserDefinedFormID;

The property ParentID does not exist on object<Firesphere\PartialUserforms\Models\PartialFormSubmission>. Since you implemented __set, maybe consider adding a @property annotation.

        }

        return parent::canCreate($member);
    }

    /**
     * @param Member
     *
     * @return boolean
     */
    public function canView($member = null)

This method seems to be duplicated in your project.

    {
        $extended = $this->extendedCan(__FUNCTION__, $member);

        if ($extended !== null) {
            return $extended;
        }

        if ($this->UserDefinedForm()) {
            return $this->UserDefinedForm()->canView($member);

The expression $this->UserDefinedForm()->canView($member); of type boolean|string adds the type string to the return on line 87 which is incompatible with the return type of the parent method SilverStripe\UserForms\Model\Submission\SubmittedForm::canView of type boolean.

        }

        return parent::canView($member);
    }

    /**
     * @param Member
     *
     * @return boolean
     */
    public function canEdit($member = null)

This method seems to be duplicated in your project.

    {
        $extended = $this->extendedCan(__FUNCTION__, $member);

        if ($extended !== null) {
            return $extended;
        }

        if ($this->UserDefinedForm()) {
            return $this->UserDefinedForm()->canEdit($member);

The expression $this->UserDefinedForm()->canEdit($member); of type boolean|string adds the type string to the return on line 107 which is incompatible with the return type of the parent method SilverStripe\UserForms\Model\Submission\SubmittedForm::canEdit of type boolean.

        }

        return parent::canEdit($member);
    }

    /**
     * @param Member
     *
     * @return boolean
     */
    public function canDelete($member = null)

This method seems to be duplicated in your project.

    {
        $extended = $this->extendedCan(__FUNCTION__, $member);

        if ($extended !== null) {
            return $extended;
        }

        if ($this->UserDefinedForm()) {
            return $this->UserDefinedForm()->canDelete($member);

The expression $this->UserDefinedForm()->canDelete($member); of type boolean|string adds the type string to the return on line 127 which is incompatible with the return type of the parent method SilverStripe\UserForms\Model\Submission\SubmittedForm::canDelete of type boolean.

        }

        return parent::canDelete($member);
    }

}