Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 14 | class PartialSubmissionTaskTest extends SapphireTest |
||
| 15 | { |
||
| 16 | /** |
||
| 17 | * @var bool |
||
| 18 | */ |
||
| 19 | protected $usesDatabase = true; |
||
| 20 | |||
| 21 | public function testTitle() |
||
| 22 | { |
||
| 23 | $task = Injector::inst()->get(PartialSubmissionTask::class); |
||
| 24 | $this->assertEquals('Export partial form submissions to email address', $task->getTitle()); |
||
| 25 | } |
||
| 26 | |||
| 27 | public function testRun() |
||
| 28 | { |
||
| 29 | SiteConfigHelper::setupSiteConfig('[email protected]', null, true); |
||
| 30 | $request = new HTTPRequest('GET', 'dev/tasks/partialsubmissiontask'); |
||
| 31 | |||
| 32 | /** @var PartialSubmissionTask $task */ |
||
| 33 | $task = Injector::inst()->get(PartialSubmissionTask::class); |
||
| 34 | |||
| 35 | $task->run($request); |
||
| 36 | |||
| 37 | $this->assertEmailSent('[email protected]'); |
||
| 38 | } |
||
| 39 | |||
| 40 | public function testExtraUser() |
||
| 41 | { |
||
| 42 | SiteConfigHelper::setupSiteConfig('[email protected]', null, true); |
||
| 43 | $user = Member::create(['FirstName' => 'Test', 'Email' => '[email protected]']); |
||
| 44 | $user->write(); |
||
| 45 | Security::setCurrentUser($user); |
||
| 46 | $request = new HTTPRequest('GET', 'dev/tasks/partialsubmissiontask'); |
||
| 47 | |||
| 48 | $task = new PartialSubmissionTask(); |
||
| 49 | |||
| 50 | $task->run($request); |
||
| 51 | |||
| 52 | $this->assertEmailSent('[email protected]'); |
||
| 53 | $this->assertEmailSent('[email protected]'); |
||
| 54 | } |
||
| 55 | |||
| 56 | public function testNoConfigButUser() |
||
| 57 | { |
||
| 58 | $user = Member::create(['FirstName' => 'Test', 'Email' => '[email protected]']); |
||
| 59 | $user->write(); |
||
| 60 | Security::setCurrentUser($user); |
||
| 61 | SiteConfigHelper::setupSiteConfig(null, null, true); |
||
| 62 | $request = new HTTPRequest('GET', 'dev/tasks/partialsubmissiontask'); |
||
| 63 | |||
| 64 | $task = new PartialSubmissionTask(); |
||
| 65 | |||
| 66 | $task->run($request); |
||
| 67 | |||
| 68 | $this->assertEmailSent('[email protected]'); |
||
| 69 | } |
||
| 70 | |||
| 71 | protected function setUp() |
||
| 72 | { |
||
| 73 | parent::setUp(); |
||
| 74 | Config::modify()->set(QueuedJobService::class, 'use_shutdown_function', false); |
||
| 75 | } |
||
| 76 | } |
||
| 77 |