PartialFileFieldSubmission::canDelete() - Code Metrics - Inspection of "Solves #15 Safe files to partial submissions" - Firesphere/silverstripe-partial-userforms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#16)

by Simon

created 2019-08-23 05:51 UTC

PartialFileFieldSubmission::canDelete() A

↳ Parent: PartialFileFieldSubmission

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	8
Ratio	100 %

Importance

Changes

Metric	Value
dl	8
loc	8
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	1

<?php

namespace Firesphere\PartialUserforms\Models;

use SilverStripe\Security\Member;
use SilverStripe\UserForms\Model\Submission\SubmittedFileField;

/**
 * Class \Firesphere\PartialUserforms\Models\PartialFileFieldSubmission
 *
 * @property int $SubmittedFormID
 * @method PartialFormSubmission SubmittedForm()
 */
class PartialFileFieldSubmission extends SubmittedFileField

{
    private static $table_name = 'PartialFileFieldSubmission';


    private static $has_one = [

        'SubmittedForm' => PartialFormSubmission::class,
    ];


    /**
     * @param Member $member
     * @param array $context
     * @return boolean
     */
    public function canCreate($member = null, $context = [])
    {
        return false;
    }

    /**
     * @param Member $member
     *
     * @return bool
     */
    public function canView($member = null)
    {
        if ($this->SubmittedFormID) {
            return $this->SubmittedForm()->canView($member);

        }

        return parent::canView($member);
    }

    /**
     * @param Member $member
     *
     * @return bool
     */
    public function canEdit($member = null)
    {
        if ($this->SubmittedFormID) {
            return $this->SubmittedForm()->canEdit($member);

        }

        return parent::canEdit($member);
    }

    /**
     * @param Member $member
     *
     * @return bool
     */
    public function canDelete($member = null)
    {
        if ($this->SubmittedFormID) {
            return $this->SubmittedForm()->canDelete($member);

        }

        return parent::canDelete($member);
    }
}


1		<?php
2
3		namespace Firesphere\PartialUserforms\Models;
4
5		use SilverStripe\Security\Member;
6		use SilverStripe\UserForms\Model\Submission\SubmittedFileField;
7
8		/**
9		* Class \Firesphere\PartialUserforms\Models\PartialFileFieldSubmission
10		*
11		* @property int $SubmittedFormID
12		* @method PartialFormSubmission SubmittedForm()
13		*/
14	View Code Duplication	class PartialFileFieldSubmission extends SubmittedFileField
		1 ignored issue – show Duplication introduced 2019-08-22 04:04 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
15		{
16		private static $table_name = 'PartialFileFieldSubmission';
		0 ignored issues – show Comprehensibility introduced 2018-05-08 23:26 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
17
18		private static $has_one = [
		0 ignored issues – show Comprehensibility introduced 2018-05-08 23:26 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
19		'SubmittedForm' => PartialFormSubmission::class,
20		];
21
22
23		/**
24		* @param Member $member
25		* @param array $context
26		* @return boolean
27		*/
28		public function canCreate($member = null, $context = [])
29		{
30		return false;
31		}
32
33		/**
34		* @param Member $member
35		*
36		* @return bool
37		*/
38		public function canView($member = null)
39		{
40		if ($this->SubmittedFormID) {
41		return $this->SubmittedForm()->canView($member);
		0 ignored issues – show Bug Compatibility introduced 2019-08-23 05:52 UTC by Report Bug Copy Issue Report The expression `$this->SubmittedForm()->canView($member);` of type `boolean\|string` adds the type `string` to the return on line 41 which is incompatible with the return type of the parent method `SilverStripe\UserForms\M...ittedFormField::canView` of type `boolean`. Loading history...
42		}
43
44		return parent::canView($member);
45		}
46
47		/**
48		* @param Member $member
49		*
50		* @return bool
51		*/
52		public function canEdit($member = null)
53		{
54		if ($this->SubmittedFormID) {
55		return $this->SubmittedForm()->canEdit($member);
		0 ignored issues – show Bug Compatibility introduced 2019-08-23 05:52 UTC by Report Bug Copy Issue Report The expression `$this->SubmittedForm()->canEdit($member);` of type `boolean\|string` adds the type `string` to the return on line 55 which is incompatible with the return type of the parent method `SilverStripe\UserForms\M...ittedFormField::canEdit` of type `boolean`. Loading history...
56		}
57
58		return parent::canEdit($member);
59		}
60
61		/**
62		* @param Member $member
63		*
64		* @return bool
65		*/
66		public function canDelete($member = null)
67		{
68		if ($this->SubmittedFormID) {
69		return $this->SubmittedForm()->canDelete($member);
		0 ignored issues – show Bug Compatibility introduced 2019-08-23 05:52 UTC by Report Bug Copy Issue Report The expression `$this->SubmittedForm()->canDelete($member);` of type `boolean\|string` adds the type `string` to the return on line 69 which is incompatible with the return type of the parent method `SilverStripe\UserForms\M...tedFormField::canDelete` of type `boolean`. Loading history...
70		}
71
72		return parent::canDelete($member);
73		}
74		}
75

Firesphere / silverstripe-partial-userforms

Pull Request — master (#16)

PartialFileFieldSubmission::canDelete() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like