Firesphere\PartialUserforms\Models\PartialFileFieldSubmission

Complexity

Total Complexity

7

Size/Duplication

Total Lines	61
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

85.71%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	canCreate()	4	4	1
A	canView()	8	8	2
A	canEdit()	8	8	2
A	canDelete()	8	8	2

<?php

namespace Firesphere\PartialUserforms\Models;

use SilverStripe\Security\Member;
use SilverStripe\UserForms\Model\Submission\SubmittedFileField;

/**
 * Class \Firesphere\PartialUserforms\Models\PartialFileFieldSubmission
 *
 * @property int $SubmittedFormID
 * @method PartialFormSubmission SubmittedForm()
 */
class PartialFileFieldSubmission extends SubmittedFileField

This class seems to be duplicated in your project.

{
    private static $table_name = 'PartialFileFieldSubmission';

Consider using a different property name as you override a private property of the parent class.

    private static $has_one = [

Consider using a different property name as you override a private property of the parent class.

        'SubmittedForm' => PartialFormSubmission::class,
    ];


    /**
     * @param Member $member
     * @param array $context
     * @return boolean
     */
    public function canCreate($member = null, $context = [])
    {
        return false;
    }

    /**
     * @param Member $member
     *
     * @return bool
     */
    public function canView($member = null)
    {
        if ($this->SubmittedFormID) {
            return $this->SubmittedForm()->canView($member);

The expression $this->SubmittedForm()->canView($member); of type boolean|string adds the type string to the return on line 41 which is incompatible with the return type of the parent method SilverStripe\UserForms\Model\Submission\SubmittedFormField::canView of type boolean.

        }

        return parent::canView($member);
    }

    /**
     * @param Member $member
     *
     * @return bool
     */
    public function canEdit($member = null)
    {
        if ($this->SubmittedFormID) {
            return $this->SubmittedForm()->canEdit($member);

The expression $this->SubmittedForm()->canEdit($member); of type boolean|string adds the type string to the return on line 55 which is incompatible with the return type of the parent method SilverStripe\UserForms\Model\Submission\SubmittedFormField::canEdit of type boolean.

        }

        return parent::canEdit($member);
    }

    /**
     * @param Member $member
     *
     * @return bool
     */
    public function canDelete($member = null)
    {
        if ($this->SubmittedFormID) {
            return $this->SubmittedForm()->canDelete($member);

The expression $this->SubmittedForm()->canDelete($member); of type boolean|string adds the type string to the return on line 69 which is incompatible with the return type of the parent method SilverStripe\UserForms\Model\Submission\SubmittedFormField::canDelete of type boolean.

        }

        return parent::canDelete($member);
    }
}