Firesphere / silverstripe-haveibeenpwnd

src/services/HaveIBeenPwnedService.php

<?php

namespace Firesphere\HaveIBeenPwned\Services;

use GuzzleHttp\Client;
use GuzzleHttp\Exception\GuzzleException;
use Psr\Http\Message\ResponseInterface;
use SilverStripe\Core\Config\Configurable;
use SilverStripe\Core\Convert;
use SilverStripe\Core\Injector\Injector;
use SilverStripe\Security\Member;

/**
 * Class HaveIBeenPwnedService
 * @package Firesphere\HaveIBeenPwned\Services
 */
class HaveIBeenPwnedService
{
    use Configurable;

    /**
     * Api endpoint emails
     */
    const PWND_URL = 'https://haveibeenpwned.com/api/v3';

    /**
     * API endpoint passwords
     */
    const PWND_API_URL = 'https://api.pwnedpasswords.com/';

    /**
     * API Version
     */
    const API_VERSION = '3';

    /**
     * Useragent
     */
    const USER_AGENT = 'Firesphere-HaveIBeenPwned-checker/1.0';

    /**
     * @config
     * @var bool
     */
    private static $allow_pwnd = false;

    /**
     * @config
     * @var bool
     */
    private static $save_pwnd = true;

    /**
     * @var array
     */
    protected $args;

    /**
     * HaveIBeenPwnedService constructor.
     * @param array $args
     */
    public function __construct($args = [])
    {
        $this->args = $args;
    }

    /**
     * @param string $pwd
     * @return int
     * @throws GuzzleException
     */
    public function checkPwnedPassword($pwd)
    {
        $this->args['base_uri'] = static::PWND_API_URL;

        $sha = sha1($pwd);
        $shaStart = substr($sha, 0, 5);
        $shaEnd = substr($sha, 5);
        /** @var Client $client */
        $client = Injector::inst()->createWithArgs(Client::class, [$this->args]);
        $result = $client->request(
            'GET',
            'range/' . $shaStart,
            [
                'headers' => [
                    'user-agent'  => static::USER_AGENT,
                    'api-version' => static::API_VERSION
                ]
            ]
        );

        return $this->checkList($result, $shaEnd);
    }

    /**
     * @param ResponseInterface $result
     * @param $shaEnd
     * @return int
     */
    private function checkList($result, $shaEnd)
    {
        $count = 0;
        $shaEnd = strtoupper($shaEnd);
        $suffixes = explode("\n", $result->getBody());
        foreach ($suffixes as $suffix) {
            list($suffix, $pwnCount) = explode(':', trim($suffix));
            if ($suffix === $shaEnd) {
                $count += (int)$pwnCount;
                break;
            }
        }

        return $count;
    }

    /**
     * @param Member $member
     * @return string
     * @throws GuzzleException
     */
    public function checkPwnedEmail($member)
    {
        $this->args['base_uri'] = static::PWND_URL;
        $api_key = $this->hibp_api_key;

The property hibp_api_key does not exist on Firesphere\HaveIBeenPwned\Services\HaveIBeenPwnedService. Did you maybe forget to declare it?

        $uniqueField = Member::config()->get('unique_identifier_field');
        $account = $member->{$uniqueField};

        /** @var Client $client */
        $client = Injector::inst()->createWithArgs(Client::class, [$this->args]);

        $result = $client->request(
            'GET',
            'breachedaccount/' . $account . '?truncateResponse=true',
            [
                'headers' => [
                    'user-agent'  => static::USER_AGENT,
                    'api-version' => static::API_VERSION,
                    'hibp-api-key' => $api_key
                ]
            ]
        );

        return $this->checkBreaches($result);
    }

    /**
     * @param ResponseInterface $result
     * @return string
     */
    private function checkBreaches($result)
    {
        $body = $result->getBody();

        $sites = [];

        $breaches = Convert::json2array($body);

The function SilverStripe\Core\Convert::json2array() has been deprecated: 4.4.0:5.0.0 Use json_decode() instead

        foreach ($breaches as $breach) {
            if (!empty($breach['Name'])) {
                $sites[] = $breach['Name'];
            }
        }

        if (count($sites)) {
            return implode(', ', $sites);
        }

        return '';
    }

    /**
     * @return array
     */
    public function getArgs()
    {
        return $this->args;
    }

    /**
     * @param array $args
     */
    public function setArgs($args)
    {
        $this->args = $args;
    }
}