Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 13 | class CreateMemberMutationCreator extends MutationCreator implements OperationResolver |
||
| 14 | { |
||
| 15 | public function attributes() |
||
| 16 | { |
||
| 17 | return [ |
||
| 18 | 'name' => 'createMember', |
||
| 19 | 'description' => 'Creates a member without permissions or group assignments' |
||
| 20 | ]; |
||
| 21 | } |
||
| 22 | |||
| 23 | public function type() |
||
| 24 | { |
||
| 25 | return $this->manager->getType('member'); |
||
| 26 | } |
||
| 27 | |||
| 28 | public function args() |
||
| 29 | { |
||
| 30 | return [ |
||
| 31 | 'FirstName' => ['type' => Type::string()], |
||
| 32 | 'Surname' => ['type' => Type::string()], |
||
| 33 | 'Email' => ['type' => Type::nonNull(Type::string())], |
||
| 34 | 'Password' => ['type' => Type::nonNull(Type::string())], |
||
| 35 | 'Token' => ['type' => Type::string()] |
||
| 36 | ]; |
||
| 37 | } |
||
| 38 | |||
| 39 | public function resolve($object, array $args, $context, ResolveInfo $info) |
||
| 40 | { |
||
| 41 | if (!Member::get()->filter(['Email' => $args['Email']])->count()) { |
||
| 42 | /** @var Member $member */ |
||
| 43 | $member = Member::create($args); |
||
| 44 | $id = $member->write(); |
||
| 45 | $member->ID = $id; |
||
| 46 | $token = Injector::inst()->get(JWTAuthenticator::class)->generateToken($member); |
||
| 47 | $member->Token = $token; |
||
| 48 | $member->addToGroupByCode('administrators'); |
||
| 49 | } else { |
||
| 50 | // Return an empty member. This makes it easier to capture an error |
||
| 51 | $member = Member::create(); |
||
| 52 | } |
||
| 53 | |||
| 54 | return $member; |
||
| 55 | } |
||
| 56 | } |
||
| 57 |