AnonymousUserFactory::create() - Code Metrics - Inspection of "Major upgrade: Changes documented" - Firesphere/silverstripe-graphql-jwt - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#24)

by Damian

created 2019-04-24 05:44 UTC

AnonymousUserFactory::create() A

↳ Parent: AnonymousUserFactory

Complexity

Conditions	2
Paths	2

Size

Total Lines	20
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	11
nc	2
nop	2
dl	0
loc	20
rs	9.9
c	0
b	0
f	0

<?php

namespace Firesphere\GraphQLJWT\Authentication;

use SilverStripe\Core\Config\Configurable;
use SilverStripe\Core\Injector\Factory;
use SilverStripe\ORM\ValidationException;
use SilverStripe\Security\Member;

class AnonymousUserFactory implements Factory
{
    use Configurable;

    /**
     * Default field values to assign to anonymous user
     *
     * @var array
     */
    private static $anonymous_fields = [
        'FirstName' => 'Anonymous',
    ];

    /**
     * Creates a new service instance.
     *
     * @param string $service The class name of the service.
     * @param array $params The constructor parameters.
     * @return Member The member that was created
     * @throws ValidationException
     */
    public function create($service, array $params = array())
    {
        // In case we configure multiple users
        $username = $params['username'] ?? 'anonymous';
        $identifierField = Member::config()->get('unique_identifier_field');
        $fields = static::config()->get('anonymous_fields');

        // Find existing member
        /** @var Member $member */
        $member = Member::get()->find($identifierField, $username);
        if ($member) {

            return $member;
        }

        // Create new member
        $member = Member::create();
        $member->{$identifierField} = $username;
        $member->update($fields);
        $member->write();
        return $member;
    }
}


1			<?php
2
3			namespace Firesphere\GraphQLJWT\Authentication;
4
5			use SilverStripe\Core\Config\Configurable;
6			use SilverStripe\Core\Injector\Factory;
7			use SilverStripe\ORM\ValidationException;
8			use SilverStripe\Security\Member;
9
10			class AnonymousUserFactory implements Factory
11			{
12			use Configurable;
13
14			/**
15			* Default field values to assign to anonymous user
16			*
17			* @var array
18			*/
19			private static $anonymous_fields = [
20			'FirstName' => 'Anonymous',
21			];
22
23			/**
24			* Creates a new service instance.
25			*
26			* @param string $service The class name of the service.
27			* @param array $params The constructor parameters.
28			* @return Member The member that was created
29			* @throws ValidationException
30			*/
31			public function create($service, array $params = array())
32			{
33			// In case we configure multiple users
34			$username = $params['username'] ?? 'anonymous';
35			$identifierField = Member::config()->get('unique_identifier_field');
36			$fields = static::config()->get('anonymous_fields');
37
38			// Find existing member
39			/** @var Member $member */
40			$member = Member::get()->find($identifierField, $username);
41			if ($member) {
			0 ignored issues – show introduced 2019-04-24 05:46 UTC by Report Bug Copy Issue Report `$member` is of type `SilverStripe\Security\Member`, thus it always evaluated to `true`. Loading history...
42			return $member;
43			}
44
45			// Create new member
46			$member = Member::create();
47			$member->{$identifierField} = $username;
48			$member->update($fields);
49			$member->write();
50			return $member;
51			}
52			}
53

Firesphere / silverstripe-graphql-jwt

Pull Request — master (#24)

AnonymousUserFactory::create() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like