AnalyticsUpdateJob

Complexity

Total Complexity

8

Size/Duplication

Total Lines	82
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getTitle()	0	3	1
A	__construct()	0	3	1
A	getReport()	0	15	2
A	afterComplete()	0	12	3
A	process()	0	7	1

<?php

if (class_exists('AbstractQueuedJob')) {
    /**
     * Class AnalyticsUpdateJob
     *
     * Job to run in the QueuedJobs
     */
    class AnalyticsUpdateJob extends AbstractQueuedJob

The type AbstractQueuedJob was not found. Maybe you did not declare it correctly or list all dependencies?

    {
        /**
         * @var GoogleAnalyticsReportService
         */
        protected $service;

        /**
         * @var PageUpdateService
         */
        protected $updateService;

        /**
         * AnalyticsUpdateJob constructor.
         * @param array $params
         */
        public function __construct($params = [])
        {
            parent::__construct($params);
        }

        /**
         * @return string
         */
        public function getTitle()
        {
            return 'Update Google Analytics information for the configured pages';
        }

        /**
         * Boot up the process
         * @throws \Google_Exception
         * @throws \LogicException
         * @throws \ValidationException
         */
        public function process()
        {
            $clientService = new GoogleClientService();

            $this->getReport($clientService);

            $this->isComplete = true;

The property isComplete does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        }

        /**
         * Execute the whole part
         *
         * @param GoogleClientService $client
         * @throws \ValidationException
         */
        protected function getReport($client)
        {
            $this->service = new GoogleAnalyticsReportService($client);

            /** @var array $reports */
            $reports = $this->service->getReport();
            $count = 0;

            $this->updateService = new PageUpdateService();
            foreach ($reports as $report) {
                /** @var array $rows */
                $rows = $report->getData()->getRows();
                $count += $this->updateService->updateVisits($rows);
            }
            $this->addMessage("$count Pages updated with Google Analytics visit count");
        }

        /**
         * If needed, queue itself with
         */
        public function afterComplete()
        {
            if ($this->service->batched && $this->updateService->batched) {
                /** @var AnalyticsUpdateJob $nextJob */
                $nextJob = Injector::inst()->get('AnalyticsUpdateJob');

The type Injector was not found. Maybe you did not declare it correctly or list all dependencies?

                $nextJob->setJobData(1, 0, false, new stdClass(), ['Batched data from Google']);
                /** @var QueuedJobService $jobService */
                $jobService = Injector::inst()->get(QueuedJobService::class);

The type QueuedJobService was not found. Maybe you did not declare it correctly or list all dependencies?

                /* Queue immediately after this job */
                $jobService->queueJob($nextJob, date('Y-m-d H:i:s'));
            }
            parent::afterComplete();
        }
    }
}