FluentSchemaExtension::onAfterFieldDefinition() - Code Metrics - Inspection of "Fixup the test" - Firesphere/silverstripe-fluent-solr - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 580f23...f2132c )

by Simon

created 2020-01-19 21:39 UTC

FluentSchemaExtension::onAfterFieldDefinition() A

↳ Parent: FluentSchemaExtension

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	5
nc	2
nop	2
dl	0
loc	9
ccs	6
cts	6
cp	1
crap	2
rs	10
c	1
b	0
f	0

<?php
/**
 * Class FluentSchemaExtension|Firesphere\SolrFluent\Extensions\FluentSchemaExtension Add Fluent schema requirements
 *
 * @package Firesphere\SolrFluent\Extensions
 * @author Simon `Firesphere` Erkelens; Marco `Sheepy` Hermo
 * @copyright Copyright (c) 2018 - now() Firesphere & Sheepy
 */

namespace Firesphere\SolrFluent\Extensions;

use Firesphere\SolrSearch\Factories\SchemaFactory;
filter:
    dependency_paths: ["lib/*"]
use SilverStripe\Core\Extension;
use SilverStripe\ORM\ArrayList;
use SilverStripe\ORM\DataList;
use TractorCow\Fluent\Model\Locale;

/**
 * Class \Firesphere\SolrFluent\Extensions\FluentSchemaExtension
 *
 * Update the schema with the appropriate locale fields
 *
 * @package Firesphere\SolrFluent\Extensions
 * @property SchemaFactory|FluentSchemaExtension $owner
 */
class FluentSchemaExtension extends Extension
{
    /**
     * Add the locale fields
     *
     * @param ArrayList|DataList $data ArrayList to which the copy should be pushed
     * @param array $item Item that's going to be altered per locale
     */
    public function onAfterFieldDefinition($data, $item): void
    {
        // A locale can be null, those need to be skipped
        $locales = Locale::get()->exclude(['Locale' => null]);

        foreach ($locales as $locale) {
            $copy = $item;
            $copy['Field'] = sprintf('%s_%s', $item['Field'], $locale->Locale);
            $data->push($copy);
        }
    }
}


1		<?php
2		/**
3		* Class FluentSchemaExtension\|Firesphere\SolrFluent\Extensions\FluentSchemaExtension Add Fluent schema requirements
4		*
5		* @package Firesphere\SolrFluent\Extensions
6		* @author Simon `Firesphere` Erkelens; Marco `Sheepy` Hermo
7		* @copyright Copyright (c) 2018 - now() Firesphere & Sheepy
8		*/
9
10		namespace Firesphere\SolrFluent\Extensions;
11
12		use Firesphere\SolrSearch\Factories\SchemaFactory;
		0 ignored issues – show Bug introduced 2020-01-11 22:29 UTC by Report Bug Copy Issue Report The type `Firesphere\SolrSearch\Factories\SchemaFactory` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
13		use SilverStripe\Core\Extension;
14		use SilverStripe\ORM\ArrayList;
15		use SilverStripe\ORM\DataList;
16		use TractorCow\Fluent\Model\Locale;
17
18		/**
19		* Class \Firesphere\SolrFluent\Extensions\FluentSchemaExtension
20		*
21		* Update the schema with the appropriate locale fields
22		*
23		* @package Firesphere\SolrFluent\Extensions
24		* @property SchemaFactory\|FluentSchemaExtension $owner
25		*/
26		class FluentSchemaExtension extends Extension
27		{
28		/**
29		* Add the locale fields
30		*
31		* @param ArrayList\|DataList $data ArrayList to which the copy should be pushed
32		* @param array $item Item that's going to be altered per locale
33		*/
34	1	public function onAfterFieldDefinition($data, $item): void
35		{
36		// A locale can be null, those need to be skipped
37	1	$locales = Locale::get()->exclude(['Locale' => null]);
38
39	1	foreach ($locales as $locale) {
40	1	$copy = $item;
41	1	$copy['Field'] = sprintf('%s_%s', $item['Field'], $locale->Locale);
42	1	$data->push($copy);
43		}
44	1	}
45		}
46

Firesphere / silverstripe-fluent-solr

Push — master ( 580f23...f2132c )

FluentSchemaExtension::onAfterFieldDefinition() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like