Firesphere / silverstripe-bootstrapmfa

src/Providers/BootstrapMFAProvider.php

<?php

namespace Firesphere\BootstrapMFA\Providers;

use Firesphere\BootstrapMFA\Extensions\MemberExtension;
use Firesphere\BootstrapMFA\Models\BackupCode;
use SilverStripe\Control\Controller;
use SilverStripe\ORM\DataList;
use SilverStripe\ORM\ValidationException;
use SilverStripe\Security\Member;

class BootstrapMFAProvider
{
    protected $member;

    /**
     * @param null|string $token If it's a specific token to be fetched
     * @return DataList|BackupCode[]
     */
    public function fetchToken($token = null)

The parameter $token is not used and could be removed.

    {
        $member = $this->getMember();

        return BackupCode::getTokensForMember($member);

It seems like $member can also be of type Firesphere\BootstrapMFA\Extensions\MemberExtension; however, parameter $member of Firesphere\BootstrapMFA\Models\BackupCode::getTokensForMember() does only seem to accept SilverStripe\Security\Member, maybe add an additional type check?

    }

    /**
     * @return Member|MemberExtension|null
     */
    public function getMember()
    {
        return $this->member;
    }

    /**
     * @param Member $member
     */
    public function setMember($member)
    {
        $this->member = $member;
    }

    /**
     * @throws ValidationException
     */
    public function updateTokens()
    {
        // Clear any possible tokens in the session, just to be sure
        Controller::curr()->getRequest()->getSession()->clear('tokens');

        if ($member = $this->getMember()) {
            /** @var DataList|BackupCode[] $expiredCodes */
            $expiredCodes = BackupCode::get()->filter(['MemberID' => $member->ID]);

The property ID does not seem to exist on Firesphere\BootstrapMFA\Extensions\MemberExtension.

            $expiredCodes->removeAll();

            BackupCode::generateTokensForMember($member);

It seems like $member can also be of type Firesphere\BootstrapMFA\Extensions\MemberExtension; however, parameter $member of Firesphere\BootstrapMFA\Models\BackupCode::generateTokensForMember() does only seem to accept SilverStripe\Security\Member, maybe add an additional type check?

        }
        // Fail silently
    }
}