Firesphere\BootstrapMFA\Extensions\MemberExtension

Complexity

Total Complexity

12

Size/Duplication

Total Lines	101
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	onBeforeWrite()	0	5	3
A	updateCMSFields()	0	26	2
A	getBackupcodes()	0	3	1
A	onAfterWrite()	0	7	2
A	isInGracePeriod()	0	16	4

<?php

namespace Firesphere\BootstrapMFA\Extensions;

use Firesphere\BootstrapMFA\Models\BackupCode;
use Firesphere\BootstrapMFA\Providers\BootstrapMFAProvider;
use SilverStripe\Control\Controller;
use SilverStripe\Core\Config\Configurable;
use SilverStripe\Core\Injector\Injector;
use SilverStripe\Forms\CheckboxField;
use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\LiteralField;
use SilverStripe\Forms\Tab;
use SilverStripe\ORM\DataExtension;
use SilverStripe\ORM\DataList;
use SilverStripe\SiteConfig\SiteConfig;

/**
 * Class MemberExtension
 *
 * @package Firesphere\BootstrapMFA
 * @property Member|MemberExtension $owner
 * @property boolean $MFAEnabled
 * @method DataList|BackupCode[] BackupCodes()
 */
class MemberExtension extends DataExtension
{
    use Configurable;

    /**
     * @var array
     */
    private static $db = [

The private property $db is not used, and could be removed.

        'MFAEnabled' => 'Boolean(false)',
    ];

    /**
     * @var array
     */
    private static $has_many = [

The private property $has_many is not used, and could be removed.

        'BackupCodes' => BackupCode::class
    ];

    /**
     * @var bool
     */
    protected $updateMFA = false;

    /**
     * @param FieldList $fields
     */
    public function updateCMSFields(FieldList $fields)
    {
        $this->updateMFA = 0;

The property $updateMFA was declared of type boolean, but 0 is of type integer. Maybe add a type cast?

        $fields->removeByName(['BackupCodes']);
        $session = Controller::curr()->getRequest()->getSession();
        $rootTabSet = $fields->fieldByName("Root");
        $field = LiteralField::create('tokens', $session->get('tokens'));
        $tab = Tab::create(
            'MFA',
            _t(self::class . '.MFATAB', 'Multi Factor Authentication')
        );
        $rootTabSet->push(
            $tab
        );
        $fields->addFieldToTab(
            'Root.MFA',
            $enabled = CheckboxField::create('MFAEnabled', _t(self::class . '.MFAEnabled', 'MFA Enabled'))
        );
        $fields->addFieldToTab(
            'Root.MFA',
            CheckboxField::create('updateMFA', _t(self::class . '.RESETMFA', 'Reset MFA codes'))
        );

        if ($session->get('tokens')) {
            $fields->addFieldToTab('Root.MFA', $field);
            $session->clear('tokens');
        }
    }

    /**
     *
     */
    public function onBeforeWrite()
    {
        if (!$this->owner->MFAEnabled && SiteConfig::current_site_config()->ForceMFA) {
            $this->owner->MFAEnabled = true;
            $this->owner->updateMFA = true;
        }
    }

    /**
     *
     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function onAfterWrite()
    {
        parent::onAfterWrite();
        if ($this->owner->updateMFA) {
            $provider = Injector::inst()->get(BootstrapMFAProvider::class);
            $provider->setMember($this->owner);
            $provider->updateTokens();
        }
    }

    public function getBackupcodes()
    {
        return $this->owner->BackupCodes();
    }

    public function isInGracePeriod()
    {
        $member = $this->owner;

        // If MFA is enabled on the member, we're always using it
        if ($member->MFAEnabled) {
            return false;
        }

        $config = SiteConfig::current_site_config();
        // If MFA is not enforced, we're in an endless grace period
        if (!$config->ForceMFA) {
            return true;
        }

        $graceStartDay = ($member->Created > $config->ForceMFA) ? $member->Created : $config->ForceMFA;

The property Created does not exist on Firesphere\BootstrapMFA\Extensions\MemberExtension. Did you maybe forget to declare it?

The assignment to $graceStartDay is dead and can be removed.

    }
}