BootstrapMFAProvider::updateTokens() - Code Metrics - Inspection of "Grace period implementation" - Firesphere/silverstripe-bootstrapmfa - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#22)

by Simon

created 2018-10-23 21:18 UTC

BootstrapMFAProvider::updateTokens() A

↳ Parent: BootstrapMFAProvider

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	5
nc	2
nop	0
dl	0
loc	11
rs	10
c	0
b	0
f	0

<?php

namespace Firesphere\BootstrapMFA\Providers;

use Firesphere\BootstrapMFA\Models\BackupCode;
use SilverStripe\Control\Controller;
use SilverStripe\ORM\DataList;
use SilverStripe\ORM\ValidationException;
use SilverStripe\Security\Member;

class BootstrapMFAProvider
{
    protected $member;

    /**
     * @param string $token
     * @return null|BackupCode
     */
    public function fetchToken($token)
    {
        $member = $this->getMember();

        /** @var BackupCode $backupCode */
        $backupCode = BackupCode::getValidTokensForMember($member)
            ->filter(['Code' => $token])
            ->first();

        return $backupCode;
    }

    /**
     * @return Member|null
     */
    public function getMember()
    {
        return $this->member;
    }

    /**
     * @param Member $member
     */
    public function setMember($member)
    {
        $this->member = $member;
    }

    /**
     * @throws ValidationException
     */
    public function updateTokens()
    {
        // Clear any possible tokens in the session, just to be sure
        Controller::curr()->getRequest()->getSession()->clear('tokens');

        if ($member = $this->getMember()) {
            /** @var DataList|BackupCode[] $expiredCodes */
            $expiredCodes = BackupCode::get()->filter(['MemberID' => $member->ID]);
            $expiredCodes->removeAll();

            BackupCode::generateTokensForMember($member);
        }
        // Fail silently
    }

}


1			<?php
2
3			namespace Firesphere\BootstrapMFA\Providers;
4
5			use Firesphere\BootstrapMFA\Models\BackupCode;
6			use SilverStripe\Control\Controller;
7			use SilverStripe\ORM\DataList;
8			use SilverStripe\ORM\ValidationException;
9			use SilverStripe\Security\Member;
10
11			class BootstrapMFAProvider
12			{
13			protected $member;
14
15			/**
16			* @param string $token
17			* @return null\|BackupCode
18			*/
19			public function fetchToken($token)
20			{
21			$member = $this->getMember();
22
23			/** @var BackupCode $backupCode */
24			$backupCode = BackupCode::getValidTokensForMember($member)
25			->filter(['Code' => $token])
26			->first();
27
28			return $backupCode;
29			}
30
31			/**
32			* @return Member\|null
33			*/
34			public function getMember()
35			{
36			return $this->member;
37			}
38
39			/**
40			* @param Member $member
41			*/
42			public function setMember($member)
43			{
44			$this->member = $member;
45			}
46
47			/**
48			* @throws ValidationException
49			*/
50			public function updateTokens()
51			{
52			// Clear any possible tokens in the session, just to be sure
53			Controller::curr()->getRequest()->getSession()->clear('tokens');
54
55			if ($member = $this->getMember()) {
56			/** @var DataList\|BackupCode[] $expiredCodes */
57			$expiredCodes = BackupCode::get()->filter(['MemberID' => $member->ID]);
58			$expiredCodes->removeAll();
59
60			BackupCode::generateTokensForMember($member);
61			}
62			// Fail silently
63			}
64
65			}
66

Firesphere / silverstripe-bootstrapmfa

Pull Request — master (#22)

BootstrapMFAProvider::updateTokens() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like