src/__tests__/enhancer-creator.js - Code Metrics - Inspection of "Merge branch 'master' of github.com:Financial-Time..." - Financial-Times/n-express-enhancer - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 6a7f4c...05e4eb )

by Zhenyu

created 2018-04-30 16:17 UTC

src/tests/enhancer-creator.js A

↳ Parent: Project

Complexity

Total Complexity	26
Complexity/F	1

Size

Lines of Code	89
Function Count	26

Duplication

Duplicated Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	0
wmc	26
c	1
b	0
f	1
nc	1
mnd	0
bc	15
fnc	26
dl	0
loc	89
rs	10
bpm	0.5769
cpm	1
noi	3

1 Function

Rating	Name	Duplication	Size	Complexity
B	enhancer-creator.js ➔ ???	0	87	1

import createEnhancer from '../enhancer-creator';

describe('createEnhancer can create enhancer', () => {
	describe('when input function', () => {
		it('output enhanced function with original name', () => {
			const orignal = () => {};
			const enhancement = input => () => input();
			const enhancer = createEnhancer(enhancement);
			const enhanced = enhancer(orignal);
			expect(enhanced.name).toBe('orignal');
		});

		it('output enhanced function invoking enhancement function and orignal function', () => {
			const enhancementSideEffect = jest.fn();

			const orignal = jest.fn();
			const enhancer = createEnhancer(input => () => {
				enhancementSideEffect();
				return input();
			});
			const enhanced = enhancer(orignal);
			enhanced();
			expect(orignal.mock.calls).toHaveLength(1);
			expect(enhancementSideEffect.mock.calls).toHaveLength(1);
		});
	});

	describe('when input function bundle', () => {
		it('output function bundle of functions name as method names', () => {
			const functionBundle = {
				methodA: () => {},
				methodB: () => {},
			};
			const enhancer = createEnhancer(input => () => input());
			const enhanced = enhancer(functionBundle);
			expect(enhanced.methodA.name).toBe('methodA');
			expect(enhanced.methodB.name).toBe('methodB');
		});

		it('update function names in the original bundle methods, so that they can be consistent in enhancement function', () => {
			const enhancementSideEffect = jest.fn();

			const functionBundle = {
				methodA: jest.fn(),
				methodB: jest.fn(),
			};
			const enhancer = createEnhancer(inputFunction => () => {
				enhancementSideEffect(inputFunction.name);
				return inputFunction();
			});
			const enhanced = enhancer(functionBundle);
			enhanced.methodA();
			expect(enhancementSideEffect.mock.calls).toMatchSnapshot();
			enhanced.methodB();
			expect(enhancementSideEffect.mock.calls).toMatchSnapshot();
		});

		it('output function bundle of functions invoking enhancement function and origial functions', () => {
			const enhancementSideEffect = jest.fn();

			const methodA = jest.fn();
			const methodB = jest.fn();
			const functionBundle = {
				methodA,
				methodB,
			};
			const enhancer = createEnhancer(input => () => {
				enhancementSideEffect();
				return input();
			});
			const enhanced = enhancer(functionBundle);
			enhanced.methodA();
			expect(methodA.mock.calls).toHaveLength(1);
			expect(enhancementSideEffect.mock.calls).toHaveLength(1);
			enhanced.methodB();
			expect(methodB.mock.calls).toHaveLength(1);
			expect(enhancementSideEffect.mock.calls).toHaveLength(2);
		});
	});

	it('when input is invalid throws error', () => {
		const enhancer = createEnhancer(input => () => input());
		const doEnhanceStringInput = () => enhancer('test');
		expect(doEnhanceStringInput).toThrowErrorMatchingSnapshot();

		const doEnhanceInvalidObject = () =>
			enhancer({
				foo: 'bar',
			});
		expect(doEnhanceInvalidObject).toThrowErrorMatchingSnapshot();
	});
});


1			import createEnhancer from '../enhancer-creator';
2
3			describe('createEnhancer can create enhancer', () => {
4			describe('when input function', () => {
5			it('output enhanced function with original name', () => {
6			const orignal = () => {};
7			const enhancement = input => () => input();
8			const enhancer = createEnhancer(enhancement);
9			const enhanced = enhancer(orignal);
10			expect(enhanced.name).toBe('orignal');
11			});
12
13			it('output enhanced function invoking enhancement function and orignal function', () => {
14			const enhancementSideEffect = jest.fn();
			0 ignored issues – show Bug introduced 2018-04-26 14:01 UTC by Report Bug Copy Issue Report The variable `jest` seems to be never declared. If this is a global, consider adding a `/** global: jest */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
15			const orignal = jest.fn();
16			const enhancer = createEnhancer(input => () => {
17			enhancementSideEffect();
18			return input();
19			});
20			const enhanced = enhancer(orignal);
21			enhanced();
22			expect(orignal.mock.calls).toHaveLength(1);
23			expect(enhancementSideEffect.mock.calls).toHaveLength(1);
24			});
25			});
26
27			describe('when input function bundle', () => {
28			it('output function bundle of functions name as method names', () => {
29			const functionBundle = {
30			methodA: () => {},
31			methodB: () => {},
32			};
33			const enhancer = createEnhancer(input => () => input());
34			const enhanced = enhancer(functionBundle);
35			expect(enhanced.methodA.name).toBe('methodA');
36			expect(enhanced.methodB.name).toBe('methodB');
37			});
38
39			it('update function names in the original bundle methods, so that they can be consistent in enhancement function', () => {
40			const enhancementSideEffect = jest.fn();
			0 ignored issues – show Bug introduced 2018-04-26 14:01 UTC by Report Bug Copy Issue Report The variable `jest` seems to be never declared. If this is a global, consider adding a `/** global: jest */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
41			const functionBundle = {
42			methodA: jest.fn(),
43			methodB: jest.fn(),
44			};
45			const enhancer = createEnhancer(inputFunction => () => {
46			enhancementSideEffect(inputFunction.name);
47			return inputFunction();
48			});
49			const enhanced = enhancer(functionBundle);
50			enhanced.methodA();
51			expect(enhancementSideEffect.mock.calls).toMatchSnapshot();
52			enhanced.methodB();
53			expect(enhancementSideEffect.mock.calls).toMatchSnapshot();
54			});
55
56			it('output function bundle of functions invoking enhancement function and origial functions', () => {
57			const enhancementSideEffect = jest.fn();
			0 ignored issues – show Bug introduced 2018-04-30 16:24 UTC by Report Bug Copy Issue Report The variable `jest` seems to be never declared. If this is a global, consider adding a `/** global: jest */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
58			const methodA = jest.fn();
59			const methodB = jest.fn();
60			const functionBundle = {
61			methodA,
62			methodB,
63			};
64			const enhancer = createEnhancer(input => () => {
65			enhancementSideEffect();
66			return input();
67			});
68			const enhanced = enhancer(functionBundle);
69			enhanced.methodA();
70			expect(methodA.mock.calls).toHaveLength(1);
71			expect(enhancementSideEffect.mock.calls).toHaveLength(1);
72			enhanced.methodB();
73			expect(methodB.mock.calls).toHaveLength(1);
74			expect(enhancementSideEffect.mock.calls).toHaveLength(2);
75			});
76			});
77
78			it('when input is invalid throws error', () => {
79			const enhancer = createEnhancer(input => () => input());
80			const doEnhanceStringInput = () => enhancer('test');
81			expect(doEnhanceStringInput).toThrowErrorMatchingSnapshot();
82
83			const doEnhanceInvalidObject = () =>
84			enhancer({
85			foo: 'bar',
86			});
87			expect(doEnhanceInvalidObject).toThrowErrorMatchingSnapshot();
88			});
89			});
90

Financial-Times / n-express-enhancer

Push — master ( 6a7f4c...05e4eb )

src/__tests__/enhancer-creator.js A

Complexity

Size

Duplication

Importance

1 Function

Duplication Side-by-Side

Filter issues like

src/tests/enhancer-creator.js A