Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
7 | View Code Duplication | trait TSetter |
|
8 | { |
||
9 | /** |
||
10 | * Allow setting fooBar setter with setFooBar(). |
||
11 | * |
||
12 | * @access public |
||
13 | * |
||
14 | * @param string $attribute |
||
15 | * @param mixed $value |
||
16 | */ |
||
17 | public function __set( $attribute, $value ) |
||
25 | } |
||
26 |
Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a
@return
annotation as described here.