Larrock\Core\Traits\AdminMethodsShow::show()

Complexity

Conditions	1
Paths	1

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	0

<?php
    public function show($id)
    {
        $data['app_category'] = LarrockCategory::getConfig();

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

        $cache_key = sha1('AdminMethodsShowCategory'.$id.$this->config->getModelName());
        $data['category'] = Cache::rememberForever($cache_key, function () use ($id) {
            return LarrockCategory::getModel()->whereId($id)->with(['getChild', 'getParent'])->firstOrFail();
        });
        $cache_key = sha1('AdminMethodsShowData'.$id.$this->config->getModelName());
        $data['data'] = Cache::rememberForever($cache_key, function () use ($id) {
            return $this->config->getModel()->whereHas('getCategory', function ($q) use ($id) {
                $q->where('category.id', '=', $id);
            })->get();
        });

        return view('larrock::admin.admin-builder.categories', $data);

The expression return view('larrock::admin.admin-builder.categories', $data) returns the type array<string,mixed> which is incompatible with the documented return type View.

The call to view() has too many arguments starting with $data.

    }