CrawlController::setupCrawler() - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/Famdir..." - Famdirksen/LaravelJobHandler - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( aa84bd...826843 )

by Robin

created 2018-08-07 07:26 UTC

CrawlController::setupCrawler() B

↳ Parent: CrawlController

Complexity

Conditions	10
Paths	8

Size

Total Lines	42
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	21
dl	0
loc	42
c	0
b	0
f	0
rs	7.6666
cc	10
nc	8
nop	1

How to fix Complexity

<?php

namespace Famdirksen\LaravelJobHandler\Http\Controllers;

use Famdirksen\LaravelJobHandler\Models\Crawlers;
use Famdirksen\LaravelJobHandler\Models\CrawlerStatus;
use Famdirksen\LaravelJobHandler\Models\CrawlerStatusLogs;

class CrawlController
{
    protected $crawler;
    protected $crawler_id;


    /**
     * Get the latest crawler data from the database
     */
    protected function getCrawler()
    {
        $this->crawler = Crawlers::findOrFail($this->crawler_id);
    }

    /**
     * Setup the crawler so it won't run twice at the same time
     *
     * @param $crawler_id
     */
    public function setupCrawler($crawler_id)
    {
        $this->crawler_id = $crawler_id;
        $times = config('laravel-job-handler.run_times', 10);

        for ($x = 0; $x <= $times; $x++) {
            //fetch the last data
            $this->getCrawler();

            if (!$this->crawler->enabled) {
                throw new \Exception('Crawler (#'.$this->crawler_id.') - crawler isnt enabled in database');
            }
            if ($this->crawler->latest_status == 4) {

                throw new \Exception('Crawler (#'.$this->crawler_id.') - last run had an error and the developer needs to reenable this crawler');
            }
            if ($this->crawler->latest_status == 3) {
                throw new \Exception('Crawler (#'.$this->crawler_id.') - last run had an error');
            }
            if ($this->crawler->latest_status == 2) {
                //Done running...
                break;
            }

            if (is_null($this->crawler->latest_status)) {
                //first time it runs...
                break;
            }

            if ($x == $times) {
                $this->failCrawler('Crawler (#'.$this->crawler_id.') - max execution time');
            }

            if ($this->crawler->status == 1) {

                if ($this->crawler->multiple) {

                    break;
                }

                sleep(config('laravel-job-handler.retry_in_seconds', 3)); //retry in 3 seconds
            }
        }

        $this->startCrawler();
    }
    /**
     * Start the crawler and save it to the database
     *
     * @param string $output
     */
    public function startCrawler($output = '')
    {
        return $this->addStatus(1, $output); //start running
    }
    /**
     * set the crawler as done so other scripts can run
     *
     * @param string $output
     */
    public function doneCrawler($output = '')
    {
        return $this->addStatus(2, $output); //done running
    }
    public function finish($output = '') {
        return $this->doneCrawler($output);
    }
    /**
     * crawler failed...
     *
     * @param string $output
     */
    public function failCrawler($output = '')
    {
        $this->addStatus(3, $output); //failed

        throw new \Exception($output.' - status 3');
    }
    /**
     * save the latest crawler status to the database
     *
     * @param $status
     * @param string $output
     * @return bool
     */
    protected function addStatus($status, $output = '')
    {
        $crawlerstatus = new CrawlerStatus();

        $crawlerstatus->crawler_id = $this->crawler_id;
        $crawlerstatus->status = $status;

        if ($crawlerstatus->save()) {
            $this->crawler->latest_status = $status;

            $this->crawler->save();

            if (!empty($output)) {
                $crawlerstatuslog = new CrawlerStatusLogs();

                $crawlerstatuslog->status_id = $crawlerstatus->id;

                $crawlerstatuslog->output = $output;


                $crawlerstatuslog->save();
            }

            return true;
        } else {
            throw new \Exception('Cannot save crawlerstatus to database...');
        }
    }
}


1			<?php
2
3			namespace Famdirksen\LaravelJobHandler\Http\Controllers;
4
5			use Famdirksen\LaravelJobHandler\Models\Crawlers;
6			use Famdirksen\LaravelJobHandler\Models\CrawlerStatus;
7			use Famdirksen\LaravelJobHandler\Models\CrawlerStatusLogs;
8
9			class CrawlController
10			{
11			protected $crawler;
12			protected $crawler_id;
13
14
15			/**
16			* Get the latest crawler data from the database
17			*/
18			protected function getCrawler()
19			{
20			$this->crawler = Crawlers::findOrFail($this->crawler_id);
21			}
22
23			/**
24			* Setup the crawler so it won't run twice at the same time
25			*
26			* @param $crawler_id
27			*/
28			public function setupCrawler($crawler_id)
29			{
30			$this->crawler_id = $crawler_id;
31			$times = config('laravel-job-handler.run_times', 10);
32
33			for ($x = 0; $x <= $times; $x++) {
34			//fetch the last data
35			$this->getCrawler();
36
37			if (!$this->crawler->enabled) {
38			throw new \Exception('Crawler (#'.$this->crawler_id.') - crawler isnt enabled in database');
39			}
40			if ($this->crawler->latest_status == 4) {
			0 ignored issues – show Bug introduced 2018-08-07 07:20 UTC by Report Bug Copy Issue Report The property `latest_status` does not seem to exist on `Famdirksen\LaravelJobHandler\Models\Crawlers`. Are you sure there is no database migration missing? Checks if undeclared accessed properties appear in database migrations and if the creating migration is correct. Loading history...
41			throw new \Exception('Crawler (#'.$this->crawler_id.') - last run had an error and the developer needs to reenable this crawler');
42			}
43			if ($this->crawler->latest_status == 3) {
44			throw new \Exception('Crawler (#'.$this->crawler_id.') - last run had an error');
45			}
46			if ($this->crawler->latest_status == 2) {
47			//Done running...
48			break;
49			}
50
51			if (is_null($this->crawler->latest_status)) {
52			//first time it runs...
53			break;
54			}
55
56			if ($x == $times) {
57			$this->failCrawler('Crawler (#'.$this->crawler_id.') - max execution time');
58			}
59
60			if ($this->crawler->status == 1) {
			0 ignored issues – show Bug introduced 2018-08-07 07:20 UTC by Report Bug Copy Issue Report The property `status` does not seem to exist on `Famdirksen\LaravelJobHandler\Models\Crawlers`. Are you sure there is no database migration missing? Checks if undeclared accessed properties appear in database migrations and if the creating migration is correct. Loading history...
61			if ($this->crawler->multiple) {
			0 ignored issues – show Bug introduced 2018-08-07 07:20 UTC by Report Bug Copy Issue Report The property `multiple` does not seem to exist on `Famdirksen\LaravelJobHandler\Models\Crawlers`. Are you sure there is no database migration missing? Checks if undeclared accessed properties appear in database migrations and if the creating migration is correct. Loading history...
62			break;
63			}
64
65			sleep(config('laravel-job-handler.retry_in_seconds', 3)); //retry in 3 seconds
66			}
67			}
68
69			$this->startCrawler();
70			}
71			/**
72			* Start the crawler and save it to the database
73			*
74			* @param string $output
75			*/
76			public function startCrawler($output = '')
77			{
78			return $this->addStatus(1, $output); //start running
79			}
80			/**
81			* set the crawler as done so other scripts can run
82			*
83			* @param string $output
84			*/
85			public function doneCrawler($output = '')
86			{
87			return $this->addStatus(2, $output); //done running
88			}
89			public function finish($output = '') {
90			return $this->doneCrawler($output);
91			}
92			/**
93			* crawler failed...
94			*
95			* @param string $output
96			*/
97			public function failCrawler($output = '')
98			{
99			$this->addStatus(3, $output); //failed
100
101			throw new \Exception($output.' - status 3');
102			}
103			/**
104			* save the latest crawler status to the database
105			*
106			* @param $status
107			* @param string $output
108			* @return bool
109			*/
110			protected function addStatus($status, $output = '')
111			{
112			$crawlerstatus = new CrawlerStatus();
113
114			$crawlerstatus->crawler_id = $this->crawler_id;
115			$crawlerstatus->status = $status;
116
117			if ($crawlerstatus->save()) {
118			$this->crawler->latest_status = $status;
119
120			$this->crawler->save();
121
122			if (!empty($output)) {
123			$crawlerstatuslog = new CrawlerStatusLogs();
124
125			$crawlerstatuslog->status_id = $crawlerstatus->id;
			0 ignored issues – show Bug introduced 2018-08-07 07:20 UTC by Report Bug Copy Issue Report The property `status_id` does not seem to exist on `Famdirksen\LaravelJobHan...odels\CrawlerStatusLogs`. Are you sure there is no database migration missing? Checks if undeclared accessed properties appear in database migrations and if the creating migration is correct. Loading history...
126			$crawlerstatuslog->output = $output;
			0 ignored issues – show Bug introduced 2018-08-07 07:20 UTC by Report Bug Copy Issue Report The property `output` does not seem to exist on `Famdirksen\LaravelJobHan...odels\CrawlerStatusLogs`. Are you sure there is no database migration missing? Checks if undeclared accessed properties appear in database migrations and if the creating migration is correct. Loading history...
127
128			$crawlerstatuslog->save();
129			}
130
131			return true;
132			} else {
133			throw new \Exception('Cannot save crawlerstatus to database...');
134			}
135			}
136			}
137

Famdirksen / LaravelJobHandler

Push — master ( aa84bd...826843 )

CrawlController::setupCrawler() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like