Staff - Code Metrics - Inspection of "fix staff" - FLAIRUK/good-till-system - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b7f699...e9d2a5 )

by Phil™

created 2020-06-22 16:02 UTC

Staff A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

Metric	Value
wmc	6
lcom	0
cbo	2
dl	0
loc	61
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Size	Complexity
A	__construct()	3	1
A	setURL()	3	2
A	setID()	4	1
A	setOutlet()	4	1
A	setName()	5	1

<?php

namespace FLAIRUK\GoodTillSystem\Models;

use FLAIRUK\GoodTillSystem\API;
use Illuminate\Support\Facades\Config;

class Staff extends API {

    /**
     * The url attribute.
     *
     * @var string
     */
    protected $url = 'staffs';

    const STAFF = 'staffs';

    /**
     * Create a new Good Till Product instance.
     *
     * @param array $user
     * @return void

     */
    public function __construct(array $user) {
        parent::__construct($user, $this->url);
    }

    public function setURL($url = null): void {
        $this->url = $url ? $url : Config::get('goodtill.routes.api') . self::STAFF;
    }

    
    /**
     * Product Set Outlet ID
     * 
     * @param $id
     * @return object
     */
    public function setID($id): object {
        $this->id = $id;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        return $this;
    }

    /**
     * Product Set Outlet ID
     * 
     * @param $id
     * @return object
     */
    public function setOutlet($id): object {
        $this->outlet_id = ['outlet_id' => $id];
class MyClass { }

$x = new MyClass();
$x->foo = true;
        return $this;
    }

   /**
     * Product Set Outlet ID
     * 
     * @param $id
     * @return object
     */
    public function setName($name): object {
        $this->product_name = ['product_name' => $name];
class MyClass { }

$x = new MyClass();
$x->foo = true;
        // $this->product_name = array_merge($this->payload, ['product_name' => $name ]);
        return $this;
    }

}

1			<?php
2
3			namespace FLAIRUK\GoodTillSystem\Models;
4
5			use FLAIRUK\GoodTillSystem\API;
6			use Illuminate\Support\Facades\Config;
7
8			class Staff extends API {
9
10			/**
11			* The url attribute.
12			*
13			* @var string
14			*/
15			protected $url = 'staffs';
16
17			const STAFF = 'staffs';
18
19			/**
20			* Create a new Good Till Product instance.
21			*
22			* @param array $user
23			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2020-06-22 16:03 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
24			*/
25			public function __construct(array $user) {
26			parent::__construct($user, $this->url);
27			}
28
29			public function setURL($url = null): void {
30			$this->url = $url ? $url : Config::get('goodtill.routes.api') . self::STAFF;
31			}
32
33
34			/**
35			* Product Set Outlet ID
36			*
37			* @param $id
38			* @return object
39			*/
40			public function setID($id): object {
41			$this->id = $id;
			0 ignored issues – show Bug introduced 2020-06-22 16:03 UTC by Report Bug Copy Issue Report The property `id` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
42			return $this;
43			}
44
45			/**
46			* Product Set Outlet ID
47			*
48			* @param $id
49			* @return object
50			*/
51			public function setOutlet($id): object {
52			$this->outlet_id = ['outlet_id' => $id];
			0 ignored issues – show Bug introduced 2020-06-22 16:03 UTC by Report Bug Copy Issue Report The property `outlet_id` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
53			return $this;
54			}
55
56			/**
57			* Product Set Outlet ID
58			*
59			* @param $id
60			* @return object
61			*/
62			public function setName($name): object {
63			$this->product_name = ['product_name' => $name];
			0 ignored issues – show Bug introduced 2020-06-22 16:03 UTC by Report Bug Copy Issue Report The property `product_name` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
64			// $this->product_name = array_merge($this->payload, ['product_name' => $name ]);
65			return $this;
66			}
67
68			}

FLAIRUK / good-till-system

Push — master ( b7f699...e9d2a5 )

Staff A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Duplication Side-by-Side

Filter issues like