Loyalty::setURL() - Code Metrics - FLAIRUK/good-till-system - Measure and Improve Code Quality continuously with Scrutinizer

Loyalty::setURL() A
last analyzed 2020-06-23 15:39 UTC

↳ Parent: Loyalty

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	3
Ratio	100 %

Importance

Changes

Metric	Value
dl	3
loc	3
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace FLAIRUK\GoodTillSystem\Models;

use FLAIRUK\GoodTillSystem\API;
use Illuminate\Support\Facades\Config;

class Loyalty extends API {


    protected $url;

    const LOYALTY = 'reward_rules';

    /**
     * Create a new GoodTill instance.
     *
     * @return void

     */
    public function __construct($user)
    {
        parent::__construct($user, $this->url);
    }

    public function setURL(): void {
        $this->url = Config::get('goodtill.routes.api') . self::LOYALTY . '/';
    }
    
    /**
     * Set Product Outlet ID
     * 
     * @param string $id
     * @return object
     */
    public function setID(string $id): object {
        $this->id = $id;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        return $this;
    }
}


1		<?php
2
3		namespace FLAIRUK\GoodTillSystem\Models;
4
5		use FLAIRUK\GoodTillSystem\API;
6		use Illuminate\Support\Facades\Config;
7
8	View Code Duplication	class Loyalty extends API {
		0 ignored issues – show Duplication introduced 2020-06-19 11:18 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
9
10		protected $url;
11
12		const LOYALTY = 'reward_rules';
13
14		/**
15		* Create a new GoodTill instance.
16		*
17		* @return void
		0 ignored issues – show Comprehensibility Best Practice introduced 2020-06-19 11:18 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
18		*/
19		public function __construct($user)
20		{
21		parent::__construct($user, $this->url);
22		}
23
24		public function setURL(): void {
25		$this->url = Config::get('goodtill.routes.api') . self::LOYALTY . '/';
26		}
27
28		/**
29		* Set Product Outlet ID
30		*
31		* @param string $id
32		* @return object
33		*/
34		public function setID(string $id): object {
35		$this->id = $id;
		0 ignored issues – show Bug introduced 2020-06-19 11:18 UTC by Report Bug Copy Issue Report The property `id` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
36		return $this;
37		}
38		}
39

FLAIRUK / good-till-system

Loyalty::setURL() A last analyzed 2020-06-23 15:39 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Loyalty::setURL() A
last analyzed 2020-06-23 15:39 UTC