Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | View Code Duplication | class Customer extends API { |
|
|
|||
9 | |||
10 | /** |
||
11 | * The url attribute. |
||
12 | * |
||
13 | * @var |
||
14 | */ |
||
15 | protected $id; |
||
16 | |||
17 | /** |
||
18 | * Create a new Good Till Customer instance. |
||
19 | * |
||
20 | * @param array $user |
||
21 | * @return void |
||
22 | * |
||
23 | * @source https://apidoc.thegoodtill.com/#api-Outlet |
||
24 | */ |
||
25 | public function __construct(array $user) { |
||
28 | |||
29 | /** |
||
30 | * Set Outlet URL |
||
31 | * |
||
32 | * @param string|null $id |
||
33 | * @return void |
||
34 | */ |
||
35 | public function setURL($id = null): void { |
||
43 | /** |
||
44 | * Set Product Outlet ID |
||
45 | * |
||
46 | * @param string $id |
||
47 | * @return object |
||
48 | */ |
||
49 | public function setID(string $id): object { |
||
53 | } |
||
54 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.