BaseGraphTest::setUpExtended() - Code Metrics - Inspection of "Issue #6: Convert to PHP 7.1 and PHPUnit 8." - FGM/grafizzi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#7)

by Frédéric G.

created 2019-02-16 11:55 UTC

BaseGraphTest::setUpExtended() A

↳ Parent: BaseGraphTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.9332
c	0
b	0
f	0
cc	1
nc	1
nop	2

<?php

/**
 * @file
 * Grafizzi\Graph\Tests\BaseGraphTest: a component of the Grafizzi library.
 *
 * (c) 2012 Frédéric G. MARAND <[email protected]>
 *
 * Grafizzi is free software: you can redistribute it and/or modify it under the
 * terms of the GNU Lesser General Public License as published by the Free
 * Software Foundation, either version 3 of the License, or (at your option) any
 * later version.
 *
 * Grafizzi is distributed in the hope that it will be useful, but WITHOUT ANY
 * WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
 * A PARTICULAR PURPOSE.  See the GNU Lesser General Public License for more
 * details.
 *
 * You should have received a copy of the GNU Lesser General Public License
 * along with Grafizzi, in the COPYING.LESSER.txt file.  If not, see
 * <http://www.gnu.org/licenses/>
 */


namespace Grafizzi\Graph\Tests;

require 'vendor/autoload.php';

use \Grafizzi\Graph\Graph;

use \Monolog\Logger;
use \Monolog\Handler\StreamHandler;

use PHPUnit\Framework\TestCase;
use Pimple\Container;

/**
 * Base test case.
 *
 * Build a graph that all other test cases will need.
 */
abstract class BaseGraphTest extends TestCase {

  /**
   *
   * @var Graph
   */
  public $Graph;

  /**
   * @var \Pimple\Container
   */
  public $dic;

  /**
   * Prepares the environment before running a test.
   */
  protected function setUpExtended($name = 'G', $attributes = array()) {
    parent::setUp();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}

    $log = new Logger(basename(__FILE__, '.php'));
    $log->pushHandler(new StreamHandler('php://stderr', Logger::INFO));
    $this->dic = new Container(array(
      'logger' => $log,
    ));
    $this->Graph = new Graph($this->dic, $name, $attributes);
  }

  /**
   * Helper function for testBuild() method.
   *
   * @param string $expected
   *   A DOT source.
   * @param string $message
   *   The assertion message.
   */
  public function check($expected, $message) {
    $build = $this->Graph->build();
    $this->Graph->logger->debug("\n\n$build\n\n");
    $this->assertEquals($expected, $build, $message);
  }

  /**
   * Cleans up the environment after running a test.
   */
  protected function tearDown() : void {
    $this->Graph = null;
    parent::tearDown();
  }
}


1			<?php
2
3			/**
4			* @file
5			* Grafizzi\Graph\Tests\BaseGraphTest: a component of the Grafizzi library.
6			*
7			* (c) 2012 Frédéric G. MARAND <[email protected]>
8			*
9			* Grafizzi is free software: you can redistribute it and/or modify it under the
10			* terms of the GNU Lesser General Public License as published by the Free
11			* Software Foundation, either version 3 of the License, or (at your option) any
12			* later version.
13			*
14			* Grafizzi is distributed in the hope that it will be useful, but WITHOUT ANY
15			* WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
16			* A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more
17			* details.
18			*
19			* You should have received a copy of the GNU Lesser General Public License
20			* along with Grafizzi, in the COPYING.LESSER.txt file. If not, see
21			* <http://www.gnu.org/licenses/>
22			*/
23
24
25			namespace Grafizzi\Graph\Tests;
26
27			require 'vendor/autoload.php';
28
29			use \Grafizzi\Graph\Graph;
30
31			use \Monolog\Logger;
32			use \Monolog\Handler\StreamHandler;
33
34			use PHPUnit\Framework\TestCase;
35			use Pimple\Container;
36
37			/**
38			* Base test case.
39			*
40			* Build a graph that all other test cases will need.
41			*/
42			abstract class BaseGraphTest extends TestCase {
43
44			/**
45			*
46			* @var Graph
47			*/
48			public $Graph;
49
50			/**
51			* @var \Pimple\Container
52			*/
53			public $dic;
54
55			/**
56			* Prepares the environment before running a test.
57			*/
58			protected function setUpExtended($name = 'G', $attributes = array()) {
59			parent::setUp();
			0 ignored issues – show Comprehensibility Bug introduced 2019-02-16 11:34 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`setUp()` instead of `setUpExtended()`). Are you sure this is correct? If so, you might want to change this to `$this->setUp()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
60
61			$log = new Logger(basename(__FILE__, '.php'));
62			$log->pushHandler(new StreamHandler('php://stderr', Logger::INFO));
63			$this->dic = new Container(array(
64			'logger' => $log,
65			));
66			$this->Graph = new Graph($this->dic, $name, $attributes);
67			}
68
69			/**
70			* Helper function for testBuild() method.
71			*
72			* @param string $expected
73			* A DOT source.
74			* @param string $message
75			* The assertion message.
76			*/
77			public function check($expected, $message) {
78			$build = $this->Graph->build();
79			$this->Graph->logger->debug("\n\n$build\n\n");
80			$this->assertEquals($expected, $build, $message);
81			}
82
83			/**
84			* Cleans up the environment after running a test.
85			*/
86			protected function tearDown() : void {
87			$this->Graph = null;
88			parent::tearDown();
89			}
90			}
91

FGM / grafizzi

Pull Request — master (#7)

BaseGraphTest::setUpExtended() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like