| Conditions | 1 |
| Paths | 1 |
| Total Lines | 205 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 46 | public function setUp() : void { |
||
| 47 | // not strict by default. |
||
| 48 | parent::setUpExtended('asde91'); |
||
|
|
|||
| 49 | $g = $this->Graph; |
||
| 50 | $dic = $this->dic; |
||
| 51 | $g->setDirected(true); |
||
| 52 | $g->setAttribute(new Attribute($dic, 'ranksep', .75)); |
||
| 53 | |||
| 54 | $rankSame = new Attribute($dic, 'rank', 'same'); |
||
| 55 | $sgAttrs = array( |
||
| 56 | $rankSame, |
||
| 57 | new Attribute($dic, 'title', null), |
||
| 58 | ); |
||
| 59 | |||
| 60 | /* program types graph */ |
||
| 61 | $g->addChild($sgType = new Subgraph($dic, 'type', $sgAttrs)); |
||
| 62 | $sgType->addChild(new Node($dic, 'Software IS')); |
||
| 63 | $sgType->addChild(new Node($dic, 'Configuration Mgt')); |
||
| 64 | $sgType->addChild(new Node($dic, 'Architecture & Libraries')); |
||
| 65 | $sgType->addChild(new Node($dic, 'Process')); |
||
| 66 | |||
| 67 | /* time graphs */ |
||
| 68 | $g->addChild($sgPast = new Subgraph($dic, 'past', $sgAttrs)); |
||
| 69 | $g->addChild($sg1978 = new Subgraph($dic, 1978, $sgAttrs)); |
||
| 70 | $g->addChild($sg1980 = new Subgraph($dic, 1980, $sgAttrs)); |
||
| 71 | $g->addChild($sg1982 = new Subgraph($dic, 1982, $sgAttrs)); |
||
| 72 | $g->addChild($sg1983 = new Subgraph($dic, 1983, $sgAttrs)); |
||
| 73 | $g->addChild($sg1985 = new Subgraph($dic, 1985, $sgAttrs)); |
||
| 74 | $g->addChild($sg1986 = new Subgraph($dic, 1986, $sgAttrs)); |
||
| 75 | $g->addChild($sg1987 = new Subgraph($dic, 1987, $sgAttrs)); |
||
| 76 | $g->addChild($sg1988 = new Subgraph($dic, 1988, $sgAttrs)); |
||
| 77 | $g->addChild($sg1989 = new Subgraph($dic, 1989, $sgAttrs)); |
||
| 78 | $g->addChild($sg1990 = new Subgraph($dic, 1990, $sgAttrs)); |
||
| 79 | $g->addChild($sgFuture = new Subgraph($dic, 'future', $sgAttrs)); |
||
| 80 | |||
| 81 | /* programs */ |
||
| 82 | $sgPast->addChild($nBourneSh = new Node($dic, 'Bourne sh')); |
||
| 83 | $sgPast->addChild($nMake = new Node($dic, 'make')); |
||
| 84 | $sgPast->addChild($nSCCS = new Node($dic, 'SCCS')); |
||
| 85 | $sgPast->addChild($nYacc = new Node($dic, 'yacc')); |
||
| 86 | $sgPast->addChild($nCron = new Node($dic, 'cron')); |
||
| 87 | |||
| 88 | $sg1978->addChild($nReiserCpp = new Node($dic, 'Reiser cpp')); |
||
| 89 | $sg1978->addChild($nCshell = new Node($dic, 'Cshell')); |
||
| 90 | |||
| 91 | $sg1980->addChild($nEmacs = new Node($dic, 'emacs')); |
||
| 92 | $sg1980->addChild($nBuild = new Node($dic, 'build')); |
||
| 93 | $sg1980->addChild($nVi = new Node($dic, 'vi')); |
||
| 94 | |||
| 95 | $sg1982->addChild($nCurses = new Node($dic, '<curses>')); |
||
| 96 | $sg1982->addChild($nRCS = new Node($dic, 'RCS')); |
||
| 97 | $sg1982->addChild($nIMX = new Node($dic, 'IMX')); |
||
| 98 | $sg1982->addChild($nSYNED = new Node($dic, 'SYNED')); |
||
| 99 | |||
| 100 | $sg1983->addChild($nksh = new Node($dic, 'ksh')); |
||
| 101 | $sg1983->addChild($nIFS = new Node($dic, 'IFS')); |
||
| 102 | $sg1983->addChild($nTTU = new Node($dic, 'TTU')); |
||
| 103 | |||
| 104 | $sg1985->addChild($nNmake = new Node($dic, 'nmake')); |
||
| 105 | $sg1985->addChild($nPeggy = new Node($dic, 'Peggy')); |
||
| 106 | |||
| 107 | $sg1986->addChild($nNcpp = new Node($dic, 'ncpp')); |
||
| 108 | $sg1986->addChild($nKsh_i = new Node($dic, 'ksh-i')); |
||
| 109 | $sg1986->addChild($nCurses_i = new Node($dic, '<curses-i>')); |
||
| 110 | $sg1986->addChild($nPg2 = new Node($dic, 'PG2')); |
||
| 111 | $sg1986->addChild($nCasterisk = new Node($dic, 'C*')); |
||
| 112 | |||
| 113 | $sg1987->addChild($nAnsiCpp = new Node($dic, 'Ansi cpp')); |
||
| 114 | $sg1987->addChild($nNmake20 = new Node($dic, 'nmake 2.0')); |
||
| 115 | $sg1987->addChild($n3DFS = new Node($dic, '3D File System')); |
||
| 116 | $sg1987->addChild($nFdelta = new Node($dic, 'fdelta')); |
||
| 117 | $sg1987->addChild($nDAG = new Node($dic, 'DAG')); |
||
| 118 | $sg1987->addChild($nCSAS = new Node($dic, 'CSAS')); |
||
| 119 | |||
| 120 | $sg1988->addChild($nCia = new Node($dic, 'CIA')); |
||
| 121 | $sg1988->addChild($nSBCS = new Node($dic, 'SBCS')); |
||
| 122 | $sg1988->addChild($nKsh88 = new Node($dic, 'ksh-88')); |
||
| 123 | $sg1988->addChild($nPegasusPml = new Node($dic, 'PEGASUS/PML')); |
||
| 124 | $sg1988->addChild($nPAX = new Node($dic, 'PAX')); |
||
| 125 | $sg1988->addChild($nBacktalk = new Node($dic, 'backtalk')); |
||
| 126 | |||
| 127 | $sg1989->addChild($nCIApp = new Node($dic, 'CIA++')); |
||
| 128 | $sg1989->addChild($nAPP = new Node($dic, 'APP')); |
||
| 129 | $sg1989->addChild($nSHIP = new Node($dic, 'SHIP')); |
||
| 130 | $sg1989->addChild($nDataShare = new Node($dic, 'DataShare')); |
||
| 131 | $sg1989->addChild($nRyacc = new Node($dic, 'ryacc')); |
||
| 132 | $sg1989->addChild($nMosaic = new Node($dic, 'Mosaic')); |
||
| 133 | |||
| 134 | $sg1990->addChild($nLibft = new Node($dic, 'libft')); |
||
| 135 | $sg1990->addChild($nCoShell = new Node($dic, 'CoShell')); |
||
| 136 | $sg1990->addChild($nDIA = new Node($dic, 'DIA')); |
||
| 137 | $sg1990->addChild($nIFS_i = new Node($dic, 'IFS-i')); |
||
| 138 | $sg1990->addChild($nKyacc = new Node($dic, 'kyacc')); |
||
| 139 | $sg1990->addChild($nSfio = new Node($dic, 'sfio')); |
||
| 140 | $sg1990->addChild($nYeast = new Node($dic, 'yeast')); |
||
| 141 | $sg1990->addChild($nML_X = new Node($dic, 'ML-X')); |
||
| 142 | $sg1990->addChild($nDOT = new Node($dic, 'DOT')); |
||
| 143 | |||
| 144 | $sgFuture->addChild($nAST = new Node($dic, 'Adv. Software Technology')); |
||
| 145 | |||
| 146 | /* the time-line graph */ |
||
| 147 | $g->addChild(new Edge($dic, $yPast = new Node($dic, 'past'), $y1978 = new Node($dic, 1978))); |
||
| 148 | $g->addChild(new Edge($dic, $y1978, $y1980 = new Node($dic, 1980))); |
||
| 149 | $g->addChild(new Edge($dic, $y1980, $y1982 = new Node($dic, 1982))); |
||
| 150 | $g->addChild(new Edge($dic, $y1982, $y1983 = new Node($dic, 1983))); |
||
| 151 | $g->addChild(new Edge($dic, $y1983, $y1985 = new Node($dic, 1985))); |
||
| 152 | $g->addChild(new Edge($dic, $y1985, $y1986 = new Node($dic, 1986))); |
||
| 153 | $g->addChild(new Edge($dic, $y1986, $y1987 = new Node($dic, 1987))); |
||
| 154 | $g->addChild(new Edge($dic, $y1987, $y1988 = new Node($dic, 1988))); |
||
| 155 | $g->addChild(new Edge($dic, $y1988, $y1989 = new Node($dic, 1989))); |
||
| 156 | $g->addChild(new Edge($dic, $y1989, $y1990 = new Node($dic, 1990))); |
||
| 157 | $g->addChild(new Edge($dic, $y1990, $yFuture = new Node($dic, 'future'))); |
||
| 158 | |||
| 159 | /* hierarchy */ |
||
| 160 | $g->addChild(new Edge($dic, $nSCCS, $nRCS)); |
||
| 161 | $g->addChild(new Edge($dic, $nSCCS, $n3DFS)); |
||
| 162 | $g->addChild(new Edge($dic, $nSCCS, $nNmake)); |
||
| 163 | $g->addChild(new Edge($dic, $nMake, $nNmake)); |
||
| 164 | $g->addChild(new Edge($dic, $nMake, $nBuild)); |
||
| 165 | $g->addChild(new Edge($dic, $nBourneSh, $nCshell)); |
||
| 166 | $g->addChild(new Edge($dic, $nBourneSh, $nksh)); |
||
| 167 | $g->addChild(new Edge($dic, $nYacc, $nRyacc)); |
||
| 168 | $g->addChild(new Edge($dic, $nCron, $nYeast)); |
||
| 169 | |||
| 170 | $g->addChild(new Edge($dic, $nReiserCpp, $nNcpp)); |
||
| 171 | $g->addChild(new Edge($dic, $nCshell, $nksh)); |
||
| 172 | |||
| 173 | $g->addChild(new Edge($dic, $nBuild, $nNmake20)); |
||
| 174 | $g->addChild(new Edge($dic, $nVi, $nksh)); |
||
| 175 | $g->addChild(new Edge($dic, $nVi, $nCurses)); |
||
| 176 | $g->addChild(new Edge($dic, $nEmacs, $nksh)); |
||
| 177 | |||
| 178 | $g->addChild(new Edge($dic, $nRCS, $nSBCS)); |
||
| 179 | $g->addChild(new Edge($dic, $nRCS, $nFdelta)); |
||
| 180 | $g->addChild(new Edge($dic, $nCurses, $nCurses_i)); |
||
| 181 | $g->addChild(new Edge($dic, $nSYNED, $nPeggy)); |
||
| 182 | $g->addChild(new Edge($dic, $nIMX, $nTTU)); |
||
| 183 | |||
| 184 | $g->addChild(new Edge($dic, $nksh, $nNmake)); |
||
| 185 | $g->addChild(new Edge($dic, $nksh, $nKsh_i)); |
||
| 186 | $g->addChild(new Edge($dic, $nksh, $nKsh88)); |
||
| 187 | $g->addChild(new Edge($dic, $nIFS, $nCurses_i)); |
||
| 188 | $g->addChild(new Edge($dic, $nIFS, $nSfio)); |
||
| 189 | $g->addChild(new Edge($dic, $nIFS, $nIFS_i)); |
||
| 190 | $g->addChild(new Edge($dic, $nTTU, $nPg2)); |
||
| 191 | |||
| 192 | $g->addChild(new Edge($dic, $nNmake, $nksh)); |
||
| 193 | $g->addChild(new Edge($dic, $nNmake, $nNcpp)); |
||
| 194 | $g->addChild(new Edge($dic, $nNmake, $n3DFS)); |
||
| 195 | $g->addChild(new Edge($dic, $nNmake, $nNmake20)); |
||
| 196 | $g->addChild(new Edge($dic, $nPeggy, $nPegasusPml)); |
||
| 197 | $g->addChild(new Edge($dic, $nPeggy, $nRyacc)); |
||
| 198 | |||
| 199 | $g->addChild(new Edge($dic, $nCasterisk, $nCSAS)); |
||
| 200 | $g->addChild(new Edge($dic, $nNcpp, $nAnsiCpp)); |
||
| 201 | $g->addChild(new Edge($dic, $nCurses_i, $nFdelta)); |
||
| 202 | $g->addChild(new Edge($dic, $nKsh_i, $nKsh88)); |
||
| 203 | $g->addChild(new Edge($dic, $nPg2, $nBacktalk)); |
||
| 204 | |||
| 205 | $g->addChild(new Edge($dic, $nDAG, $nSoftwareIs = new Node($dic, 'Software IS'))); |
||
| 206 | $g->addChild(new Edge($dic, $nDAG, $nDOT)); |
||
| 207 | $g->addChild(new Edge($dic, $nDAG, $nDIA)); |
||
| 208 | $g->addChild(new Edge($dic, $nCSAS, $nCia)); |
||
| 209 | $g->addChild(new Edge($dic, $nAnsiCpp, $nConfigMgt = new Node($dic, 'Configuration Mgt'))); |
||
| 210 | $g->addChild(new Edge($dic, $nFdelta, $nSBCS)); |
||
| 211 | $g->addChild(new Edge($dic, $nFdelta, $nPAX)); |
||
| 212 | $g->addChild(new Edge($dic, $n3DFS, $nConfigMgt)); |
||
| 213 | $g->addChild(new Edge($dic, $nNmake20, $nConfigMgt)); |
||
| 214 | $g->addChild(new Edge($dic, $nNmake20, $nCoShell)); |
||
| 215 | |||
| 216 | $g->addChild(new Edge($dic, $nCia, $nCIApp)); |
||
| 217 | $g->addChild(new Edge($dic, $nCia, $nDIA)); |
||
| 218 | $g->addChild(new Edge($dic, $nSBCS, $nConfigMgt)); |
||
| 219 | $g->addChild(new Edge($dic, $nPAX, $nSHIP)); |
||
| 220 | $g->addChild(new Edge($dic, $nKsh88, $nConfigMgt)); |
||
| 221 | $g->addChild(new Edge($dic, $nKsh88, $nArchi = new Node($dic, 'Architecture & Libraries'))); |
||
| 222 | $g->addChild(new Edge($dic, $nKsh88, $nSfio)); |
||
| 223 | $g->addChild(new Edge($dic, $nPegasusPml, $nML_X)); |
||
| 224 | $g->addChild(new Edge($dic, $nPegasusPml, $nArchi)); |
||
| 225 | $g->addChild(new Edge($dic, $nBacktalk, $nDataShare)); |
||
| 226 | |||
| 227 | $g->addChild(new Edge($dic, $nCIApp, $nSoftwareIs)); |
||
| 228 | $g->addChild(new Edge($dic, $nAPP, $nDIA)); |
||
| 229 | $g->addChild(new Edge($dic, $nAPP, $nSoftwareIs)); |
||
| 230 | $g->addChild(new Edge($dic, $nSHIP, $nConfigMgt)); |
||
| 231 | $g->addChild(new Edge($dic, $nDataShare, $nArchi)); |
||
| 232 | $g->addChild(new Edge($dic, $nRyacc, $nKyacc)); |
||
| 233 | $g->addChild(new Edge($dic, $nMosaic, $nProcess = new Node($dic, 'Process'))); |
||
| 234 | |||
| 235 | $g->addChild(new Edge($dic, $nDOT, $nSoftwareIs)); |
||
| 236 | $g->addChild(new Edge($dic, $nDIA, $nSoftwareIs)); |
||
| 237 | $g->addChild(new Edge($dic, $nLibft, $nSoftwareIs)); |
||
| 238 | $g->addChild(new Edge($dic, $nCoShell, $nConfigMgt)); |
||
| 239 | $g->addChild(new Edge($dic, $nCoShell, $nArchi)); |
||
| 240 | $g->addChild(new Edge($dic, $nSfio, $nArchi)); |
||
| 241 | $g->addChild(new Edge($dic, $nIFS_i, $nArchi)); |
||
| 242 | $g->addChild(new Edge($dic, $nML_X, $nArchi)); |
||
| 243 | $g->addChild(new Edge($dic, $nKyacc, $nArchi)); |
||
| 244 | $g->addChild(new Edge($dic, $nYeast, $nProcess)); |
||
| 245 | |||
| 246 | $g->addChild(new Edge($dic, $nArchi, $nAST)); |
||
| 247 | $g->addChild(new Edge($dic, $nSoftwareIs, $nAST)); |
||
| 248 | $g->addChild(new Edge($dic, $nConfigMgt, $nAST)); |
||
| 249 | $g->addChild(new Edge($dic, $nProcess, $nAST)); |
||
| 250 | } |
||
| 251 | |||
| 475 |
This check looks for a call to a parent method whose name is different than the method from which it is called.
Consider the following code:
The
getFirstName()method in theSoncalls the wrong method in the parent class.