Shopware_Controllers_Frontend_PaymentKlarna::checkKlarnaOrderExistsByReservation() - Code Metrics - Inspection of "Apply all commits up to SVN revision 6577" - FATCHIP-GmbH/plugin-shopware5-klarna-checkout - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( ad9d2a...3a231c )

by Mario
created 2017-03-20 20:58 UTC
checkKlarnaOrderExistsByReservation() A

↳ Parent: Shopware_Controllers_Frontend_PaymentKlarna
Complexity

Conditions	3
Paths	4
Size

Total Lines	17
Code Lines	9
Duplication

Lines	17
Ratio	100 %
Importance

Changes
Metric	Value
cc	3
dl	17
loc	17
rs	9.4285
c	0
b	0
f	0
eloc	9
nc	4
nop	1
<?php

use Shopware\Components\CSRFWhitelistAware;

/**
 * Klarna payment controller
 */
class Shopware_Controllers_Frontend_PaymentKlarna extends Shopware_Controllers_Frontend_Payment implements CSRFWhitelistAware
{
    /**
     * @var Shopware_Plugins_Frontend_SwagPaymentKlarna_Bootstrap
     */
    private $plugin;

    /**
     * @var Enlight_Config
     */
    private $config;

    /**
     * {@inheritdoc}
     */
    public function preDispatch()
    {
        $this->plugin = $this->get('plugins')->Frontend()->SwagPaymentKlarna();
        $this->config = $this->plugin->Config();
        if (in_array($this->Request()->getActionName(), array('push', 'saveFormData'))) {
            $this->Front()->Plugins()->ViewRenderer()->setNoRender();
        }
    }
    
    /**
     * whitelists indexAction for SW 5.2 compatibility
     */
    public function getWhitelistedCSRFActions()
    {
        return [
            'index',
            'express',
            'push',
            'login',
            'return',
        ];
    }    

    /**
     * {@inheritdoc}
     */
    public function get($name)

    {
        if (version_compare(Shopware::VERSION, '4.2.0', '<') && Shopware::VERSION != '___VERSION___') {
            if ($name == 'pluginlogger') {
                $name = 'log';
            }
            $name = ucfirst($name);
            return Shopware()->Bootstrap()->getResource($name);
        }
        return parent::get($name);
    }
    
    /**
     * Index action method.
     *
     * Forwards to correct the action.
     */
    public function indexAction()
    {
        $this->redirect(array('controller' => 'checkout', 'action' => 'confirm'));
    }

    /**
     * Express payment action method.
     */
    public function expressAction()
    {
        $session = Shopware()->Session();
        
        if (!empty($session->PaypalResponse)){
            $this->plugin->klarnaLog("Paypal Payment in Progress detected Redirecting To Index Page", 3);
            $this->redirect(
                array(
                    'controller' => 'index',
                    'action' => 'index'
                )
            );
            return;
        }        
        
        if ($this->Request()->getPost('sCountry')) {
            $session['sCountry'] = (int)$this->Request()->getPost('sCountry');
            $session["sState"] = 0;
            $session["sArea"] = Shopware()->Db()->fetchOne("
                SELECT areaID FROM s_core_countries WHERE id = ?
            ", array($session['sCountry']));
            unset($session->KlarnaOrder);
            $session['sChangedCountry'] = (int)$this->Request()->getPost('sCountry');
        }
        
        if (!$this->isUserLoggedIn($session)){
	        $this->createAccount();
	}
        
        $user = Shopware()->Modules()->Admin()->sGetUserData();
        if ($this->Request()->getPost('sCountry')) {
          $session['sCountry'] = $this->Request()->getPost('sCountry'); 
          $session['sChangedCountry'] = $this->Request()->getPost('sCountry'); 
        }

        // Switch Paymentmean to Klarna Checkout
        $sql = 'SELECT id FROM s_core_paymentmeans WHERE name=?';
        $paymentId = Shopware()->Db()->fetchOne($sql, array('klarna_checkout'));
        $this->savePayment($paymentId);
        
        if (!$this->plugin->isKlarnaKcoPaymentActive($user) && $this->plugin->isKlarnaUser()) {
            $session->offsetUnset('sUserId');
            $session->offsetSet('sRegisterFinished', false);
            $this->plugin->removeKlarnaUsers();
        }

        $this->forward('index');
    }

   /**
     * @param Klarna_Checkout_Order $order
     */
    public function createAccount($order = null, $checkLoginState=true)
    {
        $this->plugin->klarnaLog('Entering Shopware_Controllers_Frontend_PaymentKlarna::createAccount', 3);
        $module = Shopware()->Modules()->Admin();
        $session = Shopware()->Session();

        $version = Shopware()->Config()->version;
        if ($version == '___VERSION___' || version_compare($version, '4.1.0', '>=')) {
            $encoder = Shopware()->PasswordEncoder()->getDefaultPasswordEncoderName();
        }
        
        $data = array();

        if ($order !== null && !empty($order['billing_address']['email'])) {
            $data['auth']['email'] = $order['billing_address']['email'];
            $data['auth']['password'] = $order['reference'];
        } else {
            $sessionId = Shopware()->SessionID();
            // email is only varchar(70) so we cut the sessionid
            //$sessionId = substr($sessionId, 0,49);

            $data['auth']['email'] = substr($sessionId, 0,49) . '@klarna.com';
            $data['auth']['password'] = $sessionId;
        }
        $data['auth']['accountmode'] = '1';

        $phone = $order['billing_address']['phone'];
        $data['billing']['phone'] = !empty($phone) ? $phone : ' ';
        $data['phone'] = !empty($phone) ? $phone : ' ';
        if (!empty($order['customer']['date_of_birth'])) {
            list($data['billing']['birthyear'], $data['billing']['birthmonth'], $data['billing']['birthday']) = explode(
                '-',
                $order['customer']['date_of_birth']
            );
        }

        $this->plugin->klarnaLog("Shopware_Controllers_Frontend_PaymentKlarna::createAccount->order:",4, $order);
        
        foreach (array('billing', 'shipping') as $type) {
            if (isset($order[$type . '_address'])) {
                $orderAddress = $order[$type . '_address'];
                if (isset($orderAddress['title'])) {
                    $data[$type]['salutation'] = $orderAddress['title'] == 'Frau' ? 'ms' : 'mr';
                } else {
                    $data[$type]['salutation'] = 'mr';
                }
                $data[$type]['firstname'] = $orderAddress['given_name'];
                $data[$type]['lastname'] = $orderAddress['family_name'];
                if (isset($orderAddress['street_name']) && $orderAddress['street_number']) {
                    if (version_compare(Shopware::VERSION, '5.0.0', '>=')) {
                        $data[$type]['street'] = $orderAddress['street_name'] . ' ' . $orderAddress['street_number'];
                    } else {

                        $data[$type]['street'] = $orderAddress['street_name'];
                        $data[$type]['streetnumber'] = $orderAddress['street_number'];
                    }
                } else {
                    $data[$type]['street'] = $orderAddress['street_address'];
                    $data[$type]['streetnumber'] = ' ';
                }
                $data[$type]['zipcode'] = $orderAddress['postal_code'];
                $data[$type]['city'] = $orderAddress['city'];
                if (!empty($orderAddress['care_of'])) {
                    if ($orderAddress['street_name'] == 'Packstation') {
                        $data[$type]['postnumber'] = $orderAddress['care_of'];
                        $data[$type]['swagDhlPostnumber'] = $data[$type]['postnumber'];
                    } else {
                        $data[$type]['company'] = $orderAddress['care_of'];
                    }
                }
            } else {
                $data[$type]['salutation'] = 'mr';
                $data[$type]['firstname'] = 'Klarna Firstname';
                $data[$type]['lastname'] = 'Klarna Checkout';
                $data[$type]['street'] = 'Klarna Street';
                $data[$type]['streetnumber'] = ' ';
                $data[$type]['zipcode'] = '00000';
                $data[$type]['city'] = 'Klarna City ';
                $data[$type]['birthday'] = '0000-00-00';
                $data[$type]['phone'] = '00000000';
            }
            if (!isset($data[$type]['company'])) {
                $data[$type]['company'] = '';
            }
            $data[$type]['department'] = '';

            if (!empty($order[$type . '_address']['country'])) {
                $sql = 'SELECT id FROM s_core_countries WHERE countryiso=?';
                $countryId = Shopware()->Db()->fetchOne($sql, array($order[$type . '_address']['country']));
            } else {
                $countryId = $session['sCountry'];
            }
            // make sure country is set in case of lost sessions defualt to germany
            if (empty($countryId)){
                $countryId = 2;
            }            

            $data[$type]['country'] = $countryId;
        }

        $this->plugin->klarnaLog("Shopware_Controllers_Frontend_PaymentKlarna::createAccount->data AFTER ADDRESSES:",4,$data);
        $sql = 'SELECT id FROM s_core_paymentmeans WHERE name=?';
        $paymentId = Shopware()->Db()->fetchOne($sql, array('klarna_checkout'));

        if ($order !== null && !empty($order['billing_address']['email'])) {
            $shop = $this->get('shop');
            $shop = $shop->getMain() ?: $shop;
            $sql = 'SELECT id, email, `password` FROM `s_user` WHERE `email` LIKE ? AND `active` = 1 ';
            if ($shop->getCustomerScope()) {
                $sql .= "AND `subshopID` = {$shop->getId()} ";
            }
            $sql .= 'ORDER BY `accountmode`';
            $user = Shopware()->Db()->fetchRow($sql, array($data['auth']['email']));
            // First try login 
            if (!empty($user)) {
                $session->offsetSet('sUserMail', $user['email']);
                $session->offsetSet('sUserPassword', $user['password']);
                $session->offsetSet('sUserId', $user['id']);
            } else {
                $this->plugin->klarnaLog("Shopware_Controllers_Frontend_PaymentKlarna::createAccount->user Not Found in DB SQL was:" .$sql,1);                
            }
        }

        if ($checkLoginState) {
            // Check login status
            if (!empty($session->sUserId)) {
                if ($order !== null) {
                    $module->sSYSTEM->_POST = $data['shipping'];
                    if (Shopware::VERSION === '___VERSION___' || version_compare(Shopware::VERSION, '5.2.0', '>=')) {

                        $userId = $session->offsetGet('sUserId');
                        $this->updateShipping($userId, $data['shipping']);
                    } else {
                        $module->sUpdateShipping();
                    }
                    $module->sSYSTEM->_POST = $data['billing'];
                    if (Shopware::VERSION === '___VERSION___' || version_compare(Shopware::VERSION, '5.2.0', '>=')) {                

                         $userId = $session->offsetGet('sUserId');
                         $this->updateBilling($userId, $data['billing']);
                    } else{
                        $module->sUpdateBilling();
                    }
                    unset($data['auth']['password']);
                    $module->sSYSTEM->_POST = $data['auth'];
                    if (Shopware::VERSION === '___VERSION___' || version_compare(Shopware::VERSION, '5.2.0', '>=')) {
                        $userId = $session->offsetGet('sUserId');
                        $this->updateCustomer($data, $userId);
                        $this->plugin->klarnaLog("Shopware_Controllers_Frontend_PaymentKlarna::createAccount->updateCustomer:",3, $data);                                                
                    } else{
                        $module->sUpdateAccount();
                        $this->plugin->klarnaLog("Shopware_Controllers_Frontend_PaymentKlarna::createAccount->updateAccount:",3, $this->front->Request()->getPost());                                                                        
                    }
                } else {
                    /** @var Enlight_Controller_Front $front */
                    $front = $this->get('front');
                    $front->Request()->setPost(array());
                    $module->sSYSTEM->_POST = array('country' => $data['shipping']['country']);
                    $shippingId = $this->get('db')->fetchOne(
                        'SELECT id FROM s_user_shippingaddress WHERE userID = ?',
                        array($session->offsetGet('sUserId'))
                    );
                    if (!empty($shippingId)) {

                        if (Shopware::VERSION === '___VERSION___' || version_compare(Shopware::VERSION, '5.2.0', '>=')) {
                            $userId = $session->offsetGet('sUserId');
                            $this->updateShipping($userId, $data['shipping']);
                        } else {
                            $module->sUpdateShipping();
                        }
                    } else {
                        $module->sUpdateBilling();
                    }
                }
                $module->sSYSTEM->_POST = array('sPayment' => $paymentId);
                $module->sUpdatePayment();
            } else {
                $data['payment']['object'] = $module->sGetPaymentMeanById($paymentId);
                if (isset($encoder)) {
                    $data["auth"]["encoderName"] = $encoder;
                    $data["auth"]["password"] = Shopware()->PasswordEncoder()->encodePassword($data["auth"]["password"], $encoder);
                } else {
                    $data['auth']['password'] = md5($data['auth']['password']);
                }
                $session->sRegisterFinished = false;
                if (version_compare(Shopware::VERSION, '4.3.0', '>=') && version_compare(Shopware::VERSION, '5.2.0', '<')) {
                    $session->sRegister = $data;
                } elseif (version_compare(Shopware::VERSION, '4.3.0', '<')) {
                    $session->sRegister = new ArrayObject($data, ArrayObject::ARRAY_AS_PROPS);
                }
                try {
                    if (Shopware::VERSION === '___VERSION___' || version_compare(Shopware::VERSION, '5.2.0', '>=')) {
                        $newdata = $this->saveUser($data);
                        $module->sSYSTEM->_POST = $newdata['auth'];
                        $errors = $module->sLogin(true);                     
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                        $this->plugin->klarnaLog("Shopware_Controllers_Frontend_PaymentKlarna::createAccount->saveUser:",3, $newdata);                        
                        // $this->returnAction();

                    } else {
                        $this->plugin->klarnaLog("Shopware_Controllers_Frontend_PaymentKlarna::createAccount->saveUser->Register:",3, $session->sRegister);                         
                        $module->sSaveRegister();
                        $this->plugin->klarnaLog("Shopware_Controllers_Frontend_PaymentKlarna::createAccount->saveUser->RegisterFinished:",3, $session->offsetGet('sRegisterFinished')); 
                    }
                    
                } catch (\Exception $ex) { /* do nothing */
                    $this->klarnaLog("ERROR while creating User. Exception information:".$ex->getMessage(),1);
                    
                }
            }
            
        }
        
        $this->plugin->klarnaLog("Shopware_Controllers_Frontend_PaymentKlarna::createAccount->data END OF METHOD:",4, $data);
    }
    
    /**
     * Saves a new user to the system.
     *
     * @param array $data
     */
    private function saveUser($data)
    {

        $builder = Shopware()->Models()->createQueryBuilder();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $plain = array_merge($data['auth'], $data['shipping']);

        //Create forms and validate the input
        $customer = new Shopware\Models\Customer\Customer();
        $form = $this->createForm('Shopware\Bundle\AccountBundle\Form\Account\PersonalFormType', $customer);
        $form->submit($plain);

        $address = new Shopware\Models\Customer\Address();
        $form = $this->createForm('Shopware\Bundle\AccountBundle\Form\Account\AddressFormType', $address);
        $form->submit($plain);

        /** @var Shopware\Bundle\StoreFrontBundle\Struct\ShopContextInterface $context */
        $context = $this->get('shopware_storefront.context_service')->getShopContext();

        /** @var Shopware\Bundle\StoreFrontBundle\Struct\Shop $shop */
        $shop = $context->getShop();

        /** @var Shopware\Bundle\AccountBundle\Service\RegisterServiceInterface $registerService */
        $registerService = $this->get('shopware_account.register_service');
        $registerService->register($shop, $customer, $address, $address);

        // get updated password; it is md5 randomized after register
        $getUser = Shopware()->Models()->getRepository('Shopware\Models\Customer\Customer')->findOneBy(
		array('email' =>  $data['auth']['email'])
		);

       $data['auth']['password']= $getUser->getPassword();
       $data['auth']['passwordMD5']= $getUser->getPassword();
       $data['auth']['encoderName'] = 'md5';
        return $data;
    }


    /**
     * Endpoint for changing the main profile data
     */
    public function updateCustomer($data, $userId)
    {
        $data['birthdate'] = $data['billing']['birthyear'].'-'.$data['billing']['birthmonth'].'-'.$data['billing']['birthday'];
        $data['birthday'] = $data['birthdate'];    
        $data['email'] = $data['auth']['email'];
        $data['firstname'] = $data['billing']['firstname'];
        $data['lastname'] = $data['billing']['lastname'];
        unset ($data['shipping']);
        unset ($data['billing']);        

        $customer = Shopware()->Models()->getRepository('Shopware\Models\Customer\Customer')->findOneBy(
		array('id' =>  $userId)
		);
        $customer->fromArray($data);
        Shopware()->Container()->get('shopware_account.customer_service')->update($customer);
    }


     /**
     * Updates the shipping address
     *
     * @param int $userId
     * @param array $shippingData
     */
    private function updateShipping($userId, $shippingData)
    {
        /** @var \Shopware\Components\Model\ModelManager $em */
        $em = $this->get('models');

        /** @var \Shopware\Models\Customer\Customer $customer */
        $customer = $em->getRepository('Shopware\Models\Customer\Customer')->findOneBy(array('id' => $userId));

        /** @var \Shopware\Models\Customer\Address $address */
        $addressold = $customer->getDefaultShippingAddress();
        $address = new \Shopware\Models\Customer\Address();
        
         /** @var \Shopware\Models\Country\Country $country */
        $country = $addressold->getCountry();
        $shippingData['country'] = $country;
        if ($shippingData['phone'] === null) {
            $shippingData['phone'] = ' ';
        }
        $address->fromArray($shippingData);
        try {
            $addressService = $this->get('shopware_account.address_service');
            $addressService->create($address, $customer);
            $addressService->setDefaultShippingAddress($address);
        } catch (Exception $ex) {
            $this->klarnaLog("ERROR while creating address via address service. Exception information:".$ex->getMessage(),1);
        }
        
    }

    /**
     * Updates the billing address
     *
     * @param int $userId
     * @param array $billingData
     */
    private function updateBilling($userId, $billingData)
    {
        /** @var \Shopware\Components\Model\ModelManager $em */
        $em = $this->get('models');

        /** @var \Shopware\Models\Customer\Customer $customer */
        $customer = $em->getRepository('Shopware\Models\Customer\Customer')->findOneBy(array('id' => $userId));

        /** @var \Shopware\Models\Customer\Address $address */
        $address = $customer->getDefaultBillingAddress();
        
         /** @var \Shopware\Models\Country\Country $country */
        $country = $address->getCountry();
        $billingData['country'] = $country;
        $address->fromArray($billingData);

        $this->get('shopware_account.address_service')->update($address);
    }


    /**
     * Needed to reset the session when the user logs in
     */
    public function loginAction()
    {
        Shopware()->Session()->offsetSet('KlarnaOrder', null);
        $this->redirect(array('controller' => 'payment_klarna', 'action' => 'express'));
    }

    /**
     * Return action method
     *
     * Reads the transactionResult and represents it for the customer.
     */
    public function returnAction()
    {
        $this->plugin->klarnaLog("Entering Shopware_Controllers_Frontend_PaymentKlarna::returnAction",3);
        if ($this->getPaymentShortName() != 'klarna_checkout') {
            $this->forward('index');
            return;
        }
        $transactionId = $this->Request()->getParam('transactionId');
        
        $connector = $this->plugin->getConnector();

        $order = new Klarna_Checkout_Order($connector, $transactionId);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->plugin->klarnaLog("Entering Shopware_Controllers_Frontend_PaymentKlarna::returnAction->transactionId:\n".$transactionId,3);
        $this->plugin->klarnaLog("Entering Shopware_Controllers_Frontend_PaymentKlarna::returnAction->order:",4, $order);
        $orderNumber = '';
        
        try {
            $order->fetch();

            $this->createAccount($order);
            $this->plugin->updateOrderVariables();

            if ($order['status'] == 'checkout_complete') {
                $this->plugin->klarnaLog("Entering Shopware_Controllers_Frontend_PaymentKlarna::returnAction: checkout_complete. Save oder if session values match.",3);
                if (Shopware()->Session()->offsetGet('KlarnaTransactionId') == null){
                    $this->plugin->klarnaLog("Entering Shopware_Controllers_Frontend_PaymentKlarna::returnAction: Session matches. Order will be saved",3);
                    Shopware()->Session()->offsetSet('KlarnaTransactionId', $transactionId );
                    $orderNumber = $this->saveOrder(
                        $order['reservation'],
                        $order['reference']
                    );
                    Shopware()->Session()->offsetSet('KlarnaTransactionId', null );                
                }

                $this->plugin->klarnaLog("Shopware_Controllers_Frontend_PaymentKlarna::returnAction: checkout_complete. Check if Order was persisted in DB.",3);    

                $this->plugin->klarnaLog("Shopware_Controllers_Frontend_PaymentKlarna::returnAction: checkout_complete. Searching for Order:",3);
                $this->checkKlarnaOrderExistsByReservation($order['reservation']);
                $this->checkKlarnaOrderExistsByReference($order['reference']);
                $this->checkKlarnaOrderExistsBySession(Shopware()->Session()->sUserId);
                $this->checkKlarnaOrderDetailsBySession(Shopware()->Session()->sUserId);
            }

            if (empty($orderNumber) && !empty($order['merchant_reference']['orderid1'])) {
                $orderNumber = $order['merchant_reference']['orderid1'];
            }
            $update = array();
            $update['merchant_reference'] = array(
                'orderid1' => (string) $orderNumber,
                'orderid2' => (string) $order['reference']
            );
            $order->update($update);   
           
            // Saves postnumber for dhl packstation
            if (!empty($orderNumber)
                && !empty($order['shipping_address']['care_of'])
                && $order['shipping_address']['street_name'] == 'Packstation'
                && $this->config->get('postnumberField')
            ) {
                $field = $this->config->get('postnumberField');
                $value = $order['shipping_address']['care_of'];
                $this->saveOrderAttribute($orderNumber, $field, $value);
            }

            if ($order['status'] == 'created' || $order['status'] == 'checkout_complete') {
                $this->saveOrderAttribute($orderNumber, 'swag_klarna_status', 'created');
                $this->savePaymentStatus(
                                $order['reservation'],
                                $order['reference'],
                                $this->config->get('statusId')
                            );                
                $this->redirect(array(
                    'controller' => 'checkout',
                    'action' => 'finish',
                    'sUniqueID' => $order['reference']
                ));
            } else {
                $this->redirect(array('controller' => 'checkout', 'action' => 'confirm'));
            }
        } catch (Exception $e) {
            Shopware()->Plugins()->Controller()->ViewRenderer()->setNoRender();
            $this->plugin->klarnaLog("Shopware_Controllers_Frontend_PaymentKlarna::returnAction: Catch. Searching for Order:",3);   
            $this->checkKlarnaOrderExistsByReservation($order['reservation']);
            $this->checkKlarnaOrderExistsByReference($order['reference']);
            $this->checkKlarnaOrderExistsBySession(Shopware()->Session()->sUserId); 
            $this->checkKlarnaOrderDetailsBySession(Shopware()->Session()->sUserId); 
            echo "Entschuldigung, Ein Verbindungsfehler ist aufgetreten, bitte aktualisieren Sie die Seite";
        }            
    }
    
    /**
     * Method checks if certain klarna order exists or not
     * 
     * @param string $sessionID
     * @return bool
     */
    protected function checkKlarnaOrderExistsBySession($sessionID) {

        $sql = '
            SELECT * FROM s_order
            WHERE userID=?
        ';
        
        $order = Shopware()->Db()->fetchAll($sql, array(
                $sessionID
        ));
        
        $orderExists = (empty($order)) ? false : true;
        $this->plugin->klarnaLog("Shopware_Controllers_Frontend_PaymentKlarna::checkKlarnaOrderExistsBySession:",3);   
        if ($orderExists){
            $this->plugin->klarnaLog("Shopware_Controllers_Frontend_PaymentKlarna::checkKlarnaOrderExistsBySession: Order Found: ",3, $order);   
        }
        return $orderExists;
    }    
    
    /**
     * Method checks if certain klarna order exists or not
     * 
     * @param string $transactionId
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param string $paymentUniqueId
     * @return bool
     */
    protected function checkKlarnaOrderExistsByReference($paymentUniqueId) {

        $sql = '
            SELECT * FROM s_order
            WHERE temporaryID=?
        ';
        
        $order = Shopware()->Db()->fetchAll($sql, array(
                $paymentUniqueId
        ));
        
        $orderExists = (empty($order)) ? false : true;
        $this->plugin->klarnaLog("Shopware_Controllers_Frontend_PaymentKlarna::checkKlarnaOrderExistsByReference:",3);   
        if ($orderExists){
            $this->plugin->klarnaLog("Shopware_Controllers_Frontend_PaymentKlarna::checkKlarnaOrderExistsByReference: Order Found: ",3, $order);   
        }
        return $orderExists;
    }
    
    /**
     * Method checks if certain klarna order exists or not
     * 
     * @param string $transactionId
     * @param string $paymentUniqueId
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return bool
     */
    protected function checkKlarnaOrderExistsByReservation($transactionId) {

        $sql = '
            SELECT * FROM s_order
            WHERE transactionID=?
        ';
        
        $order = Shopware()->Db()->fetchAll($sql, array(
                $transactionId
        ));
        
        $orderExists = (empty($order)) ? false : true;
        $this->plugin->klarnaLog("Shopware_Controllers_Frontend_PaymentKlarna::checkKlarnaOrderExistsByReservation:",3);   
        if ($orderExists){
            $this->plugin->klarnaLog("Shopware_Controllers_Frontend_PaymentKlarna::checkKlarnaOrderExistsByReservation: Order Found: ",3, $order);   
        }
        return $orderExists;
    }    
    
    /**
     * Method checks if certain klarna order exists or not
     * 
     * @param string $transactionId
     * @param string $paymentUniqueId
     * @param string $userId
     * @return bool
     */
    protected function checkKlarnaOrderExists($transactionId, $paymentUniqueId, $userId) {
        $sql = '
            SELECT ordernumber FROM s_order
            WHERE transactionID=? AND temporaryID=?
            AND status!=-1 AND userID=?
        ';
        
        $orderNumber = Shopware()->Db()->fetchOne($sql, array(
                $transactionId,
                $paymentUniqueId,
                $userId
        ));
        
        $orderExists = (empty($orderNumber)) ? false : true;
        
        return $orderExists;
    }
    
    /**
     * Method checks if certain klarna order exists or not
     * 
     * @param string $sessionID
     * @return bool
     */
    protected function checkKlarnaOrderDetailsBySession($sessionID) {

        $sql = '
            SELECT * FROM s_order
            LEFT JOIN s_order_details ON s_order.id = s_order_details.orderID
            WHERE userID=?
        ';
        
        $orderDetails = Shopware()->Db()->fetchAll($sql, array(
                $sessionID
        ));
        
        $orderExists = (empty($orderDetails)) ? false : true;
        $this->plugin->klarnaLog("Shopware_Controllers_Frontend_PaymentKlarna::checkKlarnaOrderDetailsBySession:",3);   
        if ($orderExists){
            $this->plugin->klarnaLog("Shopware_Controllers_Frontend_PaymentKlarna::checkKlarnaOrderDetailsBySession: OrderDetails Found: ",3, $orderDetails);
        }
        return $orderExists;
    }
    
    /**
     * Method checks if certain klarna order exists or not
     * 
     * @param string $paymentUniqueId
     * @return string
     */
    protected function getUserIdByReference($paymentUniqueId) {
        $sql = '
            SELECT userID FROM s_order
            WHERE temporaryID=?
        ';
        
        $userId = Shopware()->Db()->fetchOne($sql, array(
                $paymentUniqueId
        ));

        return $userId;
    }    
    
    /**
     *
     *
     * @param string $transactionId
     * @param string $paymentUniqueId
     * @param string $userId
     * @return string $orderNumber
     */
    protected function getKlarnaOrderNumber($transactionId, $paymentUniqueId, $userId) {

        $sql = '
            SELECT ordernumber FROM s_order
            WHERE transactionID=? AND temporaryID=?
            AND status!=-1 AND userID=?
        ';

        $orderNumber = Shopware()->Db()->fetchOne($sql, array(
            $transactionId,
            $paymentUniqueId,
            $userId
        ));

        return $orderNumber;
    }

    /**
     *
     *
     * @param string $transactionId
     * @param string $paymentUniqueId
     * @param string $userId
     * @return string $orderId
     */
    protected function getKlarnaOrderId($transactionId, $paymentUniqueId, $userId) {

        $sql = '
            SELECT id FROM s_order
            WHERE transactionID=? AND temporaryID=?
            AND status!=-1 AND userID=?
        ';

        $orderId = Shopware()->Db()->fetchOne($sql, array(
            $transactionId,
            $paymentUniqueId,
            $userId
        ));

        return $orderId;
    }


    /**
     * Notify action method
     */
    public function pushAction()
    {
        $transactionId = $this->Request()->getParam('transactionId');
       
        $this->plugin->klarnaLog("Shopware_Controllers_Frontend_PaymentKlarna::pushAction->transactionId:\n".$transactionId,3);
        $connector = $this->plugin->getConnector();
        $order = new Klarna_Checkout_Order($connector, $transactionId);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $order->fetch();
        $this->plugin->klarnaLog("Shopware_Controllers_Frontend_PaymentKlarna::pushAction->order:",4, $order);
        
        $userId = $this->getUserIdByReference($order['reference']);
        $this->plugin->klarnaLog("Shopware_Controllers_Frontend_PaymentKlarna::pushAction->UserID: " .$userId ,3);
        // before continuing its mandatory to check if order has been persisted
        $orderExists = $this->checkKlarnaOrderExists($order['reservation'], $order['reference'], $userId);
        if (!$orderExists) {
            /**
             * @todo: Adding mechanism so that cancel signal will be send to klarna, if push notifications are over the limit of about 2 calls
             */
                $this->plugin->klarnaLog("Shopware_Controllers_Frontend_PaymentKlarna::pushAction: checkout_complete. Order was not persisted in DB, UserId is" .$userId ,1);    
                $this->plugin->klarnaLog("Shopware_Controllers_Frontend_PaymentKlarna::pushAction: checkout_complete. Searching for Order:",1);   
                $this->checkKlarnaOrderExistsByReservation($order['reservation']);
                $this->checkKlarnaOrderExistsByReference($order['reference']);
                $this->checkKlarnaOrderExistsBySession($userId);  
                $this->checkKlarnaOrderDetailsBySession($userId); 
                return;
        }
        
        $orderNumber = $this->getKlarnaOrderNumber($order['reservation'], $order['reference'], $userId);
        $orderId = $this->getKlarnaOrderId($order['reservation'], $order['reference'], $userId);
        $this->plugin->klarnaLog("Shopware_Controllers_Frontend_PaymentKlarna::pushAction: Found Order was found in DB... Sending Update to Klarna: " .$orderNumber,1);

        // Check if Order Username ist false (Klarna Firstname)

        $swUser = Shopware()->Models()->getRepository('Shopware\Models\Customer\Customer')->findOneBy(
            array('id' =>  $userId )
        );

        $firstName = $swUser->getBilling()->getFirstname();
       if ($firstName === 'Klarna Firstname') {
           $this->plugin->klarnaLog("Shopware_Controllers_Frontend_PaymentKlarna::pushAction: Found Order with Klarna Firstname, updating from Klarna data: " .$orderNumber,1);
           $data['billing']['salutation'] = $order['billing_address']['title'];
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
           $data['billing']['firstname'] = $order['billing_address']['given_name'];
           $data['billing']['lastname'] = $order['billing_address']['family_name'];
           $data['billing']['street'] = $order['billing_address']['street_name']." ". $order['billing_address']['street_number'];           
           $data['billing']['zipcode'] = $order['billing_address']['postal_code'];
           $data['billing']['city'] = $order['billing_address']['city'];
           $data['billing']['birthday'] = $order['customer']['date_of_birth'];
           $data['billing']['phone'] = $order['billing_address']['phone'];

           $data['shipping']['salutation'] = $order['shipping_address']['title'];
           $data['shipping']['firstname'] = $order['shipping_address']['given_name'];
           $data['shipping']['lastname'] = $order['shipping_address']['family_name'];
           $data['shipping']['street'] = $order['shipping_address']['street_name']." ". $order['shipping_address']['street_number'];
           $data['shipping']['zipcode'] = $order['shipping_address']['postal_code'];
           $data['shipping']['city'] = $order['shipping_address']['city'];
           $data['shipping']['birthday'] = $order['customer']['date_of_birth'];
           $data['shipping']['phone'] = $order['shipping_address']['phone'];
           // Update Customer
           if (Shopware::VERSION === '___VERSION___' || version_compare(Shopware::VERSION, '5.2.0', '>=')) {
                unset ($data['billing']['birthday']);
                unset ($data['shipping']['birthday']);
                unset ($data['shipping']['phone']);                
               
                $customer = Shopware()->Models()->getRepository('Shopware\Models\Customer\Customer')->findOneBy(
                    array('id' =>  $userId)
                    );
                $customer->fromArray($data);
                Shopware()->Container()->get('shopware_account.customer_service')->update($customer);
                
               $this->updateShipping($userId, $data['shipping']);
               $this->updateBilling($userId, $data['billing']);
               
               // Update Order Addresses

               $orderShippingID = Shopware()->Db()->fetchOne(
                   'SELECT id FROM s_order_shippingaddress WHERE userID = ? AND orderID = ?',
                   array($userId, $orderId)
               );
               $where = array('id='.(int) $orderShippingID);
               Shopware()->Db()->update('s_order_shippingaddress',  $data['shipping'], $where);

               $orderBillingID = Shopware()->Db()->fetchOne(
                   'SELECT id FROM s_order_billingaddress WHERE userID = ? AND orderID = ?',
                   array($userId, $orderId)
               );
               $where = array('id='.(int) $orderBillingID);
               Shopware()->Db()->update('s_order_billingaddress',  $data['billing'], $where);
               
           } else{

               // Append streetnumber to street and unset field for sw 5.1
               // unset birthday too

               // Update User Addresses
               unset ($data['shipping']['birthday']);
               unset ($data['shipping']['phone']);

               $shippingID = Shopware()->Db()->fetchOne(
                   'SELECT id FROM s_user_shippingaddress WHERE userID = ?',
                   array($userId)
               );
               $where = array('id='.(int) $shippingID);
               Shopware()->Db()->update('s_user_shippingaddress',  $data['shipping'], $where);

               $billingID = Shopware()->Db()->fetchOne(
                   'SELECT id FROM s_user_billingaddress WHERE userID = ?',
                   array($userId)
               );
               $where = array('id='.(int) $billingID);
               Shopware()->Db()->update('s_user_billingaddress',  $data['billing'], $where);


               // Update Order Addresses

               $orderShippingID = Shopware()->Db()->fetchOne(
                   'SELECT id FROM s_order_shippingaddress WHERE userID = ? AND orderID = ?',
                   array($userId, $orderId)
               );
               $where = array('id='.(int) $orderShippingID);
               Shopware()->Db()->update('s_order_shippingaddress',  $data['shipping'], $where);

               $orderBillingID = Shopware()->Db()->fetchOne(
                   'SELECT id FROM s_order_billingaddress WHERE userID = ? AND orderID = ?',
                   array($userId, $orderId)
               );
               $where = array('id='.(int) $orderBillingID);
               Shopware()->Db()->update('s_order_billingaddress',  $data['billing'], $where);

           }
       }

        $update = array();
        $update['status'] = 'created';
        $update['merchant_reference'] = array(
            'orderid1' => (string) $orderNumber,
            'orderid2' => (string) $order['reference']
        );
        $this->plugin->klarnaLog("Shopware_Controllers_Frontend_PaymentKlarna::pushAction: Update Klarna ",1, $update);
        $order->update($update);
        $this->savePaymentStatus(
            $order['reservation'],
            $order['reference'],
            $this->config->get('statusId')
        );
    }

    private function saveOrderAttribute($orderNumber, $field, $value)
    {
        try {
            $sql = "
                INSERT INTO s_order_attributes (orderID, `$field`)
                SELECT id, ? FROM s_order WHERE ordernumber = ?
                ON DUPLICATE KEY UPDATE `$field` = VALUES(`$field`)
            ";
            $this->get('db')->query($sql, array(
                $value,
                $orderNumber
            ));
        } catch (Exception $e) {
            $this->plugin->klarnaLog("PROBLEM SAVING ORDER ATTRIBUTES AFTER KLARNA PUSH!:\n".$e->getMessage(),1);
        }
    }

    /**
     * Save register form so we can use it if user change between klarna and register tab
     */
    public function saveFormDataAction()
    {
        $form = $this->Request()->getPost();

        //unset password from passed post
        unset($form['register']['personal']['password']);

        if (!empty($form)) {
            Shopware()->Session()->klarnaSavedRegister = $form;
        }
    }

    /**
     * Helper method to redirect the request to the proper page to set the payment into the customer account
     */
    public function setPaymentAction()
    {
        if ($this->Request()->isPost()) {
            $values = $this->Request()->getPost('register');
            $payment = $values['payment'];
        } else {
            $payment = $this->Request()->getParam('paymentId');
        }

        if (empty($payment)) {
            return;
        }

        $user = Shopware()->Modules()->Admin()->sGetUserData();
        if (empty($user) || $user['billingaddress']['lastname'] == 'Klarna Checkout') {
            $session = Shopware()->Session();
            $session->offsetSet('sPaymentID', $payment);
            $session->offsetUnset('sUserId');
            $session->offsetSet('sRegisterFinished', false);

            $this->redirect(
                array(
                    'controller' => 'register',
                    'action' => 'index',
                    'sTarget' => 'checkout',
                    'sTargetAction' => 'confirm'
                )
            );
        } else {
            $this->savePayment($payment);
            $this->redirect(
                array(
                    'controller' => 'checkout',
                    'action' => 'confirm'
                )
            );
        }
    }

    /**
     * This action is called when the user is not logged in and tries to change the payment from klarna to another payment.
     * Only used in responsive theme.
     */
    public function otherPaymentAction()
    {
        $userData = Shopware()->Modules()->Admin()->sGetUserData();
        $session = Shopware()->Session();

        // When the user is a valid user and accidentally calls this action, we don't want to reset his session
        if ($userData['billingaddress']['lastname'] == 'Klarna Checkout') {
            $session->offsetUnset('sUserId');

            //Remove all temporary klarna-users older than 24 hours
            Shopware()->Plugins()->Frontend()->SwagPaymentKlarna()->removeKlarnaUsers();
            $session->offsetSet('sRegisterFinished', false);
        }
        
            // reset country
            $session['sCountry'] = $userData['additional']['country']['id'];
            unset($session['sChangedCountry']);

        //Register-controller redirects to checkout by default when the user is logged in already.
        $this->redirect(array(
            'controller' => 'register',
            'klarnaRedirect' => 1,
            'sTarget' => 'checkout',
            'sTargetAction' => 'shippingPayment'
        ));
    }

    /**
     * Helper method to set the selected payment-method into the session to change it in the customer-account after logging in
     *
     * @param $paymentId
     * @throws Enlight_Exception
     */
    private function savePayment($paymentId)
    {
        $admin = Shopware()->Modules()->Admin();
        $admin->sSYSTEM->_POST['sPayment'] = $paymentId;
        $validation = $admin->sValidateStep3();

        if (!empty($validation['checkPayment']['sErrorMessages']) || empty($validation['sProcessed'])) {
            $this->View()->assign('sErrorFlag', $validation['checkPayment']['sErrorFlag']);
            $this->View()->assign('sErrorMessages', $validation['checkPayment']['sErrorMessages']);
        } else {
            $previousPayment = $admin->sGetUserData();
            $previousPayment = $previousPayment['additional']['user']['paymentID'];

            $previousPayment = $admin->sGetPaymentMeanById($previousPayment);
            if ($previousPayment['paymentTable']) {
                $deleteSQL = 'DELETE FROM '.$previousPayment['paymentTable'].' WHERE userID=?';
                Shopware()->Db()->query($deleteSQL, array(Shopware()->Session()->offsetGet('sUserId')));
            }

            $admin->sUpdatePayment();

            if ($validation['sPaymentObject'] instanceof \ShopwarePlugin\PaymentMethods\Components\BasePaymentMethod) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
                $validation['sPaymentObject']->savePaymentData(Shopware()->Session()->offsetGet('sUserId'), $this->Request());
            }
        }
    }
    
    protected function isUserLoggedIn($session)
    {        
         return (isset($session->sUserId) && !empty($session->sUserId));
    }    
}

Push — master ( ad9d2a...3a231c )

checkKlarnaOrderExistsByReservation() A

Complexity

Size

Duplication

Importance

1. Missing dependencies

2. Missing use statement

FATCHIP-GmbH / plugin-shopware5-klarna-checkout

Push — master ( ad9d2a...3a231c )

checkKlarnaOrderExistsByReservation() A

Complexity

Size

Duplication

Importance

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like
