lightConnector

Complexity

Total Complexity

7

Size/Duplication

Total Lines	108
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	setMethod()	0	3	1
A	setKlarnaOrderId()	0	3	1
A	setTransactionId()	0	3	1
A	updateCustomerAddress()	0	3	1
A	setCall()	0	15	2

<?php

/**
 * A lightweigt model for contacting Klarna API
 *
 * @author andre
 */
class lightConnector {

    /**
     * Connecting method
     * @var string
     */
    protected $method = null;

    /**
     * URI part for API calls
     * @var string
     */
    protected $uri = null;

    /**
     * Instance of shop configuration
     * @var object
     */
    protected $config = null;

    /**
     * Holds the klarna orderid 
     * @var string
     */
    protected $klarnaOrderId = null;

    /**
     * TransactionId of an existing order
     * @var string
     */
    protected $transactionId = null;
    
    protected $apiUrl = array('live'=>'https://api.klarna.com/','test'=>'https://api.playground.klarna.com/');

    /**
     * Creates an instance of light connector
     * 
     * @param type $config
     * @param type $method

Should the type for parameter $method not be type|null?

     */
    public function __construct($config, $method = null) {
        parent::__construct();
        $this->method = $method;

It seems like $method can also be of type object<type>. However, the property $method is declared as type string. Maybe add an additional type check?

        $this->config = $config;
    }

    /**
     * Sets method of requesting API
     * 
     * @param string $method
     * @return void
     */
    public function setMethod($method) {
        $this->method = $method;
    }

    /**
     * Sets klarna order id
     * 
     * @param string $klarnaOrderId
     * @return void
     */
    public function setKlarnaOrderId($klarnaOrderId) {
        $this->klarnaOrderId = $klarnaOrderId;
    }

    /**
     * Adds transactionId
     * 
     * @param string $transactionId
     */
    public function setTransactionId($transactionId) {
        $this->transactionId = $transactionId;
    }

    /**
     * Updates customer addresses
     * 
     * @param array $billingAddress
     * @param array $shippingAddress

Should the type for parameter $shippingAddress not be false|array?

     * @return void
     */
    public function updateCustomerAddress($billingAddress, $shippingAddress = false) {

The parameter $billingAddress is not used and could be removed.

The parameter $shippingAddress is not used and could be removed.

        $aAddressParts = array('');

$aAddressParts is not used, you could remove the assignment.

    }
    
    /**
     * Performs an API-Call
     * 
     * @param array $data
     */
    protected function setCall($data) {
        $testdrive = $this->config->get('testDrive');
        $url = ($testdrive) ? $this->apiUrl['test'] : $this->apiUrl['live'];
        
        $data = json_encode($data);
        $headers = array('Content-Type: application/json');
        $curl = curl_init();
        curl_setopt($curl, CURLOPT_URL, $url);
        curl_setopt($curl, CURLOPT_RETURNTRANSFER, 1);
        curl_setopt($curl, CURLOPT_CUSTOMREQUEST, $this->method);
        curl_setopt($curl, CURLOPT_POSTFIELDS, $data);
        curl_setopt($curl, CURLOPT_HTTPHEADER, $headers);
        $response = curl_exec($curl);

$response is not used, you could remove the assignment.

        curl_close($curl);        
    }

}