Issues in conftest.py (develop) - Issues in develop - FAForever/server - Measure and Improve Code Quality continuously with Scrutinizer

Issues (125)

tests/conftest.py (42 issues)

Labels

Severity

"""
This module is the 'top level' configuration for all the unit tests.

'Real world' fixtures are put here.
If a test suite needs specific mocked versions of dependencies,
these should be put in the ``conftest.py'' relative to it.
"""

import asyncio

import logging
import subprocess

import sys

from server.config import DB_SERVER, DB_LOGIN, DB_PORT, DB_PASSWORD

import pytest
from unittest import mock
from trueskill import Rating
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3

logging.getLogger().setLevel(logging.DEBUG)

import os



def async_test(f):
    def wrapper(*args, **kwargs):
        coro = asyncio.coroutine(f)
        future = coro(*args, **kwargs)
        loop = asyncio.get_event_loop()
param = 5

class Foo:
    def __init__(self, param):   # "param" would be flagged here
        self.param = param
        loop.run_until_complete(future)
    return wrapper


def pytest_pycollect_makeitem(collector, name, obj):
    if name.startswith('test_') and asyncio.iscoroutinefunction(obj):
        return list(collector._genfunctions(name, obj))
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent


def pytest_addoption(parser):
    parser.addoption('--noslow', action='store_true', default=False,
                     help="Don't run slow tests")
    parser.addoption('--aiodebug', action='store_true', default=False,
                     help='Enable asyncio debugging')
    parser.addoption('--mysql_host', action='store', default=DB_SERVER, help='mysql host to use for test database')
    parser.addoption('--mysql_username', action='store', default=DB_LOGIN, help='mysql username to use for test database')

    parser.addoption('--mysql_password', action='store', default=DB_PASSWORD, help='mysql password to use for test database')

    parser.addoption('--mysql_database', action='store', default='faf_test', help='mysql database to use for tests')
    parser.addoption('--mysql_port',     action='store', default=int(DB_PORT), help='mysql port to use for tests')


def pytest_configure(config):
    if config.getoption('--aiodebug'):
        logging.getLogger('quamash').setLevel(logging.DEBUG)
        logging.captureWarnings(True)
    else:
        logging.getLogger('quamash').setLevel(logging.INFO)


def pytest_runtest_setup(item):
    """
    Skip tests if they are marked slow, and --noslow is given on the commandline
    :param item:
    :return:
    """
    if getattr(item.obj, 'slow', None) and item.config.getvalue('noslow'):
        pytest.skip("slow test")

def pytest_pyfunc_call(pyfuncitem):
    testfn = pyfuncitem.obj

    if not asyncio.iscoroutinefunction(testfn):
        return

    funcargs = pyfuncitem.funcargs
    testargs = {}
    for arg in pyfuncitem._fixtureinfo.argnames:
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent
        testargs[arg] = funcargs[arg]
    loop = testargs.get('loop', asyncio.get_event_loop())
param = 5

class Foo:
    def __init__(self, param):   # "param" would be flagged here
        self.param = param
    loop.set_debug(True)
    coro = asyncio.wait_for(testfn(**testargs), 5)

    try:
        loop.run_until_complete(coro)
    except RuntimeError as err:
        logging.error(err)
        raise err
    return True

@pytest.fixture(scope='session', autouse=True)
def loop(request):

    import server
    server.stats = mock.MagicMock()
    return asyncio.get_event_loop()

@pytest.fixture
def sqlquery():
    query = mock.MagicMock()
    query.exec_ = lambda: 0
    query.size = lambda: 0
    query.lastInsertId = lambda: 1
    query.prepare = mock.MagicMock()
    query.addBindValue = lambda v: None
    return query

@pytest.fixture
def mock_db_pool(loop, db_pool, autouse=True):
param = 5

class Foo:
    def __init__(self, param):   # "param" would be flagged here
        self.param = param
    return db_pool

@pytest.fixture(scope='session')
def db_pool(request, loop):
param = 5

class Foo:
    def __init__(self, param):   # "param" would be flagged here
        self.param = param
    import server

    def opt(val):
        return request.config.getoption(val)
    host, user, pw, db, port = opt('--mysql_host'), opt('--mysql_username'), opt('--mysql_password'), opt('--mysql_database'), opt('--mysql_port')

    pool_fut = asyncio.async(server.db.connect(loop=loop,
                                               host=host,
                                               user=user,
                                               password=pw or None,
                                               port=port,
                                               db=db))
    pool = loop.run_until_complete(pool_fut)


    def fin():
        pool.close()
        loop.run_until_complete(pool.wait_closed())
    request.addfinalizer(fin)

    return pool

@pytest.fixture
def transport():
    return mock.Mock(spec=asyncio.Transport)

@pytest.fixture
def game(players):
param = 5

class Foo:
    def __init__(self, param):   # "param" would be flagged here
        self.param = param
    from server.games import Game
    from server.abc.base_game import InitMode
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
    mock_parent = mock.Mock()
    game = mock.create_autospec(spec=Game(1, mock_parent, mock.Mock()))
param = 5

class Foo:
    def __init__(self, param):   # "param" would be flagged here
        self.param = param
    players.hosting.getGame = mock.Mock(return_value=game)
    players.joining.getGame = mock.Mock(return_value=game)
    players.peer.getGame = mock.Mock(return_value=game)
    game.hostPlayer = players.hosting
    game.init_mode = InitMode.NORMAL_LOBBY
    game.name = "Some game name"
    game.id = 1
    return game

@pytest.fixture
def create_player():
    from server.players import Player, PlayerState
    def make(login='', id=0, port=6112, state=PlayerState.HOSTING, ip='127.0.0.1', global_rating=Rating(1500, 250), ladder_rating=Rating(1500, 250)):

        p = mock.create_autospec(spec=Player(login))
        p.global_rating = global_rating
        p.ladder_rating = ladder_rating
        p.ip = ip
        p.game_port = port
        p.state = state
        p.id = id
        p.login = login
        p.address_and_port = "{}:{}".format(ip, port)
        return p
    return make

@pytest.fixture
def players(create_player):
param = 5

class Foo:
    def __init__(self, param):   # "param" would be flagged here
        self.param = param
    from server.players import PlayerState
    return mock.Mock(
        hosting=create_player(login='Paula_Bean', id=1, port=6112, state=PlayerState.HOSTING),
        peer=create_player(login='That_Guy', id=2, port=6112, state=PlayerState.JOINING),
        joining=create_player(login='James_Kirk', id=3, port=6112, state=PlayerState.JOINING)
    )

@pytest.fixture
def player_service(loop, players, db_pool):
param = 5

class Foo:
    def __init__(self, param):   # "param" would be flagged here
        self.param = param
    from server import PlayerService
    return PlayerService(db_pool)

@pytest.fixture
def game_service(loop, player_service, game_stats_service):
param = 5

class Foo:
    def __init__(self, param):   # "param" would be flagged here
        self.param = param
    from server import GameService
    return GameService(player_service, game_stats_service)

@pytest.fixture
def api_accessor():
    from server.api.api_accessor import ApiAccessor
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
    return ApiAccessor()

@pytest.fixture
def event_service(api_accessor):
param = 5

class Foo:
    def __init__(self, param):   # "param" would be flagged here
        self.param = param
    from server.stats.event_service import EventService
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
    return EventService(api_accessor)

@pytest.fixture
def achievement_service(api_accessor):
param = 5

class Foo:
    def __init__(self, param):   # "param" would be flagged here
        self.param = param
    from server.stats.achievement_service import AchievementService
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
    return AchievementService(api_accessor)

@pytest.fixture
def game_stats_service(event_service, achievement_service):
param = 5

class Foo:
    def __init__(self, param):   # "param" would be flagged here
        self.param = param
    from server.stats.game_stats_service import GameStatsService
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
    return GameStatsService(event_service, achievement_service)


GitHub Access Token became invalid

Issues (125)

tests/conftest.py (42 issues)

Labels

Severity

Introduced By

1. Missing Dependencies

2. Missing init.py files

1. Missing Dependencies

2. Missing init.py files

1. Missing Dependencies

2. Missing init.py files

1. Missing Dependencies

2. Missing init.py files

1. Missing Dependencies

2. Missing init.py files

1. Missing Dependencies

2. Missing init.py files

1			"""
2			This module is the 'top level' configuration for all the unit tests.
3
4			'Real world' fixtures are put here.
5			If a test suite needs specific mocked versions of dependencies,
6			these should be put in the ``conftest.py'' relative to it.
7			"""
8
9			import asyncio
10
11			import logging
12			import subprocess
			0 ignored issues – show Unused Code introduced 2016-10-06 09:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this The import `subprocess` seems to be unused. Loading history...
13			import sys
			0 ignored issues – show Unused Code introduced 2015-11-21 11:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this The import `sys` seems to be unused. Loading history...
14			from server.config import DB_SERVER, DB_LOGIN, DB_PORT, DB_PASSWORD
15
16			import pytest
17			from unittest import mock
18			from trueskill import Rating
			0 ignored issues – show Configuration introduced 2015-11-21 11:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this The import `trueskill` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
19
20			logging.getLogger().setLevel(logging.DEBUG)
21
22			import os
			0 ignored issues – show Unused Code introduced 2015-11-21 11:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this The import `os` seems to be unused. Loading history...
23
24
25			def async_test(f):
26			def wrapper(args, *kwargs):
27			coro = asyncio.coroutine(f)
28			future = coro(args, *kwargs)
29			loop = asyncio.get_event_loop()
			0 ignored issues – show Comprehensibility Bug introduced 2016-02-04 22:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this `loop` is re-defining a name which is already available in the outer-scope (previously defined on line `90`). It is generally a bad practice to shadow variables from the outer-scope. In most cases, this is done unintentionally and might lead to unexpected behavior: param = 5 class Foo: def __init__(self, param): # "param" would be flagged here self.param = param Loading history...
30			loop.run_until_complete(future)
31			return wrapper
32
33
34			def pytest_pycollect_makeitem(collector, name, obj):
35			if name.startswith('test_') and asyncio.iscoroutinefunction(obj):

FAForever / server

GitHub Access Token became invalid

Issues (125)

tests/conftest.py (42 issues)

Labels

Severity

Introduced By

1. Missing Dependencies

2. Missing __init__.py files

1. Missing Dependencies

2. Missing __init__.py files

1. Missing Dependencies

2. Missing __init__.py files

1. Missing Dependencies

2. Missing __init__.py files

1. Missing Dependencies

2. Missing __init__.py files

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

2. Missing init.py files

2. Missing init.py files

2. Missing init.py files

2. Missing init.py files

2. Missing init.py files

2. Missing init.py files