add_connected_players() - Code Metrics - Inspection of "Renamed duplicate fixture game_connection to mock_..." - FAForever/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( e04e53...67d2ce )

by Michael

created 2016-05-30 14:32 UTC

add_connected_players() A

↳ Parent: Project

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
c	1
b	0
f	0
dl	0
loc	12
rs	9.4285

from unittest import mock
import pytest

from server import GameStatsService, LobbyConnection
from server.games import Game
from server.gameconnection import GameConnection, GameConnectionState
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
from tests import CoroMock

@pytest.fixture()
def lobbythread():
    return mock.Mock(
        sendJSON=lambda obj: None
    )



@pytest.fixture
def game_connection(request, game, loop, player_service, players, game_service, transport):
    from server import GameConnection, LobbyConnection
param = 5

class Foo:
    def __init__(self, param):   # "param" would be flagged here
        self.param = param
    conn = GameConnection(loop=loop,
                          lobby_connection=mock.create_autospec(LobbyConnection(loop)),
                          player_service=player_service,
                          games=game_service)
    conn._transport = transport
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent
    conn.player = players.hosting
    conn.game = game
    conn.lobby = mock.Mock(spec=LobbyConnection)

    def fin():
        conn.abort()

    request.addfinalizer(fin)
    return conn



@pytest.fixture
def mock_game_connection(state=GameConnectionState.INITIALIZING, player=None):
    gc = mock.create_autospec(spec=GameConnection)
    gc.state = state
    gc.player = player
    return gc


@pytest.fixture()
def game_stats_service():
    service = mock.Mock(spec=GameStatsService)
    service.process_game_stats = CoroMock()
    return service


@pytest.fixture
def connections(loop, player_service, game_service, transport, game):
    from server import GameConnection
param = 5

class Foo:
    def __init__(self, param):   # "param" would be flagged here
        self.param = param

    def make_connection(player, connectivity):
        lc = LobbyConnection(loop)
        lc.protocol = mock.Mock()
        conn = GameConnection(loop=loop,
                              lobby_connection=lc,
                              player_service=player_service,
                              games=game_service)
        conn.player = player
        conn.game = game
        conn._transport = transport
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent
        conn._connectivity_state.set_result(connectivity)
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent
        return conn

    return mock.Mock(
        make_connection=make_connection
    )

def add_connected_player(game: Game, player):
    game.game_service.player_service[player.id] = player
    gc = mock_game_connection(state=GameConnectionState.CONNECTED_TO_HOST, player=player)
    game.set_player_option(player.id, 'Army', 0)
    game.set_player_option(player.id, 'StartSpot', 0)
    game.set_player_option(player.id, 'Team', 0)
    game.set_player_option(player.id, 'Faction', 0)
    game.set_player_option(player.id, 'Color', 0)
    game.add_game_connection(gc)
    return gc


def add_connected_players(game: Game, players):
    """
    Utility to add players with army and StartSpot indexed by a list
    """
    for army, player in enumerate(players):
        add_connected_player(game, player)
        game.set_player_option(player.id, 'Army', army)
        game.set_player_option(player.id, 'StartSpot', army)
        game.set_player_option(player.id, 'Team', army)
        game.set_player_option(player.id, 'Faction', 0)
        game.set_player_option(player.id, 'Color', 0)
    game.host = players[0]



GitHub Access Token became invalid

Push — develop ( e04e53...67d2ce )

add_connected_players() A

Complexity

Size

Duplication

Importance

1. Missing Dependencies

2. Missing init.py files

1		from unittest import mock
2		import pytest
3
4		from server import GameStatsService, LobbyConnection
5		from server.games import Game
6		from server.gameconnection import GameConnection, GameConnectionState
		0 ignored issues – show Bug introduced 2016-05-30 12:26 UTC by Report Bug Copy Issue Report The name `gameconnection` does not seem to exist in module `server`. Loading history... Configuration introduced 2016-05-30 12:26 UTC by Report Bug Copy Issue Report Unable to import 'server.gameconnection' (invalid syntax (<string>, line 94)) This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
7		from tests import CoroMock
8
9		@pytest.fixture()
10		def lobbythread():
11		return mock.Mock(
12		sendJSON=lambda obj: None
13		)
14
15	View Code Duplication
		0 ignored issues – show Duplication introduced 2016-05-04 07:07 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
16		@pytest.fixture
17		def game_connection(request, game, loop, player_service, players, game_service, transport):
18		from server import GameConnection, LobbyConnection
		0 ignored issues – show Comprehensibility Bug introduced 2016-02-04 22:55 UTC by Report Bug Copy Issue Report `LobbyConnection` is re-defining a name which is already available in the outer-scope (previously defined on line `4`). It is generally a bad practice to shadow variables from the outer-scope. In most cases, this is done unintentionally and might lead to unexpected behavior: param = 5 class Foo: def __init__(self, param): # "param" would be flagged here self.param = param Loading history... Unused Code introduced 2016-02-04 22:55 UTC by Report Bug Copy Issue Report The import `LobbyConnection` was already done on line 4. You should be able to remove this line. Loading history... Comprehensibility Bug introduced 2016-05-30 12:26 UTC by Report Bug Copy Issue Report `GameConnection` is re-defining a name which is already available in the outer-scope (previously defined on line `6`). It is generally a bad practice to shadow variables from the outer-scope. In most cases, this is done unintentionally and might lead to unexpected behavior: param = 5 class Foo: def __init__(self, param): # "param" would be flagged here self.param = param Loading history...
19		conn = GameConnection(loop=loop,
20		lobby_connection=mock.create_autospec(LobbyConnection(loop)),
21		player_service=player_service,
22		games=game_service)
23		conn._transport = transport
		0 ignored issues – show Coding Style Best Practice introduced 2015-11-30 14:13 UTC by Report Bug Copy Issue Report It seems like `_transport` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
24		conn.player = players.hosting
25		conn.game = game
26		conn.lobby = mock.Mock(spec=LobbyConnection)
27
28		def fin():
29		conn.abort()
30
31		request.addfinalizer(fin)
32		return conn
33
34	View Code Duplication
		0 ignored issues – show Duplication introduced 2016-05-04 07:07 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
35		@pytest.fixture
36		def mock_game_connection(state=GameConnectionState.INITIALIZING, player=None):
37		gc = mock.create_autospec(spec=GameConnection)
38		gc.state = state
39		gc.player = player
40		return gc
41
42
43		@pytest.fixture()
44		def game_stats_service():
45		service = mock.Mock(spec=GameStatsService)
46		service.process_game_stats = CoroMock()
47		return service
48
49
50		@pytest.fixture
51		def connections(loop, player_service, game_service, transport, game):
52		from server import GameConnection
		0 ignored issues – show Comprehensibility Bug introduced 2016-05-30 12:26 UTC by Report Bug Copy Issue Report `GameConnection` is re-defining a name which is already available in the outer-scope (previously defined on line `6`). It is generally a bad practice to shadow variables from the outer-scope. In most cases, this is done unintentionally and might lead to unexpected behavior: param = 5 class Foo: def __init__(self, param): # "param" would be flagged here self.param = param Loading history...
53
54		def make_connection(player, connectivity):
55		lc = LobbyConnection(loop)
56		lc.protocol = mock.Mock()
57		conn = GameConnection(loop=loop,
58		lobby_connection=lc,
59		player_service=player_service,
60		games=game_service)
61		conn.player = player
62		conn.game = game
63		conn._transport = transport
		0 ignored issues – show Coding Style Best Practice introduced 2015-11-30 14:13 UTC by Report Bug Copy Issue Report It seems like `_transport` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
64		conn._connectivity_state.set_result(connectivity)
		0 ignored issues – show Coding Style Best Practice introduced 2015-11-21 11:08 UTC by Report Bug Copy Issue Report It seems like `_connectivity_state` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
65		return conn
66
67		return mock.Mock(
68		make_connection=make_connection
69		)
70
71		def add_connected_player(game: Game, player):
72		game.game_service.player_service[player.id] = player
73		gc = mock_game_connection(state=GameConnectionState.CONNECTED_TO_HOST, player=player)
74		game.set_player_option(player.id, 'Army', 0)
75		game.set_player_option(player.id, 'StartSpot', 0)
76		game.set_player_option(player.id, 'Team', 0)
77		game.set_player_option(player.id, 'Faction', 0)
78		game.set_player_option(player.id, 'Color', 0)
79		game.add_game_connection(gc)
80		return gc
81
82
83		def add_connected_players(game: Game, players):
84		"""
85		Utility to add players with army and StartSpot indexed by a list
86		"""
87		for army, player in enumerate(players):
88		add_connected_player(game, player)
89		game.set_player_option(player.id, 'Army', army)
90		game.set_player_option(player.id, 'StartSpot', army)
91		game.set_player_option(player.id, 'Team', army)
92		game.set_player_option(player.id, 'Faction', 0)
93		game.set_player_option(player.id, 'Color', 0)
94		game.host = players[0]
95
96

FAForever / server

GitHub Access Token became invalid

Push — develop ( e04e53...67d2ce )

add_connected_players() A

Complexity

Size

Duplication

Importance

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

2. Missing init.py files