ConnectionThrottler.__init__() - Code Metrics - Inspection of "Add connection attempt throttling" - FAForever/server - Measure and Improve Code Quality continuously with Scrutinizer

server

Completed

Pull Request — develop (#334)

unknown

created 2018-01-14 12:02 UTC

ConnectionThrottler.init() A

↳ Parent: ConnectionThrottler

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
dl	0
loc	3
rs	10
c	0
b	0
f	0

from datetime import datetime, timedelta

CONN_ATTEMPTS = 10
CONN_TIME = timedelta(minutes=1)

class ConnectionThrottler:
    """Simple Connection throttler to limit bruteforce attacks

    Records the number of connection attempts from remote hosts in a specified
    timespan, allowing to deny connections if there have been too many
    """
    def __init__(self):
        self.conn_attempts = {}
        self.ts = datetime.now()

    def attempt(self, ip):
        """Record a connection attempt

        Returns True if number of recorded attempts smaller than allowed number,
        False otherwise
        """
        # Check for time window rollover
        now = datetime.now()
        if now - self.ts > CONN_TIME:
            # Reset everything if we're rolled over
            self.conn_attempts = {}
            self.ts = now

        self.conn_attempts[ip] = self.conn_attempts.get(ip, 0) + 1

        return self.conn_attempts[ip] <= CONN_ATTEMPTS


1			from datetime import datetime, timedelta
2
3			CONN_ATTEMPTS = 10
4			CONN_TIME = timedelta(minutes=1)
5
6			class ConnectionThrottler:
7			"""Simple Connection throttler to limit bruteforce attacks
8
9			Records the number of connection attempts from remote hosts in a specified
10			timespan, allowing to deny connections if there have been too many
11			"""
12			def __init__(self):
13			self.conn_attempts = {}
14			self.ts = datetime.now()
15
16			def attempt(self, ip):
17			"""Record a connection attempt
18
19			Returns True if number of recorded attempts smaller than allowed number,
20			False otherwise
21			"""
22			# Check for time window rollover
23			now = datetime.now()
24			if now - self.ts > CONN_TIME:
25			# Reset everything if we're rolled over
26			self.conn_attempts = {}
27			self.ts = now
28
29			self.conn_attempts[ip] = self.conn_attempts.get(ip, 0) + 1
30
31			return self.conn_attempts[ip] <= CONN_ATTEMPTS
32

FAForever / server

GitHub Access Token became invalid

Pull Request — develop (#334)

ConnectionThrottler.__init__() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

ConnectionThrottler.init() A