custom_game() - Code Metrics - Inspection of "Bugfix/#255 stats bug" - FAForever/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#257)

unknown

created 2016-12-17 13:24 UTC

custom_game() A

↳ Parent: Project

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
dl	0
loc	5
rs	9.4285
c	0
b	0
f	0

import pytest
from server.games.game import Game
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
from server.games.custom_game import CustomGame
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3

@pytest.yield_fixture
def game(loop, game_service, game_stats_service):
    game = Game(42, game_service, game_stats_service)
param = 5

class Foo:
    def __init__(self, param):   # "param" would be flagged here
        self.param = param
    yield game
    loop.run_until_complete(game.clear_data())

@pytest.yield_fixture
def custom_game(loop, game_service, game_stats_service):
    game = CustomGame(42, game_service, game_stats_service)
param = 5

class Foo:
    def __init__(self, param):   # "param" would be flagged here
        self.param = param
    yield game
    loop.run_until_complete(game.clear_data())



GitHub Access Token became invalid

Pull Request — develop (#257)

custom_game() A

Complexity

Size

Duplication

Importance

1. Missing Dependencies

2. Missing init.py files

1. Missing Dependencies

2. Missing init.py files

1			import pytest
2			from server.games.game import Game
			0 ignored issues – show Bug introduced 2016-12-17 13:20 UTC by Report Bug Copy Issue Report The name `game` does not seem to exist in module `server.games`. Loading history... Configuration introduced 2016-12-17 13:20 UTC by Report Bug Copy Issue Report Unable to import 'server.games.game' (invalid syntax (<string>, line 145)) This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
3			from server.games.custom_game import CustomGame
			0 ignored issues – show Bug introduced 2016-12-17 13:20 UTC by Report Bug Copy Issue Report The name `custom_game` does not seem to exist in module `server.games`. Loading history... Configuration introduced 2016-12-17 13:20 UTC by Report Bug Copy Issue Report Unable to import 'server.games.custom_game' (invalid syntax (<string>, line 12)) This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
4
5			@pytest.yield_fixture
6			def game(loop, game_service, game_stats_service):
7			game = Game(42, game_service, game_stats_service)
			0 ignored issues – show Comprehensibility Bug introduced 2016-12-17 13:20 UTC by Report Bug Copy Issue Report `game` is re-defining a name which is already available in the outer-scope (previously defined on line `6`). It is generally a bad practice to shadow variables from the outer-scope. In most cases, this is done unintentionally and might lead to unexpected behavior: param = 5 class Foo: def __init__(self, param): # "param" would be flagged here self.param = param Loading history...
8			yield game
9			loop.run_until_complete(game.clear_data())
10
11			@pytest.yield_fixture
12			def custom_game(loop, game_service, game_stats_service):
13			game = CustomGame(42, game_service, game_stats_service)
			0 ignored issues – show Comprehensibility Bug introduced 2016-12-17 13:20 UTC by Report Bug Copy Issue Report `game` is re-defining a name which is already available in the outer-scope (previously defined on line `6`). It is generally a bad practice to shadow variables from the outer-scope. In most cases, this is done unintentionally and might lead to unexpected behavior: param = 5 class Foo: def __init__(self, param): # "param" would be flagged here self.param = param Loading history...
14			yield game
15			loop.run_until_complete(game.clear_data())
16
17

FAForever / server

GitHub Access Token became invalid

Pull Request — develop (#257)

custom_game() A

Complexity

Size

Duplication

Importance

1. Missing Dependencies

2. Missing __init__.py files

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

2. Missing init.py files

2. Missing init.py files