test_all_games() - Code Metrics - Inspection of "Merge branch 'release/v0.2'" - FAForever/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0254c9...47ea54 )

unknown

created 2016-05-27 14:13 UTC

test_all_games() A

↳ Parent: Project

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0

import pytest

import server

from server.game_service import GameService
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
from server.games.game import VisibilityState
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
from server.players import PlayerState


@pytest.fixture
def service(players, game_stats_service):
    return GameService(players, game_stats_service)


def test_initialization(service):
param = 5

class Foo:
    def __init__(self, param):   # "param" would be flagged here
        self.param = param
    assert len(service.dirty_games) == 0


def test_create_game(players, service):
param = 5

class Foo:
    def __init__(self, param):   # "param" would be flagged here
        self.param = param
    players.hosting.state = PlayerState.IDLE
    game = service.create_game(visibility=VisibilityState.PUBLIC,
                               game_mode='faf',
                               host=players.hosting,
                               name='Test',
                               mapname='SCMP_007',
                               password=None)
    assert game is not None
    assert game in service.dirty_games


def test_all_games(players, service):
param = 5

class Foo:
    def __init__(self, param):   # "param" would be flagged here
        self.param = param
    game = service.create_game(visibility=VisibilityState.PUBLIC,
                               game_mode='faf',
                               host=players.hosting,
                               name='Test',
                               mapname='SCMP_007',
                               password=None)
    assert game in service.pending_games


GitHub Access Token became invalid

Push — master ( 0254c9...47ea54 )

test_all_games() A

Complexity

Size

Duplication

Importance

1. Missing Dependencies

2. Missing init.py files

1. Missing Dependencies

2. Missing init.py files

1			import pytest
2
3			import server
			0 ignored issues – show Unused Code introduced 2015-11-21 11:08 UTC by Report Bug Copy Issue Report The import `server` seems to be unused. Loading history...
4			from server.game_service import GameService
			0 ignored issues – show Bug introduced 2015-11-21 11:08 UTC by Report Bug Copy Issue Report The name `game_service` does not seem to exist in module `server`. Loading history... Configuration introduced 2016-03-03 02:28 UTC by Report Bug Copy Issue Report Unable to import 'server.game_service' (invalid syntax (<string>, line 53)) This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
5			from server.games.game import VisibilityState
			0 ignored issues – show Bug introduced 2015-11-21 11:08 UTC by Report Bug Copy Issue Report The name `game` does not seem to exist in module `server.games`. Loading history... Configuration introduced 2016-03-28 13:22 UTC by Report Bug Copy Issue Report Unable to import 'server.games.game' (invalid syntax (<string>, line 187)) This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
6			from server.players import PlayerState
7
8
9			@pytest.fixture
10			def service(players, game_stats_service):
11			return GameService(players, game_stats_service)
12
13
14			def test_initialization(service):
			0 ignored issues – show Comprehensibility Bug introduced 2016-02-04 22:55 UTC by Report Bug Copy Issue Report `service` is re-defining a name which is already available in the outer-scope (previously defined on line `10`). It is generally a bad practice to shadow variables from the outer-scope. In most cases, this is done unintentionally and might lead to unexpected behavior: param = 5 class Foo: def __init__(self, param): # "param" would be flagged here self.param = param Loading history...
15			assert len(service.dirty_games) == 0
16
17
18			def test_create_game(players, service):
			0 ignored issues – show Comprehensibility Bug introduced 2016-02-04 22:55 UTC by Report Bug Copy Issue Report `service` is re-defining a name which is already available in the outer-scope (previously defined on line `10`). It is generally a bad practice to shadow variables from the outer-scope. In most cases, this is done unintentionally and might lead to unexpected behavior: param = 5 class Foo: def __init__(self, param): # "param" would be flagged here self.param = param Loading history...
19			players.hosting.state = PlayerState.IDLE
20			game = service.create_game(visibility=VisibilityState.PUBLIC,
21			game_mode='faf',
22			host=players.hosting,
23			name='Test',
24			mapname='SCMP_007',
25			password=None)
26			assert game is not None
27			assert game in service.dirty_games
28
29
30			def test_all_games(players, service):
			0 ignored issues – show Comprehensibility Bug introduced 2016-02-04 22:55 UTC by Report Bug Copy Issue Report `service` is re-defining a name which is already available in the outer-scope (previously defined on line `10`). It is generally a bad practice to shadow variables from the outer-scope. In most cases, this is done unintentionally and might lead to unexpected behavior: param = 5 class Foo: def __init__(self, param): # "param" would be flagged here self.param = param Loading history...
31			game = service.create_game(visibility=VisibilityState.PUBLIC,
32			game_mode='faf',
33			host=players.hosting,
34			name='Test',
35			mapname='SCMP_007',
36			password=None)
37			assert game in service.pending_games
38

FAForever / server

GitHub Access Token became invalid

Push — master ( 0254c9...47ea54 )

test_all_games() A

Complexity

Size

Duplication

Importance

1. Missing Dependencies

2. Missing __init__.py files

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

2. Missing init.py files

2. Missing init.py files