game_connection() - Code Metrics - Inspection of "Merge branch 'release/v0.2'" - FAForever/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0254c9...47ea54 )

unknown

created 2016-05-27 14:13 UTC

game_connection() A

↳ Parent: Project

Complexity

Conditions

Size

Total Lines

Duplication

Lines	17
Ratio	100 %

Importance

Changes

Metric	Value
cc	2
dl	17
loc	17
rs	9.4285
c	0
b	0
f	0

import asyncio

from unittest import mock
import pytest

from server import LobbyConnection


@pytest.fixture()
def lobbythread():
    return mock.Mock(
        sendJSON=lambda obj: None
    )


@pytest.fixture

def game_connection(request, game, loop, player_service, players, game_service, transport):
    from server import GameConnection, LobbyConnection
param = 5

class Foo:
    def __init__(self, param):   # "param" would be flagged here
        self.param = param
    conn = GameConnection(loop=loop,
                          lobby_connection=mock.create_autospec(LobbyConnection(loop)),
                          player_service=player_service,
                          games=game_service)
    conn._transport = transport
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent
    conn.player = players.hosting
    conn.game = game
    conn.lobby = mock.Mock(spec=LobbyConnection)

    def fin():
        conn.abort()

    request.addfinalizer(fin)
    return conn


@pytest.fixture

def connections(loop, player_service, game_service, transport, game):
    from server import GameConnection

    def make_connection(player, connectivity):
        lc = LobbyConnection(loop)
        lc.protocol = mock.Mock()
        conn = GameConnection(loop=loop,
                              lobby_connection=lc,
                              player_service=player_service,
                              games=game_service)
        conn.player = player
        conn.game = game
        conn._transport = transport
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent
        conn._connectivity_state.set_result(connectivity)
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent
        return conn

    return mock.Mock(
        make_connection=make_connection
    )


1		import asyncio
		0 ignored issues – show Unused Code introduced 2015-11-30 14:13 UTC by Report Bug Copy Issue Report The import `asyncio` seems to be unused. Loading history...
2		from unittest import mock
3		import pytest
4
5		from server import LobbyConnection
6
7
8		@pytest.fixture()
9		def lobbythread():
10		return mock.Mock(
11		sendJSON=lambda obj: None
12		)
13
14
15	View Code Duplication	@pytest.fixture
		0 ignored issues – show Duplication introduced 2016-05-04 07:07 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
16		def game_connection(request, game, loop, player_service, players, game_service, transport):
17		from server import GameConnection, LobbyConnection
		0 ignored issues – show Comprehensibility Bug introduced 2016-02-04 22:55 UTC by Report Bug Copy Issue Report `LobbyConnection` is re-defining a name which is already available in the outer-scope (previously defined on line `5`). It is generally a bad practice to shadow variables from the outer-scope. In most cases, this is done unintentionally and might lead to unexpected behavior: param = 5 class Foo: def __init__(self, param): # "param" would be flagged here self.param = param Loading history... Unused Code introduced 2016-02-04 22:55 UTC by Report Bug Copy Issue Report The import `LobbyConnection` was already done on line 5. You should be able to remove this line. Loading history...
18		conn = GameConnection(loop=loop,
19		lobby_connection=mock.create_autospec(LobbyConnection(loop)),
20		player_service=player_service,
21		games=game_service)
22		conn._transport = transport
		0 ignored issues – show Coding Style Best Practice introduced 2015-11-30 14:13 UTC by Report Bug Copy Issue Report It seems like `_transport` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
23		conn.player = players.hosting
24		conn.game = game
25		conn.lobby = mock.Mock(spec=LobbyConnection)
26
27		def fin():
28		conn.abort()
29
30		request.addfinalizer(fin)
31		return conn
32
33
34	View Code Duplication	@pytest.fixture
		0 ignored issues – show Duplication introduced 2016-05-04 07:07 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
35		def connections(loop, player_service, game_service, transport, game):
36		from server import GameConnection
37
38		def make_connection(player, connectivity):
39		lc = LobbyConnection(loop)
40		lc.protocol = mock.Mock()
41		conn = GameConnection(loop=loop,
42		lobby_connection=lc,
43		player_service=player_service,
44		games=game_service)
45		conn.player = player
46		conn.game = game
47		conn._transport = transport
		0 ignored issues – show Coding Style Best Practice introduced 2015-11-30 14:13 UTC by Report Bug Copy Issue Report It seems like `_transport` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
48		conn._connectivity_state.set_result(connectivity)
		0 ignored issues – show Coding Style Best Practice introduced 2015-11-21 11:08 UTC by Report Bug Copy Issue Report It seems like `_connectivity_state` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
49		return conn
50
51		return mock.Mock(
52		make_connection=make_connection
53		)
54

FAForever / server

GitHub Access Token became invalid

Push — master ( 0254c9...47ea54 )

game_connection() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like