map_pool() - Code Metrics - Inspection of "Brute force" - FAForever/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bc5271...0254c9 )

by Michael

created 2016-05-12 11:28 UTC

map_pool() A

↳ Parent: Project

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Metric	Value
cc	1
dl	0
loc	3
rs	10

from unittest import mock


import pytest

from server import LadderService
from server.players import Player


@pytest.fixture()
def map_pool():
    return [(1, '', 'scmp_001'), (5, '', 'scmp_05'), (10, '', 'scmp_010'), (12, '', 'scmp_012'), (11, '', 'scmp_0011')]

def playerMock(lobbythread, id):

    player_mock = mock.create_autospec(spec=Player(''))
    player_mock.login = "Player %s" % id
    player_mock.id = id
    player_mock.game_port = 4242
    player_mock.lobby_connection = lobbythread
    return player_mock


@pytest.fixture()
def player1(lobbythread):
    return playerMock(lobbythread, 1)


@pytest.fixture()
def player2(lobbythread):
    return playerMock(lobbythread, 2)


@pytest.fixture()
def ladder_setup(player1, player2, map_pool):
param = 5

class Foo:
    def __init__(self, param):   # "param" would be flagged here
        self.param = param
    return {
        'player1': player1,
        'player2': player2,
        'map_pool': map_pool
    }

@pytest.fixture()
def ladder_service(game_service, game_stats_service):
    return LadderService(game_service, game_stats_service)


1			from unittest import mock
2
3
4			import pytest
5
6			from server import LadderService
7			from server.players import Player
8
9
10			@pytest.fixture()
11			def map_pool():
12			return [(1, '', 'scmp_001'), (5, '', 'scmp_05'), (10, '', 'scmp_010'), (12, '', 'scmp_012'), (11, '', 'scmp_0011')]
13
14			def playerMock(lobbythread, id):
			0 ignored issues – show Bug Best Practice introduced 2015-11-21 11:08 UTC by Report Bug Copy Issue Report This seems to re-define the built-in `id`. It is generally discouraged to redefine built-ins as this makes code very hard to read. Loading history...
15			player_mock = mock.create_autospec(spec=Player(''))
16			player_mock.login = "Player %s" % id
17			player_mock.id = id
18			player_mock.game_port = 4242
19			player_mock.lobby_connection = lobbythread
20			return player_mock
21
22
23			@pytest.fixture()
24			def player1(lobbythread):
25			return playerMock(lobbythread, 1)
26
27
28			@pytest.fixture()
29			def player2(lobbythread):
30			return playerMock(lobbythread, 2)
31
32
33			@pytest.fixture()
34			def ladder_setup(player1, player2, map_pool):
			0 ignored issues – show Comprehensibility Bug introduced 2016-02-04 22:55 UTC by Report Bug Copy Issue Report `map_pool` is re-defining a name which is already available in the outer-scope (previously defined on line `11`). It is generally a bad practice to shadow variables from the outer-scope. In most cases, this is done unintentionally and might lead to unexpected behavior: param = 5 class Foo: def __init__(self, param): # "param" would be flagged here self.param = param Loading history... Comprehensibility Bug introduced 2016-02-04 22:55 UTC by Report Bug Copy Issue Report `player1` is re-defining a name which is already available in the outer-scope (previously defined on line `24`). It is generally a bad practice to shadow variables from the outer-scope. In most cases, this is done unintentionally and might lead to unexpected behavior: param = 5 class Foo: def __init__(self, param): # "param" would be flagged here self.param = param Loading history... Comprehensibility Bug introduced 2016-02-04 22:55 UTC by Report Bug Copy Issue Report `player2` is re-defining a name which is already available in the outer-scope (previously defined on line `29`). It is generally a bad practice to shadow variables from the outer-scope. In most cases, this is done unintentionally and might lead to unexpected behavior: param = 5 class Foo: def __init__(self, param): # "param" would be flagged here self.param = param Loading history...
35			return {
36			'player1': player1,
37			'player2': player2,
38			'map_pool': map_pool
39			}
40
41			@pytest.fixture()
42			def ladder_service(game_service, game_stats_service):
43			return LadderService(game_service, game_stats_service)
44

FAForever / server

GitHub Access Token became invalid

Push — master ( bc5271...0254c9 )

map_pool() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like