Issues in conftest.py - New Issues - Inspection of "Merge branch 'release/v0.4'" - FAForever/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 93c974...359a3c )

unknown

created 2016-10-10 06:40 UTC

tests/unit_tests/conftest.py (1 issue)

Labels

Severity

Major 1

from unittest import mock
import pytest

from server import GameStatsService, LobbyConnection
from server.games import Game
from server.gameconnection import GameConnection, GameConnectionState
from tests import CoroMock

@pytest.fixture()
def lobbythread():
    return mock.Mock(
        sendJSON=lambda obj: None
    )

@pytest.fixture
def game_connection(request, game, loop, player_service, players, game_service, transport):
    from server import GameConnection, LobbyConnection
    conn = GameConnection(loop=loop,
                          lobby_connection=mock.create_autospec(LobbyConnection(loop)),
                          player_service=player_service,
                          games=game_service)
    conn._transport = transport
    conn.player = players.hosting
    conn.game = game
    conn.lobby = mock.Mock(spec=LobbyConnection)

    def fin():
        conn.abort()

    request.addfinalizer(fin)
    return conn


@pytest.fixture
def mock_game_connection(state=GameConnectionState.INITIALIZING, player=None):
    gc = mock.create_autospec(spec=GameConnection)
    gc.state = state
    gc.player = player
    return gc


@pytest.fixture()
def game_stats_service():
    service = mock.Mock(spec=GameStatsService)
    service.process_game_stats = CoroMock()
    return service


@pytest.fixture
def connections(loop, player_service, game_service, transport, game):
    from server import GameConnection

    def make_connection(player, connectivity):
        lc = LobbyConnection(loop)
        lc.protocol = mock.Mock()
        conn = GameConnection(loop=loop,
                              lobby_connection=lc,
                              player_service=player_service,
                              games=game_service)
        conn.player = player
        conn.game = game
        conn._transport = transport
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent
        conn._connectivity_state.set_result(connectivity)
        return conn

    return mock.Mock(
        make_connection=make_connection
    )

def add_connected_player(game: Game, player):
    game.game_service.player_service[player.id] = player
    gc = mock_game_connection(state=GameConnectionState.CONNECTED_TO_HOST, player=player)
    game.set_player_option(player.id, 'Army', 0)
    game.set_player_option(player.id, 'StartSpot', 0)
    game.set_player_option(player.id, 'Team', 0)
    game.set_player_option(player.id, 'Faction', 0)
    game.set_player_option(player.id, 'Color', 0)
    game.add_game_connection(gc)
    return gc


def add_connected_players(game: Game, players):
    """
    Utility to add players with army and StartSpot indexed by a list
    """
    for army, player in enumerate(players):
        add_connected_player(game, player)
        game.set_player_option(player.id, 'Army', army)
        game.set_player_option(player.id, 'StartSpot', army)
        game.set_player_option(player.id, 'Team', army)
        game.set_player_option(player.id, 'Faction', 0)
        game.set_player_option(player.id, 'Color', 0)
    game.host = players[0]



GitHub Access Token became invalid

Push — master ( 93c974...359a3c )

tests/unit_tests/conftest.py (1 issue)

Labels

Severity

Introduced By

1		from unittest import mock
2		import pytest
3
4		from server import GameStatsService, LobbyConnection
5		from server.games import Game
6		from server.gameconnection import GameConnection, GameConnectionState
7		from tests import CoroMock
8
9		@pytest.fixture()
10		def lobbythread():
11		return mock.Mock(
12		sendJSON=lambda obj: None
13		)
14
15	View Code Duplication	@pytest.fixture
16		def game_connection(request, game, loop, player_service, players, game_service, transport):
17		from server import GameConnection, LobbyConnection
18		conn = GameConnection(loop=loop,
19		lobby_connection=mock.create_autospec(LobbyConnection(loop)),
20		player_service=player_service,
21		games=game_service)
22		conn._transport = transport
23		conn.player = players.hosting
24		conn.game = game
25		conn.lobby = mock.Mock(spec=LobbyConnection)
26
27		def fin():
28		conn.abort()
29
30		request.addfinalizer(fin)
31		return conn
32
33
34	View Code Duplication	@pytest.fixture
35		def mock_game_connection(state=GameConnectionState.INITIALIZING, player=None):
36		gc = mock.create_autospec(spec=GameConnection)
37		gc.state = state
38		gc.player = player
39		return gc
40
41
42		@pytest.fixture()
43		def game_stats_service():
44		service = mock.Mock(spec=GameStatsService)
45		service.process_game_stats = CoroMock()
46		return service
47
48
49		@pytest.fixture
50		def connections(loop, player_service, game_service, transport, game):
51		from server import GameConnection
52
53		def make_connection(player, connectivity):
54		lc = LobbyConnection(loop)
55		lc.protocol = mock.Mock()
56		conn = GameConnection(loop=loop,
57		lobby_connection=lc,
58		player_service=player_service,
59		games=game_service)
60		conn.player = player
61		conn.game = game
62		conn._transport = transport
		0 ignored issues – show Coding Style Best Practice introduced 2016-10-05 12:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `_transport` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
63		conn._connectivity_state.set_result(connectivity)
64		return conn
65
66		return mock.Mock(
67		make_connection=make_connection
68		)
69
70		def add_connected_player(game: Game, player):
71		game.game_service.player_service[player.id] = player
72		gc = mock_game_connection(state=GameConnectionState.CONNECTED_TO_HOST, player=player)
73		game.set_player_option(player.id, 'Army', 0)
74		game.set_player_option(player.id, 'StartSpot', 0)
75		game.set_player_option(player.id, 'Team', 0)
76		game.set_player_option(player.id, 'Faction', 0)
77		game.set_player_option(player.id, 'Color', 0)
78		game.add_game_connection(gc)
79		return gc
80
81
82		def add_connected_players(game: Game, players):
83		"""
84		Utility to add players with army and StartSpot indexed by a list
85		"""
86		for army, player in enumerate(players):
87		add_connected_player(game, player)
88		game.set_player_option(player.id, 'Army', army)
89		game.set_player_option(player.id, 'StartSpot', army)
90		game.set_player_option(player.id, 'Team', army)
91		game.set_player_option(player.id, 'Faction', 0)
92		game.set_player_option(player.id, 'Color', 0)
93		game.host = players[0]
94
95

FAForever / server

GitHub Access Token became invalid

Push — master ( 93c974...359a3c )

tests/unit_tests/conftest.py (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like