server.Player.__init__() - Code Metrics - Inspection of "Ensure ladder/global is never set to None" - FAForever/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 83a854...4f119b )

by Michael

created 2016-02-03 22:37 UTC

server.Player.init() C

↳ Parent: server.Player

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Metric	Value
cc	7
dl	0
loc	42
rs	5.5

import weakref

from enum import IntEnum, unique

from .abc.base_player import BasePlayer
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3

@unique
class PlayerState(IntEnum):
    IDLE = 1,
    PLAYING = 2,
    HOSTING = 3,
    JOINING = 4,
    SEARCHING_LADDER = 5,

class Player(BasePlayer):
    """
    Standard player object used for representing signed-in players.

    In the context of a game, the Game object holds game-specific
    information about players.
    """
    def __init__(self, login=None, session=0, ip=None, port=None, id=0,

                 global_rating=None, ladder_rating=None, clan=None, numGames=0, permissionGroup=0, lobby_connection=None):

        super().__init__(id, login)

        # The id of the user in the `login` table of the database.
        self.session = session
        self.ip = ip
        self._game_port = port

        if global_rating is None:
            global_rating = (1500, 500)
        if ladder_rating is None:
            ladder_rating = (1500, 500)
        self.global_rating = global_rating
        self.ladder_rating = ladder_rating

        #social
        self.avatar = None
        self.clan = clan
        self.country = None

        self.friends = set()
        self.foes = set()

        self.league = None

        self.admin = permissionGroup >= 2
        self.mod = permissionGroup >= 1
        
        self.numGames = numGames

        self.state = PlayerState.IDLE

        self.expandLadder = 0
        self.faction = 1

        self._lobby_connection = lambda: None
        if lobby_connection is not None:
            self.lobby_connection = lobby_connection

        self._game = lambda: None
        self._game_connection = lambda: None

    def getAddress(self):
        return "%s:%s" % (str(self.ip), str(self.game_port))


    @property
    def lobby_connection(self) -> "LobbyConnection":
        """
        Weak reference to the LobbyConnection of this player
        """
        return self._lobby_connection()

    @lobby_connection.setter
    def lobby_connection(self, value: "LobbyConnection"):
        self._lobby_connection = weakref.ref(value)

    @property
    def game(self):
        """
        Weak reference to the Game object that this player wants to join or is currently in
        """
        return self._game()

    @game.setter
    def game(self, value):
        self._game = weakref.ref(value)

    @game.deleter
    def game(self):
        self._game = lambda: None

    @property
    def game_connection(self):
        """
        Weak reference to the GameConnection object for this player
        :return:
        """
        return self._game_connection()

    @game_connection.setter
    def game_connection(self, value):
        self._game_connection = weakref.ref(value)

    @game_connection.deleter
    def game_connection(self):
        self._game_connection = lambda: None

    @property
    def in_game(self):
        return self.game is not None

    @property
    def game_port(self):
        return self._game_port or 6112

    @game_port.setter
    def game_port(self, value):
        self._game_port = value

    @property
    def address_and_port(self):
        return "{}:{}".format(self.ip, self.game_port)

    def notify_potential_match(self, player, potential):

        if self.lobby_connection:
            self.lobby_connection.sendJSON({
                'command': 'matchmaker_info',
                'potential': potential
            })

    def to_dict(self):
        """
        Return a dictionary representing this player object
        :return:
        """
        def filter_none(t):
            _, v = t
            return v is not None
        return dict(filter(filter_none, (
            ('id', self.id),

            ('login', self.login),

            ('global_rating', self.global_rating),
            ('ladder_rating', self.ladder_rating),
            ('number_of_games', self.numGames),
            ('avatar', self.avatar),
            ('country', self.country),
            ('clan', self.clan)
        )))

    def __str__(self):
        return "Player({}, {}, {}, {})".format(self.login, self.id, self.global_rating, self.ladder_rating)


    def __repr__(self):
        return self.__str__()

    def __hash__(self):
        return self.id


    def __eq__(self, other):
        if not isinstance(other, BasePlayer):
            return False
        else:
            return self.id == other.id



1			import weakref
2
3			from enum import IntEnum, unique
4
5			from .abc.base_player import BasePlayer
			0 ignored issues – show Bug introduced 2015-11-21 11:08 UTC by Report Bug Copy Issue Report The name `base_player` does not seem to exist in module `abc`. Loading history... Configuration introduced 2015-11-21 11:08 UTC by Report Bug Copy Issue Report The import `abc.base_player` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
6
7			@unique
8			class PlayerState(IntEnum):
9			IDLE = 1,
10			PLAYING = 2,
11			HOSTING = 3,
12			JOINING = 4,
13			SEARCHING_LADDER = 5,
14
15			class Player(BasePlayer):
16			"""
17			Standard player object used for representing signed-in players.
18
19			In the context of a game, the Game object holds game-specific
20			information about players.
21			"""
22			def __init__(self, login=None, session=0, ip=None, port=None, id=0,
			0 ignored issues – show Bug Best Practice introduced 2015-11-21 11:08 UTC by Report Bug Copy Issue Report This seems to re-define the built-in `id`. It is generally discouraged to redefine built-ins as this makes code very hard to read. Loading history...
23			global_rating=None, ladder_rating=None, clan=None, numGames=0, permissionGroup=0, lobby_connection=None):
			0 ignored issues – show Coding Style introduced 2016-02-03 22:38 UTC by Report Bug Copy Issue Report This line is too long as per the coding-style (122/120). This check looks for lines that are too long. You can specify the maximum line length. Loading history...
24			super().__init__(id, login)
25
26			# The id of the user in the `login` table of the database.
27			self.session = session
28			self.ip = ip
29			self._game_port = port
30
31			if global_rating is None:
32			global_rating = (1500, 500)
33			if ladder_rating is None:
34			ladder_rating = (1500, 500)
35			self.global_rating = global_rating
36			self.ladder_rating = ladder_rating
37
38			#social
39			self.avatar = None
40			self.clan = clan
41			self.country = None
42
43			self.friends = set()
44			self.foes = set()
45
46			self.league = None
47
48			self.admin = permissionGroup >= 2
49			self.mod = permissionGroup >= 1
50
51			self.numGames = numGames
52
53			self.state = PlayerState.IDLE
54
55			self.expandLadder = 0
56			self.faction = 1
57
58			self._lobby_connection = lambda: None
59			if lobby_connection is not None:
60			self.lobby_connection = lobby_connection
61
62			self._game = lambda: None
63			self._game_connection = lambda: None
64
65			def getAddress(self):
66			return "%s:%s" % (str(self.ip), str(self.game_port))
67
68
69			@property
70			def lobby_connection(self) -> "LobbyConnection":
71			"""
72			Weak reference to the LobbyConnection of this player
73			"""
74			return self._lobby_connection()
75
76			@lobby_connection.setter
77			def lobby_connection(self, value: "LobbyConnection"):
78			self._lobby_connection = weakref.ref(value)
79
80			@property
81			def game(self):
82			"""
83			Weak reference to the Game object that this player wants to join or is currently in
84			"""
85			return self._game()
86
87			@game.setter
88			def game(self, value):
89			self._game = weakref.ref(value)
90
91			@game.deleter
92			def game(self):
93			self._game = lambda: None
94
95			@property
96			def game_connection(self):
97			"""
98			Weak reference to the GameConnection object for this player
99			:return:
100			"""
101			return self._game_connection()
102
103			@game_connection.setter
104			def game_connection(self, value):
105			self._game_connection = weakref.ref(value)
106
107			@game_connection.deleter
108			def game_connection(self):
109			self._game_connection = lambda: None
110
111			@property
112			def in_game(self):
113			return self.game is not None
114
115			@property
116			def game_port(self):
117			return self._game_port or 6112
118
119			@game_port.setter
120			def game_port(self, value):
121			self._game_port = value
122
123			@property
124			def address_and_port(self):
125			return "{}:{}".format(self.ip, self.game_port)
126
127			def notify_potential_match(self, player, potential):
			0 ignored issues – show Unused Code introduced 2015-11-21 11:08 UTC by Report Bug Copy Issue Report The argument `player` seems to be unused. Loading history...
128			if self.lobby_connection:
129			self.lobby_connection.sendJSON({
130			'command': 'matchmaker_info',
131			'potential': potential
132			})
133
134			def to_dict(self):
135			"""
136			Return a dictionary representing this player object
137			:return:
138			"""
139			def filter_none(t):
140			_, v = t
141			return v is not None
142			return dict(filter(filter_none, (
143			('id', self.id),
			0 ignored issues – show Bug introduced 2015-11-21 11:08 UTC by Report Bug Copy Issue Report The Instance of `Player` does not seem to have a member named `id`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
144			('login', self.login),
			0 ignored issues – show Bug introduced 2015-11-21 11:08 UTC by Report Bug Copy Issue Report The Instance of `Player` does not seem to have a member named `login`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
145			('global_rating', self.global_rating),
146			('ladder_rating', self.ladder_rating),
147			('number_of_games', self.numGames),
148			('avatar', self.avatar),
149			('country', self.country),
150			('clan', self.clan)
151			)))
152
153			def __str__(self):
154			return "Player({}, {}, {}, {})".format(self.login, self.id, self.global_rating, self.ladder_rating)
			0 ignored issues – show Bug introduced 2015-11-21 11:08 UTC by Report Bug Copy Issue Report The Instance of `Player` does not seem to have a member named `login`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history... Bug introduced 2015-11-21 11:08 UTC by Report Bug Copy Issue Report The Instance of `Player` does not seem to have a member named `id`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
155
156			def __repr__(self):
157			return self.__str__()
158
159			def __hash__(self):
160			return self.id
			0 ignored issues – show Bug introduced 2015-11-21 11:08 UTC by Report Bug Copy Issue Report The Instance of `Player` does not seem to have a member named `id`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
161
162			def __eq__(self, other):
163			if not isinstance(other, BasePlayer):
164			return False
165			else:
166			return self.id == other.id
			0 ignored issues – show Bug introduced 2015-11-21 11:08 UTC by Report Bug Copy Issue Report The Instance of `Player` does not seem to have a member named `id`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
167

GitHub Access Token became invalid

Push — develop ( 83a854...4f119b )

server.Player.init() C

Complexity

Size

Duplication

1. Missing Dependencies

2. Missing init.py files

FAForever / server

GitHub Access Token became invalid

Push — develop ( 83a854...4f119b )

server.Player.__init__() C

Complexity

Size

Duplication

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

server.Player.init() C

2. Missing init.py files