UserManagerAbstract::hasPermissions() - Code Metrics - Inspection of "Remove dependency on token storage." - Eziat/PermissionBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 129074...847d40 )

by Tomas

created 2018-01-05 15:58 UTC

UserManagerAbstract::hasPermissions() A

↳ Parent: UserManagerAbstract

Complexity

Conditions	3
Paths	3

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	6
nc	3
nop	2

<?php

declare(strict_types = 1);

namespace Eziat\PermissionBundle\Model;

/**
 * @author Tomas Jakl <[email protected]>
 */
abstract class UserManagerAbstract implements UserManagerInterface
{
    /**
     * {@inheritdoc}
     */
    public function hasPermissions(UserPermissionInterface $user, array $permissions) : bool
    {
        $userPermissions = $this->getPermissions($user);

        foreach ($permissions as $permission) {
            if (!in_array($permission, $userPermissions)) {
                return false;
            }
        }

        return true;
    }

    /**
     * {@inheritdoc}
     */
    public function hasPermission(UserPermissionInterface $user, $permission) : bool
    {
        return $this->hasPermission($user, [$permission]);
    }

    protected function getUserPermissions(UserPermissionInterface $user) : array
    {
        foreach ($user->getPermissions() as $permission) {
            $permissions[] = $permission->getName();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }

        return $permissions;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }
}

1			<?php
2
3			declare(strict_types = 1);
4
5			namespace Eziat\PermissionBundle\Model;
6
7			/**
8			* @author Tomas Jakl <[email protected]>
9			*/
10			abstract class UserManagerAbstract implements UserManagerInterface
11			{
12			/**
13			* {@inheritdoc}
14			*/
15			public function hasPermissions(UserPermissionInterface $user, array $permissions) : bool
16			{
17			$userPermissions = $this->getPermissions($user);
18
19			foreach ($permissions as $permission) {
20			if (!in_array($permission, $userPermissions)) {
21			return false;
22			}
23			}
24
25			return true;
26			}
27
28			/**
29			* {@inheritdoc}
30			*/
31			public function hasPermission(UserPermissionInterface $user, $permission) : bool
32			{
33			return $this->hasPermission($user, [$permission]);
34			}
35
36			protected function getUserPermissions(UserPermissionInterface $user) : array
37			{
38			foreach ($user->getPermissions() as $permission) {
39			$permissions[] = $permission->getName();
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-01-05 16:09 UTC by Report Bug Copy Issue Report `$permissions` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$permissions = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
40			}
41
42			return $permissions;
			0 ignored issues – show Bug introduced 2018-01-05 16:09 UTC by Report Bug Copy Issue Report The variable `$permissions` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
43			}
44			}

Eziat / PermissionBundle

Push — master ( 129074...847d40 )

UserManagerAbstract::hasPermissions() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like