Eziat\PermissionBundle\Manager\CachedUserManager

Complexity

Total Complexity

5

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getPermissions()	0	13	3
A	invalidatePermissions()	0	5	1

<?php

declare(strict_types = 1);

namespace Eziat\PermissionBundle\Manager;

use Eziat\PermissionBundle\Model\UserManagerAbstract;
use Eziat\PermissionBundle\Model\UserManagerInterface;
use Eziat\PermissionBundle\Model\UserPermissionInterface;
use Eziat\PermissionBundle\Utils\CacheHelperInterface;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;

/**
 * @author Tomas Jakl <tomasjakll@gmail.com>
 */
class CachedUserManager extends UserManagerAbstract implements UserManagerInterface
{
    /**
     * @var CacheHelperInterface
     */
    private $cacheHelper;

    /**
     * @var string
     */
    private $cachePrefix;

    public function __construct(CacheHelperInterface $cacheHelper, string $cachePrefix )
    {
        $this->cacheHelper = $cacheHelper;
        $this->cachePrefix = $cachePrefix;
    }

    /**
     * {@inheritdoc}
     */
    public function getPermissions(UserPermissionInterface $user = null) : array
    {
        $cacheID = $this->cachePrefix.$user->getId();

It seems like $user is not always an object, but can also be of type null. Maybe add an additional type check?

        $permissions = $this->cacheHelper->get($cacheID);
        if ($permissions === null) {
            $permissions = $this->getUserPermissions($user);

It seems like $user defined by parameter $user on line 37 can be null; however, Eziat\PermissionBundle\Model\UserManagerAbstract::getUserPermissions() does not accept null, maybe add an additional type check?

            if ( $permissions !== [] ){
                $this->cacheHelper->save($cacheID, $permissions);
            }
        }

        return $permissions;
    }

    /**
     * {@inheritdoc}
     */
    public function invalidatePermissions(UserPermissionInterface $user) : void
    {
        $cacheID = $this->cachePrefix.$user->getId();
        $this->cacheHelper->delete($cacheID);
    }
}