RequestTest::testSchemeSetterWithInvalidValue() - Code Metrics - Inspection of "Refactoring v2" - Exeu/apai-io - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#110)

by Jan

created 2016-04-04 14:04 UTC

RequestTest::testSchemeSetterWithInvalidValue() A

↳ Parent: RequestTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	7
rs	9.4285
cc	1
eloc	4
nc	1
nop	0

<?php
/*
 * Copyright 2016 Jan Eichhorn <[email protected]>
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace ApaiIO\Test\Request\Rest;

use ApaiIO\Configuration\GenericConfiguration;
use ApaiIO\Operations\Lookup;
use ApaiIO\Request\Rest\Request;
use Prophecy\Argument;
use Psr\Http\Message\RequestInterface;

class RequestTest extends \PHPUnit_Framework_TestCase
{
    public function testPerform()
    {
        $body = $this->prophesize('\Psr\Http\Message\StreamInterface');
        $body
            ->getContents()
            ->shouldBeCalledTimes(1)
            ->willReturn('ABC');

        $response = $this->prophesize('\Psr\Http\Message\ResponseInterface');
        $response
            ->getBody()
            ->shouldBeCalledTimes(1)
            ->willReturn($body->reveal());

        $client = $this->prophesize('\GuzzleHttp\ClientInterface');
        $client
            ->send(Argument::that(function ($request) {
                if (!$request instanceof RequestInterface) {
                    return false;
                }

                $uri = $request->getUri();
                $parts = [];
                parse_str($uri->getQuery(), $parts);

                $this->assertSame('webservices.amazon.de', $uri->getHost());
                $this->assertSame('/onca/xml', $uri->getPath());
                $this->assertArrayHasKey('AWSAccessKeyId', $parts);
                $this->assertSame('jkl', $parts['AWSAccessKeyId']);
                $this->assertArrayHasKey('AssociateTag', $parts);
                $this->assertSame('def', $parts['AssociateTag']);
                $this->assertArrayHasKey('ItemId', $parts);
                $this->assertSame('1', $parts['ItemId']);
                $this->assertArrayHasKey('Test', $parts);
                $this->assertSame('a,b', $parts['Test']);
                $this->assertArrayHasKey('Operation', $parts);
                $this->assertSame('ItemLookup', $parts['Operation']);
                $this->assertArrayHasKey('Service', $parts);
                $this->assertSame('AWSECommerceService', $parts['Service']);
                $this->assertArrayHasKey('Timestamp', $parts);
                $this->assertRegExp('#[0-9]{4}(-[0-9]{2}){2}T([0-9]{2}:){2}[0-9]{2}Z#', $parts['Timestamp']);
                $this->assertArrayHasKey('Version', $parts);
                $this->assertSame('2013-08-01', $parts['Version']);
                $this->assertArrayHasKey('Signature', $parts);
                return true;
            }))
            ->shouldBeCalledTimes(1)
            ->willReturn($response->reveal());

        $request = new Request($client->reveal());

        $operation  = new Lookup();
        $operation->setItemId('1');
        $operation->setTest(['a', 'b']);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        $config = new GenericConfiguration();
        $config->setAccessKey('abc');
        $config->setAssociateTag('def');
        $config->setCountry('DE');
        $config->setSecretKey('ghi');
        $config->setAccessKey('jkl');

        $request->perform($operation, $config);
    }

    public function testSchemeSwitch()
    {
        $body = $this->prophesize('\Psr\Http\Message\StreamInterface');
        $body
            ->getContents()
            ->shouldBeCalledTimes(1)
            ->willReturn('ABC');

        $response = $this->prophesize('\Psr\Http\Message\ResponseInterface');
        $response
            ->getBody()
            ->shouldBeCalledTimes(1)
            ->willReturn($body->reveal());

        $client = $this->prophesize('\GuzzleHttp\ClientInterface');
        $client
            ->send(Argument::that(function ($request) {
                if (!$request instanceof RequestInterface) {
                    return false;
                }

                $uri = $request->getUri();

                $this->assertSame('https', $uri->getScheme());
                return true;
            }))
            ->shouldBeCalledTimes(1)
            ->willReturn($response->reveal());

        $request = new Request($client->reveal());
        $request->setScheme('HTTPS');

        $operation  = new Lookup();
        $operation->setItemId('1');

        $config = new GenericConfiguration();
        $config->setAccessKey('abc');
        $config->setAssociateTag('def');
        $config->setCountry('DE');
        $config->setSecretKey('ghi');
        $config->setAccessKey('jkl');

        $request->perform($operation, $config);
    }

    /**
     * @expectedException \InvalidArgumentException
     */
    public function testSchemeSetterWithInvalidValue()
    {
        $client = $this->prophesize('\GuzzleHttp\ClientInterface');

        $request = new Request($client->reveal());
        $request->setScheme('ftp');
    }
}


1			<?php
2			/*
3			* Copyright 2016 Jan Eichhorn <[email protected]>
4			*
5			* Licensed under the Apache License, Version 2.0 (the "License");
6			* you may not use this file except in compliance with the License.
7			* You may obtain a copy of the License at
8			*
9			* http://www.apache.org/licenses/LICENSE-2.0
10			*
11			* Unless required by applicable law or agreed to in writing, software
12			* distributed under the License is distributed on an "AS IS" BASIS,
13			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14			* See the License for the specific language governing permissions and
15			* limitations under the License.
16			*/
17
18			namespace ApaiIO\Test\Request\Rest;
19
20			use ApaiIO\Configuration\GenericConfiguration;
21			use ApaiIO\Operations\Lookup;
22			use ApaiIO\Request\Rest\Request;
23			use Prophecy\Argument;
24			use Psr\Http\Message\RequestInterface;
25
26			class RequestTest extends \PHPUnit_Framework_TestCase
27			{
28			public function testPerform()
29			{
30			$body = $this->prophesize('\Psr\Http\Message\StreamInterface');
31			$body
32			->getContents()
33			->shouldBeCalledTimes(1)
34			->willReturn('ABC');
35
36			$response = $this->prophesize('\Psr\Http\Message\ResponseInterface');
37			$response
38			->getBody()
39			->shouldBeCalledTimes(1)
40			->willReturn($body->reveal());
41
42			$client = $this->prophesize('\GuzzleHttp\ClientInterface');
43			$client
44			->send(Argument::that(function ($request) {
45			if (!$request instanceof RequestInterface) {
46			return false;
47			}
48
49			$uri = $request->getUri();
50			$parts = [];
51			parse_str($uri->getQuery(), $parts);
52
53			$this->assertSame('webservices.amazon.de', $uri->getHost());
54			$this->assertSame('/onca/xml', $uri->getPath());
55			$this->assertArrayHasKey('AWSAccessKeyId', $parts);
56			$this->assertSame('jkl', $parts['AWSAccessKeyId']);
57			$this->assertArrayHasKey('AssociateTag', $parts);
58			$this->assertSame('def', $parts['AssociateTag']);
59			$this->assertArrayHasKey('ItemId', $parts);
60			$this->assertSame('1', $parts['ItemId']);
61			$this->assertArrayHasKey('Test', $parts);
62			$this->assertSame('a,b', $parts['Test']);
63			$this->assertArrayHasKey('Operation', $parts);
64			$this->assertSame('ItemLookup', $parts['Operation']);
65			$this->assertArrayHasKey('Service', $parts);
66			$this->assertSame('AWSECommerceService', $parts['Service']);
67			$this->assertArrayHasKey('Timestamp', $parts);
68			$this->assertRegExp('#[0-9]{4}(-[0-9]{2}){2}T([0-9]{2}:){2}[0-9]{2}Z#', $parts['Timestamp']);
69			$this->assertArrayHasKey('Version', $parts);
70			$this->assertSame('2013-08-01', $parts['Version']);
71			$this->assertArrayHasKey('Signature', $parts);
72			return true;
73			}))
74			->shouldBeCalledTimes(1)
75			->willReturn($response->reveal());
76
77			$request = new Request($client->reveal());
78
79			$operation = new Lookup();
80			$operation->setItemId('1');
81			$operation->setTest(['a', 'b']);
			0 ignored issues – show Documentation Bug introduced 2016-04-03 16:20 UTC by Report Bug Copy Issue Report The method `setTest` does not exist on `object<ApaiIO\Operations\Lookup>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
82
83			$config = new GenericConfiguration();
84			$config->setAccessKey('abc');
85			$config->setAssociateTag('def');
86			$config->setCountry('DE');
87			$config->setSecretKey('ghi');
88			$config->setAccessKey('jkl');
89
90			$request->perform($operation, $config);
91			}
92
93			public function testSchemeSwitch()
94			{
95			$body = $this->prophesize('\Psr\Http\Message\StreamInterface');
96			$body
97			->getContents()
98			->shouldBeCalledTimes(1)
99			->willReturn('ABC');
100
101			$response = $this->prophesize('\Psr\Http\Message\ResponseInterface');
102			$response
103			->getBody()
104			->shouldBeCalledTimes(1)
105			->willReturn($body->reveal());
106
107			$client = $this->prophesize('\GuzzleHttp\ClientInterface');
108			$client
109			->send(Argument::that(function ($request) {
110			if (!$request instanceof RequestInterface) {
111			return false;
112			}
113
114			$uri = $request->getUri();
115
116			$this->assertSame('https', $uri->getScheme());
117			return true;
118			}))
119			->shouldBeCalledTimes(1)
120			->willReturn($response->reveal());
121
122			$request = new Request($client->reveal());
123			$request->setScheme('HTTPS');
124
125			$operation = new Lookup();
126			$operation->setItemId('1');
127
128			$config = new GenericConfiguration();
129			$config->setAccessKey('abc');
130			$config->setAssociateTag('def');
131			$config->setCountry('DE');
132			$config->setSecretKey('ghi');
133			$config->setAccessKey('jkl');
134
135			$request->perform($operation, $config);
136			}
137
138			/**
139			* @expectedException \InvalidArgumentException
140			*/
141			public function testSchemeSetterWithInvalidValue()
142			{
143			$client = $this->prophesize('\GuzzleHttp\ClientInterface');
144
145			$request = new Request($client->reveal());
146			$request->setScheme('ftp');
147			}
148			}
149

Exeu / apai-io

GitHub Access Token became invalid

Pull Request — master (#110)

RequestTest::testSchemeSetterWithInvalidValue() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like