BatchTest - Code Metrics - Inspection of "Merge pull request #110 from Exeu/refactoring-v2" - Exeu/apai-io - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 126d2e...87d70e )

by Jan

created 2016-05-28 20:28 UTC

BatchTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes

Metric	Value
wmc	1
lcom	0
cbo	4
dl	0
loc	37
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	testAddOperation()	0	34	1

<?php
/*
 * Copyright 2016 Jan Eichhorn <[email protected]>
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace ApaiIO\Test\Operations\Types;

use ApaiIO\Operations\Batch;
use ApaiIO\Operations\Lookup;
use ApaiIO\Operations\Search;

class BatchTest extends \PHPUnit_Framework_TestCase
{
    public function testAddOperation()
    {
        $op = new Search();
        $op->setTest('test');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        $batch = new Batch();
        $batch->addOperation($op);

        $this->assertSame('ItemSearch', $batch->getName());
        $this->assertSame(['ItemSearch.1.Test' => 'test'], $batch->getOperationParameter());

        $op2 = new Lookup();

        $batch->addOperation($op2);

        $this->assertSame('ItemSearch', $batch->getName());
        $this->assertSame(['ItemSearch.1.Test' => 'test'], $batch->getOperationParameter());

        $batch = new Batch([$op, $op2]);

        $this->assertSame('ItemSearch', $batch->getName());
        $this->assertSame(['ItemSearch.1.Test' => 'test'], $batch->getOperationParameter());

        $op3 = new Search();
        $op3->setTest2('test');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        $batch->addOperation($op3);

        $this->assertSame('ItemSearch', $batch->getName());
        $this->assertSame([
            'ItemSearch.1.Test' => 'test',
            'ItemSearch.2.Test2' => 'test'
        ], $batch->getOperationParameter());
    }
}


1			<?php
2			/*
3			* Copyright 2016 Jan Eichhorn <[email protected]>
4			*
5			* Licensed under the Apache License, Version 2.0 (the "License");
6			* you may not use this file except in compliance with the License.
7			* You may obtain a copy of the License at
8			*
9			* http://www.apache.org/licenses/LICENSE-2.0
10			*
11			* Unless required by applicable law or agreed to in writing, software
12			* distributed under the License is distributed on an "AS IS" BASIS,
13			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14			* See the License for the specific language governing permissions and
15			* limitations under the License.
16			*/
17
18			namespace ApaiIO\Test\Operations\Types;
19
20			use ApaiIO\Operations\Batch;
21			use ApaiIO\Operations\Lookup;
22			use ApaiIO\Operations\Search;
23
24			class BatchTest extends \PHPUnit_Framework_TestCase
25			{
26			public function testAddOperation()
27			{
28			$op = new Search();
29			$op->setTest('test');
			0 ignored issues – show Documentation Bug introduced 2016-03-26 10:25 UTC by Report Bug Copy Issue Report The method `setTest` does not exist on `object<ApaiIO\Operations\Search>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
30
31			$batch = new Batch();
32			$batch->addOperation($op);
33
34			$this->assertSame('ItemSearch', $batch->getName());
35			$this->assertSame(['ItemSearch.1.Test' => 'test'], $batch->getOperationParameter());
36
37			$op2 = new Lookup();
38
39			$batch->addOperation($op2);
40
41			$this->assertSame('ItemSearch', $batch->getName());
42			$this->assertSame(['ItemSearch.1.Test' => 'test'], $batch->getOperationParameter());
43
44			$batch = new Batch([$op, $op2]);
45
46			$this->assertSame('ItemSearch', $batch->getName());
47			$this->assertSame(['ItemSearch.1.Test' => 'test'], $batch->getOperationParameter());
48
49			$op3 = new Search();
50			$op3->setTest2('test');
			0 ignored issues – show Documentation Bug introduced 2016-03-26 10:25 UTC by Report Bug Copy Issue Report The method `setTest2` does not exist on `object<ApaiIO\Operations\Search>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
51
52			$batch->addOperation($op3);
53
54			$this->assertSame('ItemSearch', $batch->getName());
55			$this->assertSame([
56			'ItemSearch.1.Test' => 'test',
57			'ItemSearch.2.Test2' => 'test'
58			], $batch->getOperationParameter());
59			}
60			}
61

Exeu / apai-io

GitHub Access Token became invalid

Push — master ( 126d2e...87d70e )

BatchTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like