AbstractOperationTest - Code Metrics - Inspection of "added getters for operations and unit-tests" - Exeu/apai-io - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#99)

unknown

created 2016-02-19 17:49 UTC

AbstractOperationTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Metric	Value
wmc	3
lcom	0
cbo	2
dl	0
loc	27
rs	10

3 Methods

Rating	Name	Size	Complexity
A	testAbstractOperationSetterAndGetter()	7	1
A	testAbstractOperationInvalidMethodName()	5	1
A	testGetResponseGroup()	7	1

<?php
/*
 * Copyright 2013 Jan Eichhorn <[email protected]>
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace ApaiIO\Test\Operations\Types;

use ApaiIO\Operations\Search;

class AbstractOperationTest extends \PHPUnit_Framework_TestCase
{
    public function testAbstractOperationSetterAndGetter()
    {
        $search = new Search();
        $search->setFoo('ABC');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        static::assertEquals('ABC', $search->getFoo());
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }

    /**
     * @expectedException BadFunctionCallException
     */
    public function testAbstractOperationInvalidMethodName()
    {
        $search = new Search();
        $search->foo();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }

    public function testGetResponseGroup()
    {
        $search = new Search();
        static::assertEquals(null, $search->getResponseGroup());
        $search->setResponseGroup(array('Small', 'Medium', 'Large'));
        static::assertEquals(array('Small', 'Medium', 'Large'), $search->getResponseGroup());
    }
}


1			<?php
2			/*
3			* Copyright 2013 Jan Eichhorn <[email protected]>
4			*
5			* Licensed under the Apache License, Version 2.0 (the "License");
6			* you may not use this file except in compliance with the License.
7			* You may obtain a copy of the License at
8			*
9			* http://www.apache.org/licenses/LICENSE-2.0
10			*
11			* Unless required by applicable law or agreed to in writing, software
12			* distributed under the License is distributed on an "AS IS" BASIS,
13			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14			* See the License for the specific language governing permissions and
15			* limitations under the License.
16			*/
17
18			namespace ApaiIO\Test\Operations\Types;
19
20			use ApaiIO\Operations\Search;
21
22			class AbstractOperationTest extends \PHPUnit_Framework_TestCase
23			{
24			public function testAbstractOperationSetterAndGetter()
25			{
26			$search = new Search();
27			$search->setFoo('ABC');
			0 ignored issues – show Documentation Bug introduced 2015-12-05 23:10 UTC by Report Bug Copy Issue Report The method `setFoo` does not exist on `object<ApaiIO\Operations\Search>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
28
29			static::assertEquals('ABC', $search->getFoo());
			0 ignored issues – show Documentation Bug introduced 2015-12-05 23:10 UTC by Report Bug Copy Issue Report The method `getFoo` does not exist on `object<ApaiIO\Operations\Search>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
30			}
31
32			/**
33			* @expectedException BadFunctionCallException
34			*/
35			public function testAbstractOperationInvalidMethodName()
36			{
37			$search = new Search();
38			$search->foo();
			0 ignored issues – show Documentation Bug introduced 2015-12-05 23:10 UTC by Report Bug Copy Issue Report The method `foo` does not exist on `object<ApaiIO\Operations\Search>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
39			}
40
41			public function testGetResponseGroup()
42			{
43			$search = new Search();
44			static::assertEquals(null, $search->getResponseGroup());
45			$search->setResponseGroup(array('Small', 'Medium', 'Large'));
46			static::assertEquals(array('Small', 'Medium', 'Large'), $search->getResponseGroup());
47			}
48			}
49

Exeu / apai-io

GitHub Access Token became invalid

Pull Request — master (#99)

AbstractOperationTest A

Complexity

Size/Duplication

Coupling/Cohesion

3 Methods

Duplication Side-by-Side

Filter issues like