exabgp.bgp.message.update.attribute.bgpls.link.sradj

Complexity

Total Complexity

10

Size/Duplication

Total Lines	80
Duplicated Lines	63.75 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
B	SrAdjacency.unpack()	33	33	6
A	SrAdjacency.json()	2	2	1
A	SrAdjacency.reset()	3	3	1
A	SrAdjacency.__repr__()	2	2	1
A	SrAdjacency.__init__()	2	2	1

# encoding: utf-8
"""
sradj.py

Created by Evelio Vila
Copyright (c) 2014-2017 Exa Networks. All rights reserved.
"""

import json
from struct import unpack
from exabgp.vendoring import six
from exabgp.util import hexstring

from exabgp.vendoring.bitstring import BitArray
from exabgp.bgp.message.update.attribute.bgpls.linkstate import LINKSTATE, LsGenericFlags

#    draft-gredler-idr-bgp-ls-segment-routing-ext-03
#    0                   1                   2                   3
#    0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
#   +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
#   |               Type            |              Length           |
#   +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
#   | Flags         |     Weight    |             Reserved          |
#   +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
#   |                   SID/Label/Index (variable)                  |
#   +---------------------------------------------------------------+
#

@LINKSTATE.register()

This code seems to be duplicated in your project.

class SrAdjacency(object):
	TLV = 1099
	_sr_adj_sids = []

	def __init__ (self):
		self.sr_adj_sids = SrAdjacency._sr_adj_sids.copy()

	def __repr__ (self):
		return "sr-adj-sids: {}".format(self.sr_adj_sids)

	@classmethod
	def unpack (cls,data,length):
		# We only support IS-IS flags for now.
		flags = LsGenericFlags.unpack(data[0:1],LsGenericFlags.ISIS_SR_ADJ_FLAGS).flags
		# Parse adj weight
		weight = six.indexbytes(data,1)
		# Move pointer 4 bytes: Flags(1) + Weight(1) + Reserved(2)
		data = data[4:]
     	# SID/Index/Label: according to the V and L flags, it contains
      	# either:
		# *  A 3 octet local label where the 20 rightmost bits are used for
		#	 encoding the label value.  In this case the V and L flags MUST
		#	 be set.
		#
		# *  A 4 octet index defining the offset in the SID/Label space
		# 	 advertised by this router using the encodings defined in
		#  	 Section 3.1.  In this case V and L flags MUST be unset.
		raw = []
		while data:
			# Range Size: 3 octet value indicating the number of labels in
			# the range.
			if int(flags['V']) and int(flags['L']):
				b = BitArray(bytes=data[:3])
				sid = b.unpack('uintbe:24')[0]
				data = data[3:]
			elif (not flags['V']) and (not flags['L']):
				sid = unpack('!I',data[:4])[0]
				data = data[4:]
			else:
				raw.append(hexstring(data))
				break
		cls._sr_adj_sids.append({'flags': flags, 'weight': weight, 'sid': sid, 'undecoded': raw})

The variable sid does not seem to be defined in case the while loop on line 58 is not entered. Are you sure this can never be the case?

		return cls()

	def json (self,compact=None):
		return '"sr-adj-sids": {}'.format(json.dumps(self.sr_adj_sids))

	@classmethod
	def reset(cls):
		cls._sr_adj_sids = []