exabgp.bgp.message.update.nlri.bgpls.prefixv6

Complexity

Total Complexity

17

Size/Duplication

Total Lines	132
Duplicated Lines	73.48 %

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	PREFIXv6.__ne__()	2	2	1
B	PREFIXv6.unpack_nlri()	38	38	8
A	PREFIXv6.pack()	2	2	1
A	PREFIXv6.json()	17	17	3
A	PREFIXv6.__str__()	2	2	1
A	PREFIXv6.__eq__()	7	7	1
A	PREFIXv6.__init__()	13	13	1
A	PREFIXv6.__hash__()	2	2	1

"""
prefixv6.py
Created by Tinus Flagstad & Håvard Eidnes on 2018-07-02.
Copyright (c) 2009-2018 Exa Networks. All rights reserved.
License: 3-clause BSD. (See the COPYRIGHT file)
"""

from struct import pack
from struct import unpack
import json

from exabgp.bgp.message.update.nlri.bgpls.nlri import BGPLS
from exabgp.bgp.message.update.nlri.bgpls.nlri import PROTO_CODES
from exabgp.bgp.message.update.nlri.bgpls.tlvs.node import NodeDescriptor
from exabgp.bgp.message.update.nlri.bgpls.tlvs.ospfroute import OspfRoute
from exabgp.bgp.message.update.nlri.bgpls.tlvs.ipreach import IpReach

#   The IPv4 and IPv6 Prefix NLRIs (NLRI Type = 3 and Type = 4) use the
#   same format, as shown in the following figure.
#
#      0                   1                   2                   3
#      0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
#     +-+-+-+-+-+-+-+-+
#     |  Protocol-ID  |
#     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
#     |                           Identifier                          |
#     |                            (64 bits)                          |
#     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
#     //              Local Node Descriptors (variable)              //
#     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
#     //                Prefix Descriptors (variable)                //
#     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+


@BGPLS.register

This code seems to be duplicated in your project.

class PREFIXv6(BGPLS):
	CODE = 4
	NAME = "bgpls-prefix-v6"
	SHORT_NAME = "PREFIX_V6"

	def __init__ (
			self,domain,proto_id,local_node,
			packed=None,ospf_type=None,prefix=None,
			nexthop=None,route_d=None,action=None, addpath=None):
		BGPLS.__init__(self,action,addpath)
		self.domain = domain
		self.ospf_type = ospf_type
		self.proto_id = proto_id
		self.local_node = local_node
		self.prefix = prefix
		self.nexthop = nexthop
		self._pack = packed
		self.route_d = route_d

	@classmethod
	def unpack_nlri (cls, data, rd):
		ospf_type = None
		proto_id = unpack('!B',data[0:1])[0]
		if proto_id not in PROTO_CODES.keys():
			raise Exception('Protocol-ID {} is not valid'.format(proto_id))
		domain = unpack('!Q',data[1:9])[0]
		tlvs = data[9:]

		while tlvs:
			tlv_type, tlv_length = unpack('!HH', tlvs[:4])
			if tlv_type == 256:
				values = tlvs[4: 4 + tlv_length]
				local_node = []
				while values:
					# Unpack Local Node Descriptor Sub-TLVs
					# We pass proto_id as TLV interpretation
					# follows IGP type
					node, left = NodeDescriptor.unpack(values, proto_id)
					local_node.append(node)
					if left == values:
						raise RuntimeError("sub-calls should consume data")
					values = left
				tlvs = tlvs[4 + tlv_length:]
				continue
			if tlv_type == 264:
				values = tlvs[4: 4 + tlv_length]
				ospf_type = OspfRoute.unpack(values)
				tlvs = tlvs[4 + tlv_length:]
			if tlv_type == 265:
				values = tlvs[4: 4 + tlv_length]
				prefix = IpReach.unpack(values, 4)
				tlvs = tlvs[4 + tlv_length:]

		return cls(
			domain=domain,proto_id=proto_id,packed=data,
			local_node=local_node,ospf_type=ospf_type,

The variable local_node does not seem to be defined in case the while loop on line 64 is not entered. Are you sure this can never be the case?

			prefix=prefix,route_d=rd

The variable prefix does not seem to be defined for all execution paths.

		)

	def __eq__ (self, other):
		return \
			isinstance(other, PREFIXv6) and \
			self.CODE == other.CODE and \
			self.domain == other.domain and \
			self.proto_id == other.proto_id and \
			self.route_d == other.route_d

	def __ne__ (self, other):
		return not self.__eq__(other)

	def __str__ (self):
		return self.json()

	def __hash__ (self):
		return hash((self))

	def json (self, compact=None):
		nodes = ', '.join(d.json() for d in self.local_node)
		content = ', '.join([
			'"ls-nlri-type": "%s"' % self.NAME,
			'"l3-routing-topology": %d' % int(self.domain),
			'"protocol-id": %d' % int(self.proto_id),
			'"node-descriptors": { %s }' % nodes,
			self.prefix.json(),
			'"nexthop": "%s"' % self.nexthop,
		])
		if self.ospf_type:
			content += ', %s' % self.ospf_type.json()

		if self.route_d:
			content += ', %s' % self.route_d.json()

		return '{ %s }' % (content)

	def pack (self,negotiated=None):
		return self._pack