XL2TP\Generator

Complexity

Total Complexity

9

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	render()	0	14	5
A	generate()	0	13	3

<?php

declare(strict_types=1);

namespace XL2TP;

use RuntimeException;
use XL2TP\Interfaces\ConfigInterface;
use XL2TP\Interfaces\GeneratorInterface;

class Generator implements GeneratorInterface
{
    /**
     * @var \XL2TP\Interfaces\ConfigInterface
     */
    public $config;

    /**
     * Generator constructor.
     *
     * @param \XL2TP\Interfaces\ConfigInterface $config
     */
    public function __construct(ConfigInterface $config)
    {
        $this->config = $config;
    }

    /**
     * Render section by parameters in array
     *
     * @param \XL2TP\Section $section Name of section: global, default, lac, lnc
     *
     * @return string
     */
    private function render(Section $section): string
    {
        $name = $section->section;
        if ('global' !== $section->section) {
            $name .= $section->suffix ? ' ' . $section->suffix : '';
        }

        $result = "[$name]" . PHP_EOL;
        foreach ($section->parameters as $key => $val) {
            $result .= "$key = " . (is_numeric($val) ? $val : '"' . $val . '"') . PHP_EOL;
        }

        return $result . PHP_EOL;
    }

    /**
     * Generate L2TP configuration by parameters from memory
     *
     * @return string
     * @throws \RuntimeException If was set bad config
     */
    public function generate(): string
    {
        if (!$this->config instanceof ConfigInterface) {
            throw new RuntimeException('Provided config is invalid');
        }

        $result = '';
        foreach ($this->config->sections as $section) {

Accessing sections on the interface XL2TP\Interfaces\ConfigInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

            $result .= $this->render($section);
        }

        return $result;
    }
}