ShortsTrait::r() - Code Metrics - Inspection of "rosario method added to Client as alternative and..." - EvilFreelancer/routeros-api-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 87995b...abed83 )

by Mr

created 2019-07-20 12:29 UTC

ShortsTrait::r() A

↳ Parent: ShortsTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	1

<?php

namespace RouterOS;

use RouterOS\Interfaces\ClientInterface;

/**
 * Trait ShortsTrait
 *
 * All shortcuts was moved to this class
 *
 * @package RouterOS
 * @since 0.10
 */
trait ShortsTrait
{
    /**
     * Alias for ->write() method
     *
     * @param string|array|\RouterOS\Query $query
     * @return \RouterOS\Interfaces\ClientInterface
     * @throws \RouterOS\Exceptions\QueryException
     */
    public function w($query): ClientInterface
    {
        return $this->write($query);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Alias for ->read() method
     *
     * @param bool $parse
     * @return mixed
     * @since 0.7
     */
    public function r(bool $parse = true)
    {
        return $this->read($parse);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Alias for ->write()->read() combination of methods
     *
     * @param string|array|\RouterOS\Query $query
     * @param bool                         $parse
     * @return array
     * @throws \RouterOS\Exceptions\ClientException
     * @throws \RouterOS\Exceptions\QueryException
     * @since 0.6
     */
    public function wr($query, bool $parse = true): array
    {
        return $this->write($query)->read($parse);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1		<?php
2
3		namespace RouterOS;
4
5		use RouterOS\Interfaces\ClientInterface;
6
7		/**
8		* Trait ShortsTrait
9		*
10		* All shortcuts was moved to this class
11		*
12		* @package RouterOS
13		* @since 0.10
14		*/
15		trait ShortsTrait
16		{
17		/**
18		* Alias for ->write() method
19		*
20		* @param string\|array\|\RouterOS\Query $query
21		* @return \RouterOS\Interfaces\ClientInterface
22		* @throws \RouterOS\Exceptions\QueryException
23		*/
24	1	public function w($query): ClientInterface
25		{
26	1	return $this->write($query);
		0 ignored issues – show Bug introduced 2019-07-20 12:32 UTC by Report Bug Copy Issue Report It seems like `write()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
27		}
28
29		/**
30		* Alias for ->read() method
31		*
32		* @param bool $parse
33		* @return mixed
34		* @since 0.7
35		*/
36	1	public function r(bool $parse = true)
37		{
38	1	return $this->read($parse);
		0 ignored issues – show Bug introduced 2019-07-20 12:32 UTC by Report Bug Copy Issue Report It seems like `read()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
39		}
40
41		/**
42		* Alias for ->write()->read() combination of methods
43		*
44		* @param string\|array\|\RouterOS\Query $query
45		* @param bool $parse
46		* @return array
47		* @throws \RouterOS\Exceptions\ClientException
48		* @throws \RouterOS\Exceptions\QueryException
49		* @since 0.6
50		*/
51	4	public function wr($query, bool $parse = true): array
52		{
53	4	return $this->write($query)->read($parse);
		0 ignored issues – show Bug introduced 2019-07-20 12:32 UTC by Report Bug Copy Issue Report It seems like `write()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
54		}
55		}
56

EvilFreelancer / routeros-api-php

Push — master ( 87995b...abed83 )

ShortsTrait::r() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like