Issues in HttpTrait.php (master) - Issues in master - EvilFreelancer/rezdy-api-php - Measure and Improve Code Quality continuously with Scrutinizer

Issues (11)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/HttpTrait.php (4 issues)

Labels

Severity

Major 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Rezdy;

use ErrorException;
use GuzzleHttp\RequestOptions;
use Psr\Http\Message\ResponseInterface;
use Rezdy\Exceptions\EmptyResults;

/**
 * @author  Paul Rock <[email protected]>
 * @link    https://drteam.rocks
 * @license MIT
 * @package Rezdy
 */
trait HttpTrait
{
    /**
     * Initial state of some variables
     *
     * @var \GuzzleHttp\Client
     */
    private $client;

    /**
     * Object of main config
     *
     * @var \Rezdy\Config
     */
    protected $config;

    /**
     * Request executor with timeout and repeat tries
     *
     * @param string $type   Request method
     * @param string $url    endpoint url
     * @param mixed  $params List of parameters
     *
     * @return null|\Psr\Http\Message\ResponseInterface
     * @throws \GuzzleHttp\Exception\GuzzleException
     * @throws \ErrorException
     */
    private function repeatRequest($type, $url, $params): ?ResponseInterface
    {
        $type = strtoupper($type);

        for ($i = 1; $i < $this->config->get('tries'); $i++) {

            if ($params === null) {
                // Execute the request to server
                $result = $this->client->request($type, $this->config->get('base_uri') . $url);
            } else {
                // Execute the request to server
                $result = $this->client->request($type, $this->config->get('base_uri') . $url, [RequestOptions::FORM_PARAMS => $params->toArray()]);
            }

            // Check the code status
            $code   = $result->getStatusCode();
            $reason = $result->getReasonPhrase();

            // If success response from server
            if ($code === 200 || $code === 201) {
                return $result;
            }

            // If not "too many requests", then probably some bug on remote or our side
            if ($code !== 429) {
                throw new ErrorException($code . ' ' . $reason);
            }

            // Waiting in seconds
            sleep($this->config->get('seconds'));
        }

        // Return false if loop is done but no answer from server
        return null;
    }

    /**
     * Execute request and return response
     *
     * @return null|object Array with data or NULL if error
     * @throws \GuzzleHttp\Exception\GuzzleException
     * @throws \ErrorException
     * @throws \Rezdy\Exceptions\EmptyResults
     */
    public function exec()
    {
        return $this->doRequest($this->type, $this->endpoint, $this->params);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Execute query and return RAW response from remote API
     *
     * @return null|\Psr\Http\Message\ResponseInterface RAW response or NULL if error
     * @throws \GuzzleHttp\Exception\GuzzleException
     * @throws \ErrorException
     * @throws \Rezdy\Exceptions\EmptyResults
     */
    public function raw(): ?ResponseInterface
    {
        return $this->doRequest($this->type, $this->endpoint, $this->params, true);
    }

    /**
     * Make the request and analyze the result
     *
     * @param string $type     Request method
     * @param string $endpoint Api request endpoint
     * @param mixed  $params   List of parameters
     * @param bool   $raw      Return data in raw format
     *
     * @return null|object|ResponseInterface Array with data, RAW response or NULL if error
     * @throws \GuzzleHttp\Exception\GuzzleException
     * @throws \ErrorException
     * @throws \Rezdy\Exceptions\EmptyResults
     */
    private function doRequest($type, $endpoint, $params = null, bool $raw = false)
    {
        // Null by default
        $response = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        // Execute the request to server
        $result = $this->repeatRequest($type, $endpoint, $params);

        if (null === $result) {
            throw new EmptyResults('Empty results returned from Rezdy API');
        }

        // Return RAW result if required
        return $raw ? $result : json_decode($result->getBody(), false);
    }

}


1			<?php
2
3			namespace Rezdy;
4
5			use ErrorException;
6			use GuzzleHttp\RequestOptions;
7			use Psr\Http\Message\ResponseInterface;
8			use Rezdy\Exceptions\EmptyResults;
9
10			/**
11			* @author Paul Rock <[email protected]>
12			* @link https://drteam.rocks
13			* @license MIT
14			* @package Rezdy
15			*/
16			trait HttpTrait
17			{
18			/**
19			* Initial state of some variables
20			*
21			* @var \GuzzleHttp\Client
22			*/
23			private $client;
24
25			/**
26			* Object of main config
27			*
28			* @var \Rezdy\Config
29			*/
30			protected $config;
31
32			/**
33			* Request executor with timeout and repeat tries
34			*
35			* @param string $type Request method
36			* @param string $url endpoint url
37			* @param mixed $params List of parameters
38			*
39			* @return null\|\Psr\Http\Message\ResponseInterface
40			* @throws \GuzzleHttp\Exception\GuzzleException
41			* @throws \ErrorException
42			*/
43			private function repeatRequest($type, $url, $params): ?ResponseInterface
44			{
45			$type = strtoupper($type);
46
47			for ($i = 1; $i < $this->config->get('tries'); $i++) {
48
49			if ($params === null) {
50			// Execute the request to server
51			$result = $this->client->request($type, $this->config->get('base_uri') . $url);
52			} else {
53			// Execute the request to server
54			$result = $this->client->request($type, $this->config->get('base_uri') . $url, [RequestOptions::FORM_PARAMS => $params->toArray()]);
55			}
56
57			// Check the code status
58			$code = $result->getStatusCode();
59			$reason = $result->getReasonPhrase();
60
61			// If success response from server
62			if ($code === 200 \|\| $code === 201) {
63			return $result;
64			}
65
66			// If not "too many requests", then probably some bug on remote or our side
67			if ($code !== 429) {
68			throw new ErrorException($code . ' ' . $reason);
69			}
70
71			// Waiting in seconds
72			sleep($this->config->get('seconds'));
73			}
74
75			// Return false if loop is done but no answer from server
76			return null;
77			}
78
79			/**
80			* Execute request and return response
81			*
82			* @return null\|object Array with data or NULL if error
83			* @throws \GuzzleHttp\Exception\GuzzleException
84			* @throws \ErrorException
85			* @throws \Rezdy\Exceptions\EmptyResults
86			*/
87			public function exec()
88			{
89			return $this->doRequest($this->type, $this->endpoint, $this->params);
			0 ignored issues – show Bug introduced 2019-10-16 15:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `type` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2019-10-16 15:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `endpoint` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2019-10-16 15:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `params` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
90			}
91
92			/**
93			* Execute query and return RAW response from remote API
94			*
95			* @return null\|\Psr\Http\Message\ResponseInterface RAW response or NULL if error
96			* @throws \GuzzleHttp\Exception\GuzzleException
97			* @throws \ErrorException
98			* @throws \Rezdy\Exceptions\EmptyResults
99			*/
100			public function raw(): ?ResponseInterface
101			{
102			return $this->doRequest($this->type, $this->endpoint, $this->params, true);
103			}
104
105			/**
106			* Make the request and analyze the result
107			*
108			* @param string $type Request method
109			* @param string $endpoint Api request endpoint
110			* @param mixed $params List of parameters
111			* @param bool $raw Return data in raw format
112			*
113			* @return null\|object\|ResponseInterface Array with data, RAW response or NULL if error
114			* @throws \GuzzleHttp\Exception\GuzzleException
115			* @throws \ErrorException
116			* @throws \Rezdy\Exceptions\EmptyResults
117			*/
118			private function doRequest($type, $endpoint, $params = null, bool $raw = false)
119			{
120			// Null by default
121			$response = null;
			0 ignored issues – show Unused Code introduced 2019-10-16 15:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$response` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
122
123			// Execute the request to server
124			$result = $this->repeatRequest($type, $endpoint, $params);
125
126			if (null === $result) {
127			throw new EmptyResults('Empty results returned from Rezdy API');
128			}
129
130			// Return RAW result if required
131			return $raw ? $result : json_decode($result->getBody(), false);
132			}
133
134			}
135

EvilFreelancer / rezdy-api-php

Issues (11)

Security Analysis no request data

src/HttpTrait.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like