Issues in Products.php (master) - Issues in master - EvilFreelancer/rezdy-api-php - Measure and Improve Code Quality continuously with Scrutinizer

Issues (11)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Endpoints/Products.php (6 issues)

Labels

Documentation 6

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Rezdy\Endpoints;

use Rezdy\Client;
use Rezdy\Interfaces\ProductInterface;
use Rezdy\Interfaces\ProductsInterface;
use Rezdy\Interfaces\QueryInterface;

class Products extends Client implements ProductInterface, ProductsInterface
{
    /**
     * Get product
     *
     * @param int $productCode
     *
     * @return QueryInterface
     */
    public function __invoke(string $productCode): ProductInterface
    {
        $this->productCode = $productCode;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        // Set HTTP params
        $this->type     = 'get';
        $this->endpoint = '/products/' . $productCode;

        return $this;
    }

    /**
     * Create product
     *
     * @return \Rezdy\Interfaces\QueryInterface
     */
    public function create(): QueryInterface
    {
        // Set HTTP params
        $this->type     = 'post';
        $this->endpoint = '/products';

        return $this;
    }

    /**
     * Update product
     *
     * @return \Rezdy\Interfaces\QueryInterface
     */
    public function update(): QueryInterface
    {
        // Set HTTP params
        $this->type     = 'put';
        $this->endpoint = '/products/' . $this->productCode;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        return $this;
    }

    /**
     * Delete product
     *
     * @return \Rezdy\Interfaces\QueryInterface
     */
    public function delete(): QueryInterface
    {
        // Set HTTP params
        $this->type     = 'delete';
        $this->endpoint = '/products/' . $this->productCode;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        return $this;
    }

    /**
     * Search products
     *
     * @return \Rezdy\Interfaces\QueryInterface
     */
    public function search(): QueryInterface
    {
        // Set HTTP params
        $this->type     = 'get';
        $this->endpoint = '/products';

        return $this;
    }

    /**
     * Search marketplace products
     *
     * @return \Rezdy\Interfaces\QueryInterface
     */
    public function searchMarketplace(): QueryInterface
    {
        // Set HTTP params
        $this->type     = 'get';
        $this->endpoint = '/products/marketplace';

        return $this;
    }

    /**
     * Get product pickups
     *
     * @return \Rezdy\Interfaces\QueryInterface
     */
    public function getPickups(): QueryInterface
    {
        // Set HTTP params
        $this->type     = 'get';
        $this->endpoint = '/products/' . $this->productCode . '/pickups';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        return $this;
    }

    /**
     * Add product image
     *
     * @return \Rezdy\Interfaces\QueryInterface
     */
    public function createImage(): QueryInterface
    {
        // Set HTTP params
        $this->type     = 'post';
        $this->endpoint = '/products/' . $this->productCode . '/images';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        return $this;
    }

    /**
     * Remove product Image
     *
     * @param string $mediaId
     *
     * @return \Rezdy\Interfaces\QueryInterface
     */
    public function getImage(string $mediaId): QueryInterface
    {
        // Set HTTP params
        $this->type     = 'delete';
        $this->endpoint = '/products/' . $this->productCode . '/images/' . $mediaId;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        return $this;
    }

}


1			<?php
2
3			namespace Rezdy\Endpoints;
4
5			use Rezdy\Client;
6			use Rezdy\Interfaces\ProductInterface;
7			use Rezdy\Interfaces\ProductsInterface;
8			use Rezdy\Interfaces\QueryInterface;
9
10			class Products extends Client implements ProductInterface, ProductsInterface
11			{
12			/**
13			* Get product
14			*
15			* @param int $productCode
16			*
17			* @return QueryInterface
18			*/
19			public function __invoke(string $productCode): ProductInterface
20			{
21			$this->productCode = $productCode;
			0 ignored issues – show Documentation introduced 2019-10-17 05:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `productCode` does not exist on `object<Rezdy\Endpoints\Products>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
22
23			// Set HTTP params
24			$this->type = 'get';
25			$this->endpoint = '/products/' . $productCode;
26
27			return $this;
28			}
29
30			/**
31			* Create product
32			*
33			* @return \Rezdy\Interfaces\QueryInterface
34			*/
35			public function create(): QueryInterface
36			{
37			// Set HTTP params
38			$this->type = 'post';
39			$this->endpoint = '/products';
40
41			return $this;
42			}
43
44			/**
45			* Update product
46			*
47			* @return \Rezdy\Interfaces\QueryInterface
48			*/
49			public function update(): QueryInterface
50			{
51			// Set HTTP params
52			$this->type = 'put';
53			$this->endpoint = '/products/' . $this->productCode;
			0 ignored issues – show Documentation introduced 2019-10-17 05:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `productCode` does not exist on `object<Rezdy\Endpoints\Products>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
54
55			return $this;
56			}
57
58			/**
59			* Delete product
60			*
61			* @return \Rezdy\Interfaces\QueryInterface
62			*/
63			public function delete(): QueryInterface
64			{
65			// Set HTTP params
66			$this->type = 'delete';
67			$this->endpoint = '/products/' . $this->productCode;
			0 ignored issues – show Documentation introduced 2019-10-17 05:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `productCode` does not exist on `object<Rezdy\Endpoints\Products>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
68
69			return $this;
70			}
71
72			/**
73			* Search products
74			*
75			* @return \Rezdy\Interfaces\QueryInterface
76			*/
77			public function search(): QueryInterface
78			{
79			// Set HTTP params
80			$this->type = 'get';
81			$this->endpoint = '/products';
82
83			return $this;
84			}
85
86			/**
87			* Search marketplace products
88			*
89			* @return \Rezdy\Interfaces\QueryInterface
90			*/
91			public function searchMarketplace(): QueryInterface
92			{
93			// Set HTTP params
94			$this->type = 'get';
95			$this->endpoint = '/products/marketplace';
96
97			return $this;
98			}
99
100			/**
101			* Get product pickups
102			*
103			* @return \Rezdy\Interfaces\QueryInterface
104			*/
105			public function getPickups(): QueryInterface
106			{
107			// Set HTTP params
108			$this->type = 'get';
109			$this->endpoint = '/products/' . $this->productCode . '/pickups';
			0 ignored issues – show Documentation introduced 2019-10-17 05:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `productCode` does not exist on `object<Rezdy\Endpoints\Products>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
110
111			return $this;
112			}
113
114			/**
115			* Add product image
116			*
117			* @return \Rezdy\Interfaces\QueryInterface
118			*/
119			public function createImage(): QueryInterface
120			{
121			// Set HTTP params
122			$this->type = 'post';
123			$this->endpoint = '/products/' . $this->productCode . '/images';
			0 ignored issues – show Documentation introduced 2019-10-17 05:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `productCode` does not exist on `object<Rezdy\Endpoints\Products>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
124
125			return $this;
126			}
127
128			/**
129			* Remove product Image
130			*
131			* @param string $mediaId
132			*
133			* @return \Rezdy\Interfaces\QueryInterface
134			*/
135			public function getImage(string $mediaId): QueryInterface
136			{
137			// Set HTTP params
138			$this->type = 'delete';
139			$this->endpoint = '/products/' . $this->productCode . '/images/' . $mediaId;
			0 ignored issues – show Documentation introduced 2019-10-17 05:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `productCode` does not exist on `object<Rezdy\Endpoints\Products>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
140
141			return $this;
142			}
143
144			}
145

EvilFreelancer / rezdy-api-php

Issues (11)

Security Analysis no request data

src/Endpoints/Products.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like