OpenVPN\Import

Complexity

Total Complexity

14

Size/Duplication

Total Lines	106
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

88.24%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	3
A	isLine()	0	9	2
A	read()	0	5	1
B	load()	0	23	6
A	parse()	0	13	2

<?php

namespace OpenVPN;

use OpenVPN\Interfaces\ConfigInterface;
use OpenVPN\Interfaces\ImportInterface;
use function strlen;

class Import implements ImportInterface
{
    /**
     * Lines of config file
     *
     * @var array
     */
    public $lines = [];

    /**
     * Import constructor, can import file on starting
     *
     * @param string|null $filename  Path to config file
     * @param bool        $isContent If true, then path mean content of config file
     */
    public function __construct(string $filename = null, bool $isContent = false)
    {
        if ($isContent) {
            $this->load($filename);
        } elseif (null !== $filename) {
            $this->read($filename);
        }
    }

    /**
     * Check if line is valid config line, TRUE if line is okay.
     * If empty line or line with comment then FALSE.
     *
     * @param string $line
     *
     * @return bool
     */
    private function isLine(string $line): bool
    {
        return !(
            // Empty lines
            preg_match('/^\n+|^[\t\s]*\n+/m', $line) ||
            // Lines with comments
            preg_match('/^#/m', $line)
        );
    }

    /**
     * Read configuration file line by line
     *
     * @param string $filename
     *
     * @return array Array with count of total and read lines
     */
    public function read(string $filename): array
    {
        $content = file_get_contents($filename);
        return $this->load($content);
    }

    /**
     * Load content from text of config
     *
     * @param string $content Content of config file
     * @param string $type    Type of loaded content: raw (default), json
     *
     * @return array Array with count of total and read lines
     */
    public function load(string $content, string $type = 'raw'): array
    {
        $result = ['total' => 0, 'read' => 0];

        if ($type === 'raw') {
            $lines = explode("\n", $content);
        } elseif ($type === 'json') {
            $lines = json_decode($json, false);

The variable $json does not exist. Did you forget to declare it?

        }

        // Read line by line
        foreach ($lines as $line) {

The variable $lines does not seem to be defined for all execution paths leading up to this point.

            $line = trim($line);
            // Save line only of not empty
            if ($this->isLine($line) && strlen($line) > 1) {
                $line          = trim(preg_replace('/\s+/', ' ', $line));
                $this->lines[] = $line;
                $result['read']++;
            }
            $result['total']++;
        }
        return $result;
    }

    /**
     * Parse readed lines
     *
     * @return \OpenVPN\Interfaces\ConfigInterface
     */
    public function parse(): ConfigInterface
    {
        $config = new Config();
        array_map(
            static function ($line) use ($config) {
                if (preg_match('/^(\S+)( (.*))?/', $line, $matches)) {
                    $config->set($matches[1], $matches[3] ?? true);
                }
            },
            $this->lines
        );
        return $config;
    }
}