EasyRSA\Downloader

Complexity

Total Complexity

7

Size/Duplication

Total Lines	89
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	curlExec()	0	19	3
A	downloadLatestVersion()	0	10	1
A	getEasyRSA()	0	4	1
A	getLatestVersion()	0	6	1
A	extractArchive()	0	7	1

<?php

declare(strict_types=1);

namespace EasyRSA;

use EasyRSA\Interfaces\DownloaderInterface;
use splitbrain\PHPArchive\Tar;

class Downloader extends Worker implements DownloaderInterface
{
    /**
     * Url via which possible to get the latest release of EasyRSA.
     */
    public const URL_LATEST_RELEASE = 'https://api.github.com/repos/OpenVPN/easy-rsa/releases/latest';

    /**
     * Exec some operation by cURL.
     *
     * @param string      $url
     * @param string|null $filename
     *
     * @return string|null
     */
    private function curlExec(string $url, string $filename = null): ?string
    {
        $curl = curl_init();

        curl_setopt($curl, CURLOPT_USERAGENT, 'useragent');

It seems like $curl can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

        curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);
        curl_setopt($curl, CURLOPT_URL, $url);
        curl_setopt($curl, CURLOPT_FOLLOWLOCATION, true);

        // If filename is not set
        if (null !== $filename) {
            $fp = fopen($filename, 'wb+');
            curl_setopt($curl, CURLOPT_FILE, $fp);
        }

        $result = curl_exec($curl);

It seems like $curl can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

        curl_close($curl);

It seems like $curl can also be of type false; however, parameter $ch of curl_close() does only seem to accept resource, maybe add an additional type check?

        return is_bool($result) ? null : $result;
    }

    /**
     * {@inheritdoc}
     */
    public function getLatestVersion(): string
    {
        $json = $this->curlExec(self::URL_LATEST_RELEASE);
        $json = json_decode($json, true, 512, JSON_THROW_ON_ERROR);

        return $json['tarball_url'];
    }

    /**
     * {@inheritdoc}
     */
    public function downloadLatestVersion(): ?string
    {
        // Get full path to archive file
        $filename = $this->config->getArchive();

The method getArchive() does not exist on EasyRSA\Interfaces\ConfigInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to EasyRSA\Interfaces\ConfigInterface.

        // Get url with latest release
        $latest = $this->getLatestVersion();

        // Download and return status
        return $this->curlExec($latest, $filename);
    }

    /**
     * {@inheritdoc}
     *
     * @throws \splitbrain\PHPArchive\ArchiveIllegalCompressionException If archive is broken
     * @throws \splitbrain\PHPArchive\ArchiveIOException If not possible to read archive
     * @throws \splitbrain\PHPArchive\ArchiveCorruptedException If archive corrupted
     */
    public function extractArchive(): array
    {
        $tar = new Tar();
        $tar->open($this->config->get('archive'));
        $tar->extract($this->config->get('scripts'), 1);

        return $tar->contents();
    }

    /**
     * {@inheritdoc}
     *
     * @throws \splitbrain\PHPArchive\ArchiveIllegalCompressionException If archive is broken
     * @throws \splitbrain\PHPArchive\ArchiveIOException If not possible to read archive
     * @throws \splitbrain\PHPArchive\ArchiveCorruptedException If archive corrupted
     */
    public function getEasyRSA(): void
    {
        $this->downloadLatestVersion();
        $this->extractArchive();
    }
}