Customers - Code Metrics - Inspection of "exception catcher removed from client" - EvilFreelancer/bookeo-api-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 810155...7bbbc8 )

by Mr

created 2019-09-20 10:17 UTC

Customers A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	39
Duplicated Lines	48.72 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	2
lcom	1
cbo	1
dl	19
loc	39
ccs	0
cts	15
cp	0
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	all()	9	9	1
A	create()	10	10	1

How to fix Duplicated Code

<?php

namespace Bookeo\Endpoints;

use Bookeo\Client;
use Bookeo\Models\Customer;
use Bookeo\Models\CustomersList;

/**
 * Operations to manage customers
 *
 * @package Bookeo\Endpoints
 */
class Customers extends Client
{

    /**
     * Retrieve customers
     *
     * Get a list of customers.
     *
     * @return $this
     */
    public function all(): self

    {
        // Set HTTP params
        $this->type     = 'get';
        $this->endpoint = '/customers' . '?' . $this->getQuery();
        $this->response = CustomersList::class;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        return $this;
    }

    /**
     * Create a new customer.
     *
     * Please note there is a limit to the number of customers that can be imported in Bookeo. Bookeo is primarily a booking system, not a CRM.
     *
     * @param Customer $customer
     * @return Customers
     */
    public function create(Customer $customer): self

    {
        // Set HTTP params
        $this->type     = 'post';
        $this->endpoint = '/customers' . '?' . $this->getQuery();
        $this->params   = $customer;
        $this->response = Customer::class;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        return $this;
    }
}


1		<?php
2
3		namespace Bookeo\Endpoints;
4
5		use Bookeo\Client;
6		use Bookeo\Models\Customer;
7		use Bookeo\Models\CustomersList;
8
9		/**
10		* Operations to manage customers
11		*
12		* @package Bookeo\Endpoints
13		*/
14		class Customers extends Client
15		{
16
17		/**
18		* Retrieve customers
19		*
20		* Get a list of customers.
21		*
22		* @return $this
23		*/
24	View Code Duplication	public function all(): self
		0 ignored issues – show Duplication introduced 2019-09-20 10:19 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
25		{
26		// Set HTTP params
27		$this->type = 'get';
28		$this->endpoint = '/customers' . '?' . $this->getQuery();
29		$this->response = CustomersList::class;
		0 ignored issues – show Documentation introduced 2019-09-20 10:19 UTC by Report Bug Copy Issue Report The property `response` does not exist on `object<Bookeo\Endpoints\Customers>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
30
31		return $this;
32		}
33
34		/**
35		* Create a new customer.
36		*
37		* Please note there is a limit to the number of customers that can be imported in Bookeo. Bookeo is primarily a booking system, not a CRM.
38		*
39		* @param Customer $customer
40		* @return Customers
41		*/
42	View Code Duplication	public function create(Customer $customer): self
		0 ignored issues – show Duplication introduced 2019-09-20 10:19 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
43		{
44		// Set HTTP params
45		$this->type = 'post';
46		$this->endpoint = '/customers' . '?' . $this->getQuery();
47		$this->params = $customer;
48		$this->response = Customer::class;
		0 ignored issues – show Documentation introduced 2019-09-20 10:19 UTC by Report Bug Copy Issue Report The property `response` does not exist on `object<Bookeo\Endpoints\Customers>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
49
50		return $this;
51		}
52		}
53

EvilFreelancer / bookeo-api-php

Push — master ( 810155...7bbbc8 )

Customers A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like