Payments::__invoke() - Code Metrics - Inspection of "payments added, additional method added to Clients..." - EvilFreelancer/bookeo-api-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7bbbc8...a7367f )

by Mr

created 2019-09-20 11:54 UTC

Payments::__invoke() A

↳ Parent: Payments

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	11
ccs	0
cts	8
cp	0
rs	9.9
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	2

<?php

namespace Bookeo\Endpoints;

use Bookeo\Client;
use Bookeo\Models\Payment;
use Bookeo\Models\PaymentsList;

/**
 * Operations to manage payments
 *
 * @package Bookeo\Endpoints
 */
class Payments extends Client
{
    /**
     * Get a list of payments received
     *
     * @return $this
     */
    public function all(): self

    {
        // Set HTTP params
        $this->type     = 'get';
        $this->endpoint = '/payments' . '?' . $this->getQuery();
        $this->response = PaymentsList::class;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        return $this;
    }

    /**
     * Retrieve a specific paymen
     *
     * @param string $payment_id
     *
     * @return $this
     */
    public function __invoke(string $payment_id)
    {
        $this->payment_id = $payment_id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        // Set HTTP params
        $this->type     = 'get';
        $this->endpoint = '/payments/' . $payment_id . '?' . $this->getQuery();
        $this->response = Payment::class;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        return $this;
    }
}


1		<?php
2
3		namespace Bookeo\Endpoints;
4
5		use Bookeo\Client;
6		use Bookeo\Models\Payment;
7		use Bookeo\Models\PaymentsList;
8
9		/**
10		* Operations to manage payments
11		*
12		* @package Bookeo\Endpoints
13		*/
14		class Payments extends Client
15		{
16		/**
17		* Get a list of payments received
18		*
19		* @return $this
20		*/
21	View Code Duplication	public function all(): self
		0 ignored issues – show Duplication introduced 2019-09-20 11:56 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
22		{
23		// Set HTTP params
24		$this->type = 'get';
25		$this->endpoint = '/payments' . '?' . $this->getQuery();
26		$this->response = PaymentsList::class;
		0 ignored issues – show Documentation introduced 2019-09-20 11:56 UTC by Report Bug Copy Issue Report The property `response` does not exist on `object<Bookeo\Endpoints\Payments>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
27
28		return $this;
29		}
30
31		/**
32		* Retrieve a specific paymen
33		*
34		* @param string $payment_id
35		*
36		* @return $this
37		*/
38		public function __invoke(string $payment_id)
39		{
40		$this->payment_id = $payment_id;
		0 ignored issues – show Documentation introduced 2019-09-20 11:56 UTC by Report Bug Copy Issue Report The property `payment_id` does not exist on `object<Bookeo\Endpoints\Payments>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
41
42		// Set HTTP params
43		$this->type = 'get';
44		$this->endpoint = '/payments/' . $payment_id . '?' . $this->getQuery();
45		$this->response = Payment::class;
		0 ignored issues – show Documentation introduced 2019-09-20 11:56 UTC by Report Bug Copy Issue Report The property `response` does not exist on `object<Bookeo\Endpoints\Payments>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
46
47		return $this;
48		}
49		}
50

EvilFreelancer / bookeo-api-php

Push — master ( 7bbbc8...a7367f )

Payments::__invoke() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like