Slots - Code Metrics - Inspection of "additional check" - EvilFreelancer/bookeo-api-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a50b1c...e356c0 )

by Mr

created 2019-09-23 15:23 UTC

Slots A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	12
lcom	0
cbo	1
dl	0
loc	62
ccs	0
cts	37
cp	0
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
C	__invoke()	0	45	12

<?php

namespace Bookeo\Endpoints\Availability;

use Bookeo\Endpoints\Availability;
use Bookeo\Models\SlotList;

class Slots extends Availability
{
    /**
     * Navigate results of a matching slots search
     *
     * @param string $productId    the product id (see /settings/products). If not provided, all products of type "fixed" or "fixedCourse" will be included in the result. If no
     *                             productId is provided, products that are not bookable by customers wil not be included in the result. If productId is provided, the product must
     *                             be of type "fixed" or "fixedCourse". For products of type "flexibleTime", use /availability/matchingslots instead.
     * @param string $startTime    the start time to search from. Required unless pageNavigationToken is used.
     * @param string $endTime      the end time to search to. Required unless pageNavigationToken is used. The maximum date range in a single call is 31 days.
     * @param string $pageNavigationToken
     * @param int    $itemsPerPage maximum: 300
     * @param int    $pageNumber
     *
     * @return $this
     */
    public function __invoke(
        string $productId = null,
        string $startTime = null,
        string $endTime = null,
        int $itemsPerPage = 50,
        string $pageNavigationToken = null,
        int $pageNumber = 1
    ) {
        if (!empty($productId)) {
            $this->appendToQuery('productId', $productId);
        }

        if (!empty($startTime) && empty($pageNavigationToken)) {
            $this->appendToQuery('startTime', $startTime);
        } elseif (empty($startTime) && !empty($pageNavigationToken)) {
            $this->appendToQuery('pageNavigationToken', $pageNavigationToken);
        } elseif (!empty($startTime) && !empty($pageNavigationToken)) {
            $this->appendToQuery('pageNavigationToken', $pageNavigationToken);
        } else {
            throw new \InvalidArgumentException('At least "startTime" or "pageNavigationToken" must be set');
        }

        if (!empty($endTime)) {
            $this->appendToQuery('endTime', $endTime);
        }

        if (!empty($itemsPerPage)) {
            $this->appendToQuery('itemsPerPage', $itemsPerPage);
        }

        if (!empty($pageNavigationToken)) {
            $this->appendToQuery('pageNavigationToken', $pageNavigationToken);
        }

        if (!empty($pageNumber)) {
            $this->appendToQuery('pageNumber', $pageNumber);
        }

        // Set HTTP params
        $this->type     = 'get';
        $this->endpoint = '/availability/slots' . '?' . $this->getQuery();
        $this->response = SlotList::class;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        return $this;
    }
}


1			<?php
2
3			namespace Bookeo\Endpoints\Availability;
4
5			use Bookeo\Endpoints\Availability;
6			use Bookeo\Models\SlotList;
7
8			class Slots extends Availability
9			{
10			/**
11			* Navigate results of a matching slots search
12			*
13			* @param string $productId the product id (see /settings/products). If not provided, all products of type "fixed" or "fixedCourse" will be included in the result. If no
14			* productId is provided, products that are not bookable by customers wil not be included in the result. If productId is provided, the product must
15			* be of type "fixed" or "fixedCourse". For products of type "flexibleTime", use /availability/matchingslots instead.
16			* @param string $startTime the start time to search from. Required unless pageNavigationToken is used.
17			* @param string $endTime the end time to search to. Required unless pageNavigationToken is used. The maximum date range in a single call is 31 days.
18			* @param string $pageNavigationToken
19			* @param int $itemsPerPage maximum: 300
20			* @param int $pageNumber
21			*
22			* @return $this
23			*/
24			public function __invoke(
25			string $productId = null,
26			string $startTime = null,
27			string $endTime = null,
28			int $itemsPerPage = 50,
29			string $pageNavigationToken = null,
30			int $pageNumber = 1
31			) {
32			if (!empty($productId)) {
33			$this->appendToQuery('productId', $productId);
34			}
35
36			if (!empty($startTime) && empty($pageNavigationToken)) {
37			$this->appendToQuery('startTime', $startTime);
38			} elseif (empty($startTime) && !empty($pageNavigationToken)) {
39			$this->appendToQuery('pageNavigationToken', $pageNavigationToken);
40			} elseif (!empty($startTime) && !empty($pageNavigationToken)) {
41			$this->appendToQuery('pageNavigationToken', $pageNavigationToken);
42			} else {
43			throw new \InvalidArgumentException('At least "startTime" or "pageNavigationToken" must be set');
44			}
45
46			if (!empty($endTime)) {
47			$this->appendToQuery('endTime', $endTime);
48			}
49
50			if (!empty($itemsPerPage)) {
51			$this->appendToQuery('itemsPerPage', $itemsPerPage);
52			}
53
54			if (!empty($pageNavigationToken)) {
55			$this->appendToQuery('pageNavigationToken', $pageNavigationToken);
56			}
57
58			if (!empty($pageNumber)) {
59			$this->appendToQuery('pageNumber', $pageNumber);
60			}
61
62			// Set HTTP params
63			$this->type = 'get';
64			$this->endpoint = '/availability/slots' . '?' . $this->getQuery();
65			$this->response = SlotList::class;
			0 ignored issues – show Documentation introduced 2019-09-16 12:07 UTC by Report Bug Copy Issue Report The property `response` does not exist on `object<Bookeo\Endpoints\Availability\Slots>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
66
67			return $this;
68			}
69			}
70

EvilFreelancer / bookeo-api-php

Push — master ( a50b1c...e356c0 )

Slots A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

1 Method

Duplication Side-by-Side

Filter issues like