EvilBengt / bthramverk1-weather

src/Weather/CurlWrapper.php

<?php

namespace EVB\Weather;


/**
 * Wrapper class for basic curl_* functions
 */
class CurlWrapper
{
    /**
     * Executes a curl request and returns the result
     * as a string.
     *
     * @param string $url
     * @return string
     */
    public function fetch(string $url) : string
    {
        $session = \curl_init($url);

        \curl_setopt($session, CURLOPT_RETURNTRANSFER, 1);

It seems like $session can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

        $result = \curl_exec($session);

It seems like $session can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

        \curl_close($session);

It seems like $session can also be of type false; however, parameter $ch of curl_close() does only seem to accept resource, maybe add an additional type check?

        if (!\is_string($result)) {
            $result = "";
        }

        return $result;
    }
}