JsonControllerTest::testRenderPage() - Code Metrics - Inspection of "Fixed scrutinizer config" - EvilBengt/bthramverk1-weather - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Branch — master (97a7ce)

by Anton

created 2019-12-22 15:11 UTC

JsonControllerTest::testRenderPage() A

↳ Parent: JsonControllerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	72
Code Lines	50

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	50
nc	1
nop	0
dl	0
loc	72
rs	9.0909
c	0
b	0
f	0

How to fix Long Method

<?php

namespace EVB\Weather;

// use Anax\DI\DIFactoryConfig;
use PHPUnit\Framework\TestCase;
use AnaxMocks\MockDI;
use AnaxMocks\MockPage;

/**
 * Test JsonController for Weather.
 */
class JsonControllerTest extends TestCase
{
    /**
     * Subject under test.
     *
     * @var JsonController
     */
    private $sut;

    /**
     * DI container / Service Locator mock.
     *
     * @var MockDI
     */
    private $di;

    /**
     * Setup before each test.
     *
     * @return void
     */
    public function setUp()
    {
        $this->di = new MockDI();
        $this->sut = new JsonController();
        $this->sut->setDI($this->di);
    }

    /**
     * Test the route "doc" (GET).
     */
    public function testDocAction()
    {
        $page = new MockPage();

        $this->di->set("page", $page);
        

        $result = $this->sut->docActionGet();

        $this->assertInternalType("array", $result->args);
        /** @scrutinizer ignore-deprecated */ $this->assertInternalType("array", $result->args);
        $this->assertArrayHasKey("title", $result->args);
        $this->assertInternalType("string", $result->args["title"]);
        /** @scrutinizer ignore-deprecated */ $this->assertInternalType("string", $result->args["title"]);
        $this->assertNotEmpty($result->adds);
    }

    /**
     * Test the "renderPage" method.
     * No errors.
     */
    public function testRenderPage()
    {
        $argSearch = [];
        $argResult = [
            [
                "currently" => [
                    "summary" => "test",
                    "precipProbability" => 1,
                    "temperature" => 1,
                    "apparentTemperature" => 1,
                    "windSpeed" => 1,
                    "windGust" => 1
                ],
                "hourly" => [
                    "summary" => "test",
                    "data" => [
                        [
                            "time" => 1576249313,
                            "summary" => "test",
                            "precipProbability" => 1,
                            "temperature" => 1,
                            "apparentTemperature" => 1,
                            "windSpeed" => 1,
                            "windGust" => 1
                        ]
                    ]
                ],
                "daily" => [
                    "summary" => "test",
                    "data" => [
                        [
                            "time" => 1576249313,
                            "summary" => "test",
                            "precipProbability" => 1,
                            "temperatureMin" => 1,
                            "temperatureMax" => 1,
                            "apparentTemperatureMin" => 1,
                            "apparentTemperatureMax" => 1,
                            "windSpeed" => 1,
                            "windGust" => 1
                        ]
                    ]
                ],
            ],
            [
                "daily" => [
                    "data" => [
                        [
                            "time" => 1576249313,
                            "summary" => "test",
                            "precipProbability" => 1,
                            "temperatureMin" => 1,
                            "temperatureMax" => 1,
                            "apparentTemperatureMin" => 1,
                            "apparentTemperatureMax" => 1,
                            "windSpeed" => 1,
                            "windGust" => 1
                        ]
                    ]
                ]
            ]
        ];
        $argMapLink = "test";
        $argError = "";

        $result = $this->sut->renderPage($argSearch, $argResult, $argMapLink, $argError);

        $this->assertInternalType("array", $result);
        /** @scrutinizer ignore-deprecated */ $this->assertInternalType("array", $result);
        $this->assertInternalType("array", $result[0]);
        /** @scrutinizer ignore-deprecated */ $this->assertInternalType("array", $result[0]);
        $this->assertArrayHasKey("forecast", $result[0]);
        $this->assertArrayHasKey("historical", $result[0]);
        $this->assertArrayHasKey("poweredBy", $result[0]);
    }

    /**
     * Test the "renderPage" method.
     * With errors.
     *
     * @return void
     */
    public function testRenderPageError()
    {
        $result = $this->sut->renderPage([], [], "test", "test");

        $this->assertInternalType("array", $result);
        /** @scrutinizer ignore-deprecated */ $this->assertInternalType("array", $result);
        $this->assertInternalType("array", $result[0]);
        /** @scrutinizer ignore-deprecated */ $this->assertInternalType("array", $result[0]);
        $this->assertArrayHasKey("error", $result[0]);
        $this->assertEquals("test", $result[0]["error"]);
    }
}


EvilBengt / bthramverk1-weather

Branch — master (97a7ce)

JsonControllerTest::testRenderPage() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like